pm_qos: Fix reversed min and max
PATCH 1/1 pm_qos: Fix reversed min and max
pm_qos_get_value had min and max reversed, causing all pm_qos requests to have no effect.
--- kernel/pm_qos_params.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/pm_qos_params.c +2 -2
@@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)switch (o->type) {case PM_QOS_MIN : -return plist_last (&o->requests)->prio; +return plist_first (&o->requests)->prio;case PM_QOS_MAX : -return plist_first (&o->requests)->prio; +return plist_last (&o->requests)->prio;default :/* runtime check for not using enum */
Signature · 1 line
1.7.3.1
Quoted 2 lines · Colin Cross
pm_qos_get_valuehad min and max reversed, causing allpm_qosrequests to have no effect.
sorry.
--mgross
Quoted 30 lines
Change-Id I252c764821eac8d94de57eb482c05bf6afcea15bCc "Rafael J. Wysocki" <[email protected]>Cc mark gross <[email protected]>Cc James Bottomley <[email protected]>Cc stable <[email protected]>Signed-off-by Colin Cross <[email protected]>--- kernel/pm_qos_params.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)kernel/pm_qos_params.c +2
-2@@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)switch (o->type) {case PM_QOS_MIN : -return plist_last (&o->requests)->prio; +return plist_first (&o->requests)->prio;case PM_QOS_MAX : -return plist_first (&o->requests)->prio; +return plist_last (&o->requests)->prio;default :/* runtime check for not using enum */ Signature · 1 line
1.7.3.1
Quoted 2 lines · Colin Cross
pm_qos_get_valuehad min and max reversed, causing allpm_qosrequests to have no effect.
sorry.
--mgross
Quoted 30 lines
Change-Id I252c764821eac8d94de57eb482c05bf6afcea15bCc "Rafael J. Wysocki" <[email protected]>Cc mark gross <[email protected]>Cc James Bottomley <[email protected]>Cc stable <[email protected]>Signed-off-by Colin Cross <[email protected]>--- kernel/pm_qos_params.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)kernel/pm_qos_params.c +2
-2@@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)switch (o->type) {case PM_QOS_MIN : -return plist_last (&o->requests)->prio; +return plist_first (&o->requests)->prio;case PM_QOS_MAX : -return plist_first (&o->requests)->prio; +return plist_last (&o->requests)->prio;default :/* runtime check for not using enum */ Signature · 1 line
1.7.3.1
Rafael J. Wysocki
AppliedQuoted 6 lines · mark gross
Quoted 2 lines · Colin Cross
pm_qos_get_valuehad min and max reversed, causing allpm_qosrequests to have no effect.sorry.
Acked-by mark <[email protected]>
Applied to suspend-2.6/linux-next, will push to Linus next week.
Thanks,
Rafael
Quoted 34 lines
Quoted 17 lines
Change-Id I252c764821eac8d94de57eb482c05bf6afcea15bCc "Rafael J. Wysocki" <[email protected]>Cc mark gross <[email protected]>Cc James Bottomley <[email protected]>Cc stable <[email protected]>Signed-off-by Colin Cross <[email protected]>--- kernel/pm_qos_params.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)kernel/pm_qos_params.c +0
-0@@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)switch (o->type) {kernel/pm_qos_params.c static inline int pm_qos_get_value(struct pm_qos_object *o) · line 129
Quoted 10 lines
kernel/pm_qos_params.c +2
-2case PM_QOS_MIN : -return plist_last (&o->requests)->prio; +return plist_first (&o->requests)->prio;case PM_QOS_MAX : -return plist_first (&o->requests)->prio; +return plist_last (&o->requests)->prio;default :/* runtime check for not using enum */ --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Rafael J. Wysocki
AppliedQuoted 6 lines · mark gross
Quoted 2 lines · Colin Cross
pm_qos_get_valuehad min and max reversed, causing allpm_qosrequests to have no effect.sorry.
Acked-by mark <[email protected]>
Applied to suspend-2.6/linux-next, will push to Linus next week.
Thanks,
Rafael
Quoted 34 lines
Quoted 17 lines
Change-Id I252c764821eac8d94de57eb482c05bf6afcea15bCc "Rafael J. Wysocki" <[email protected]>Cc mark gross <[email protected]>Cc James Bottomley <[email protected]>Cc stable <[email protected]>Signed-off-by Colin Cross <[email protected]>--- kernel/pm_qos_params.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)kernel/pm_qos_params.c +0
-0@@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)switch (o->type) {kernel/pm_qos_params.c static inline int pm_qos_get_value(struct pm_qos_object *o) · line 129
Quoted 10 lines
kernel/pm_qos_params.c +2
-2case PM_QOS_MIN : -return plist_last (&o->requests)->prio; +return plist_first (&o->requests)->prio;case PM_QOS_MAX : -return plist_first (&o->requests)->prio; +return plist_last (&o->requests)->prio;default :/* runtime check for not using enum */ --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/