Skip to contentSkip to conversation

recipes/fluxbox/fluxbox_1.1.1.bb - Fixed depends for libxpm recipes/initscripts/file/halt - Fixed poweroff when booted from NFS

PATCH In review Angelo S. Mavridis Bartolome 2 participants 4 messages Nov 5, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 recipes/fluxbox/fluxbox_1.1.1.bb - Fixed depends for libxpm recipes/initscripts/file/halt - Fixed poweroff when booted from NFS

* Fix to halt courtesy by penghb,patch by angelox_123
* Fix to fluxbox compile with libxpm by angelox_123

---
 recipes/fluxbox/fluxbox_1.1.1.bb |    2 +-
 recipes/initscripts/files/halt   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes/fluxbox/fluxbox_1.1.1.bb +1 -1
index 55a747c..85f4c8b 100644
@@ -2,7 +2,7 @@ DESCRIPTION = "The Fluxbox Windowmanager"
 HOMEPAGE = "http://www.fluxbox.org"
 LICENSE = "MIT"
 DEPENDS = "fontconfig virtual/libx11"
-
+DEPENDS += "libxpm"
 PR = "r1"
 PE = "1"
 
recipes/initscripts/files/halt +1 -1
index d8cab22..b869966 100644
@@ -20,6 +20,6 @@ then
 	hddown=""
 fi
 
-halt -d -f -i -p $hddown
+/bin/busybox poweroff -f
 
 : exit 0
Signature · 1 line
1.7.3.2
#1 lore raw

Am Freitag, den 05.11.2010, 20:25 -0200 schrieb Angelo S. Mavridis Bartolome:

Quoted 2 lines

* Fix to halt courtesy by penghb,patch by angelox_123
* Fix to fluxbox compile with libxpm by angelox_123

Where are the nicknames from? IRC?

Quoted 4 lines
---
 recipes/fluxbox/fluxbox_1.1.1.bb |    2 +-
 recipes/initscripts/files/halt   |    2 +-

[…]

Please send a patch for each change. You could

git commit patch/to/changed/file

to create separate commits. Please only put the recipe name to the beginning of the commit summary as demanded by OE’s commit policy [1].

I would love to see your build configuration and your build error in the commit log too and, if you know it, a small comment why this fix is needed. These files seem to have been around for quite some time so I find it strange that these issues have not been surfaced earlier.

Thanks,

Paul

[1] http://wiki.openembedded.org/index.php/Commit_Policy

#2 lore raw

PATCH 1/1 metano.conf: Removed inutil package

* Removed nano package from default,it isn't need at this time

---
 conf/distro/metano.conf |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
conf/distro/metano.conf +0 -1
index 9bab8d9..6262aa0 100644
@@ -122,7 +122,6 @@ DISTRO_EXTRA_RRECOMMENDS += " \
     mplayer \
     alsa-lib \
     alsa-utils \
-    nano \
     gpe-filemanager \
     gpe-mini-browser \
     ${XSERVER} \
Signature · 1 line
1.7.3.2
#3 lore raw

Re: [PATCH] metano.conf: Removed inutil package

Am Freitag, den 05.11.2010, 20:45 -0200 schrieb Angelo S. Mavridis Bartolome:

Quoted 1 line

* Removed nano package from default,

The commit summary contradicts what this patch does.(?)

Quoted 1 line

it isn't need at this time

Could this be more understandable? Why is nano not needed?

[…]

Please resend and please also update OE’s patch queue [1].

Thanks,

Paul

[1] http://wiki.openembedded.org/index.php/Patchwork