intel: Fix emit_linear_blit to use DWORD aligned width blits
PATCH 1/1 intel: Fix emit_linear_blit to use DWORD aligned width blits
Fixes corruption with glBufferSubData on my machine,
Can someone review and push?
Signature · 11 lines
Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)
Quoted 1 line
From
1e07dce2b9664861d92917426cbb153cc89a1c8dMon Sep 17 00:00:00 2001
From: Peter Clifton <[email protected]>
Date: Fri, 5 Nov 2010 14:26:24 +0000
Subject: [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits
The width of the 2D blits used to copy the data is defined as a 16-bit signed integer, but the pitch must be DWORD aligned. Limit to an integral number of DWORDs, (1 << 15 - 4) rather than (1 << 15 -1).
Fixes corruption to data uploaded with glBufferSubData.
--- src/mesa/drivers/dri/intel/intel_blit.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
src/mesa/drivers/dri/intel/intel_blit.c +5 -2
@@ -483,8 +483,11 @@ intel_emit_linear_blit(struct intel_context *intel,/* Blits are in a different ringbuffer so we don't use them. */ assert (intel->gen <6 ); -/* The pitch is a signed value. */ - pitch =MIN2 (size, (1 <<15 ) -1 ); +/* The pitch hits the GPU as a is a signed value, IN DWORDs. +* But we want width to match pitch. Max width is (1 << 15 - 1), +* rounding that down to the nearest DWORD is 1 << 15 - 4 +*/ + pitch =MIN2 (size, (1 <<15 ) -4 ); height = size / pitch; ok = intelEmitCopyBlit(intel, 1, pitch, src_bo, src_offset, I915_TILING_NONE,
Signature · 1 line
1.7.1
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Peter Clifton
Fixes corruption with glBufferSubData on my machine,
Can someone review and push?
Looks good. Thanks!
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx