Skip to contentSkip to conversation

scripts/get_maintainer.pl: Use --git-fallback more often

PATCH New Joe Perches 1 participant 1 message Nov 6, 2010 6 messages not in the archive GET_MAINTAINER script

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1288133540.4145.37.camel@Joe-Laptop

A message that is not in the archive (sent off-list or not yet received): 1288987842.19564.1.camel@Joe-Laptop

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1288989274.19564.4.camel@Joe-Laptop

A message that is not in the archive (sent off-list or not yet received): [email protected]

Joe Perches

author maintainer
#6 lore raw

PATCH 1/1 scripts/get_maintainer.pl: Use --git-fallback more often

Quoted 3 lines · Andrew Morton

z:/usr/src/git26> perl scripts/get_maintainer.pl -file mm/mempolicy.c [email protected]
[email protected]

Turns out this is an arguable defect in the script.

The MAINTAINERS entry for mm is:

MEMORY MANAGEMENT
L: [email protected]
W: http://www.linux-mm.org
S: Maintained
F: include/linux/mm.h
F: mm/

There's a maintainer entry, but no named individual, so the script doesn't use git history via --git-fallback.

This is also a defect for MAINTAINERS with status entries marked "Orphan" or "Odd fixes".

The script now checks a section for any "M:" entry and that an "S:" entry is supported or maintained. If both those conditions are not satisified, use --git-fallback as appropriate.

---
 scripts/get_maintainer.pl |   38 +++++++++++++++++++++++++++++++++++++-
 1 files changed, 37 insertions(+), 1 deletions(-)
scripts/get_maintainer.pl +37 -1
index 43bace2..139e0ff 100755
@@ -494,6 +494,40 @@ if ($web) {
 
 exit($exit);
 
+sub range_is_maintained {
+    my ($start, $end) = @_;
+
+    for (my $i = $start; $i < $end; $i++) {
+	my $line = $typevalue[$i];
+	if ($line =~ m/^(\C):\s*(.*)/) {
+	    my $type = $1;
+	    my $value = $2;
+	    if ($type eq 'S') {
+		if ($value =~ /(maintain|support)/i) {
+		    return 1;
+		}
+	    }
+	}
+    }
+    return 0;
+}
+
+sub range_has_maintainer {
+    my ($start, $end) = @_;
+
+    for (my $i = $start; $i < $end; $i++) {
+	my $line = $typevalue[$i];
+	if ($line =~ m/^(\C):\s*(.*)/) {
+	    my $type = $1;
+	    my $value = $2;
+	    if ($type eq 'M') {
+		return 1;
+	    }
+	}
+    }
+    return 0;
+}
+
 sub get_maintainers {
     %email_hash_name = ();
     %email_hash_address = ();
@@ -556,7 +590,9 @@ sub get_maintainers {
 				my $file_pd = ($file  =~ tr@/@@);
 				$value_pd++ if (substr($value,-1,1) ne "/");
 				$value_pd = -1 if ($value =~ /^\.\*/);
-				if ($value_pd >= $file_pd) {
+				if ($value_pd >= $file_pd &&
+				    range_is_maintained($start, $end) &&
+				    range_has_maintainer($start, $end)) {
 				    $exact_pattern_match_hash{$file} = 1;
 				}
 				if ($pattern_depth == 0 ||