ASoC: Ensure sane WM835x AIF configuration by default
Subsystems (3)
PATCH 1/1 ASoC: Ensure sane WM835x AIF configuration by default
Ensure that whatever ran before us leaves the WM835x with a sane default audio interface configuration as we do not override the companding, loopback or tristate settings and do not reset the chip at startup (as it is a PMIC).
Reported-by Keiji Mitsuhisa <[email protected]>
Signed-off-by Mark Brown <[email protected]>
--- sound/soc/codecs/wm8350.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
sound/soc/codecs/wm8350.c +7 -0
@@ -1586,6 +1586,13 @@ static int wm8350_codec_probe(struct snd_soc_codec *codec)wm8350_set_bits (wm8350,WM8350_ROUT2_VOLUME ,WM8350_OUT2_VU |WM8350_OUT2R_MUTE ); +/* Make sure AIF tristating is disabled by default */ +wm8350_clear_bits (wm8350,WM8350_AI_FORMATING ,WM8350_AIF_TRI ); + +/* Make sure we've got a sane companding setup too */ +wm8350_clear_bits (wm8350,WM8350_ADC_DAC_COMP , +WM8350_DAC_COMP |WM8350_LOOPBACK ); +/* Make sure jack detect is disabled to start off with */ wm8350_clear_bits (wm8350,WM8350_JACK_DETECT ,WM8350_JDL_ENA |WM8350_JDR_ENA );
Signature · 1 line
1.7.1
Quoted 11 lines · Mark Brown
Ensure that whatever ran before us leaves the WM835x with a sane default audio interface configuration as we do not override the companding, loopback or tristate settings and do not reset the chip at startup (as it is a PMIC).
Reported-by Keiji Mitsuhisa <[email protected]>Signed-off-by Mark Brown <[email protected]>--- sound/soc/codecs/wm8350.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
Acked-by Liam Girdwood <[email protected]>
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk