: hvmloader: fix off-by-one-bit error when initialising PCI devices
PATCH 1/1 : hvmloader: fix off-by-one-bit error when initialising PCI devices
hvmloader is responsible for - amoungst other things - initialising the PCI device BARs prior to loading the guest BIOS. The previous code only probed for devfn up to 128. The lower 3 bits are function IDs so this meant that only devices in slots 0-15 were actually being initialized.
Signed-off-by Alex Zeffertt <[email protected]>
Acked-by Gianni Tedesco <[email protected]>
tools/firmware/hvmloader/hvmloader.c +3 -3
@@ -196,7 +196,7 @@ static void pci_setup(void)outb (0x4d1 , (uint8_t )(PCI_ISA_IRQ_MASK >>8 ));/* Scan the PCI bus and map resources. */ -for ( devfn =0 ; devfn <128 ; devfn++ ) +for ( devfn =0 ; devfn <256 ; devfn++ ) { class =pci_readw (devfn,PCI_CLASS_DEVICE ); vendor_id =pci_readw (devfn,PCI_VENDOR_ID );
@@ -470,7 +470,7 @@ static int scan_etherboot_nic(uint32_t cuint16_t class, vendor_id, device_id;int rom_size =0 ; -for ( devfn =0 ; (devfn <128 ) && !rom_size; devfn++ ) +for ( devfn =0 ; (devfn <256 ) && !rom_size; devfn++ ) { class =pci_readw (devfn,PCI_CLASS_DEVICE ); vendor_id =pci_readw (devfn,PCI_VENDOR_ID );
@@ -497,7 +497,7 @@ static int pci_load_option_roms(uint32_tuint16_t vendor_id, device_id;uint8_t devfn, class; -for ( devfn =0 ; devfn <128 ; devfn++ ) +for ( devfn =0 ; devfn <256 ; devfn++ ) { class =pci_readb (devfn,PCI_CLASS_DEVICE +1 ); vendor_id =pci_readw (devfn,PCI_VENDOR_ID );