Skip to contentSkip to conversation

TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup

PATCH New Becky Bruce 3 participants 4 messages Nov 11, 2010 – Nov 12, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup

The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.

---
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.

 board/tqc/tqm85xx/tqm85xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/tqc/tqm85xx/tqm85xx.c +1 -1
index 2c3885f..b21e791 100644
@@ -298,7 +298,7 @@ int misc_init_r (void)
 	 */
 	set_lbc_or(0, ((-flash_info[1].size) & 0xffff8000) |
 		   (CONFIG_SYS_OR0_PRELIM & 0x00007fff));
-	set_lbc_br(0, gd->bd->bi_flashstart |
+	set_lbc_br(0, (gd->bd->bi_flashstart + flash_info[0].size) |
 		   (CONFIG_SYS_BR0_PRELIM & 0x00007fff));
 
 	/*
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 1/1 TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup

Dear Becky Bruce,

Quoted 7 lines · In message <[email protected]> you…

The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.

---
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.

It build just fine for me... What exactly are your problems? [And which tool chain are you using?]

Your patch indeed fixes the problem (and I'm a bit angry with myself that I didn't see this problem myself.)

Thanks a lot!

Tested on TQM8555.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We are all agreed that your  theory  is  crazy.  The  question  which
divides  us  is  whether it is crazy enough to have a chance of being
correct. My own feeling is that it is not crazy enough.  - Niels Bohr
#2 lore raw

PATCH 1/1 TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup

Quoted 6 lines · Wolfgang Denk

Dear Becky Bruce,

Quoted 3 lines · In message <[email protected]> you…

The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.

Quoted 7 lines
Quoted 4 lines

---
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.

It build just fine for me... What exactly are your problems? [And which tool chain are you using?]

Actually, that looks to be spurious - I thought i was building from a clean tree but turns out it wasn't. When I do a clean and then a build it works fine. This is what happens when you write code from your car.....

Quoted 4 lines

Your patch indeed fixes the problem (and I'm a bit angry with myself that I didn't see this problem myself.)

Well, that's two of us, because I'm a bit angry at myself for causing it :)

Cheers,
B

Quoted 20 lines

Thanks a lot!

Tested on TQM8555.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We are all agreed that your  theory  is  crazy.  The  question  which
divides  us  is  whether it is crazy enough to have a chance of being
correct. My own feeling is that it is not crazy enough.  - Niels Bohr
Applied
#3 lore raw

PATCH 1/1 TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup

In reply to Becky Bruce
Quoted 10 lines · Becky Bruce

The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.

---
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.

board/tqc/tqm85xx/tqm85xx.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

applied to 85xx

- k