nommu: yield CPU periodically while disposing large VM
Subsystems (2)
PATCH RESEND 1/1 nommu: yield CPU periodically while disposing large VM
Depending on processor speed, page size, and the amount of memory a process is allowed to amass, cleanup of a large VM may freeze the system for many seconds. This can result in a watchdog timeout.
Make sure other tasks receive some service when cleaning up large VMs.
---
mm/nommu.c +6 -0
@@ -1656,6 +1656,7 @@ SYSCALL_DEFINE2(munmap, unsigned long, avoid exit_mmap (struct mm_struct *mm) {struct vm_area_struct *vma; +unsigned long next_yield = jiffies +HZ ;if (!mm)return ;
@@ -1668,6 +1669,11 @@ void exit_mmap(struct mm_struct *mm) mm->mmap = vma->vm_next;delete_vma_from_mm (vma);delete_vma (mm, vma); +/* Yield periodically to prevent watchdog timeout */ +if (time_after (jiffies, next_yield)) { +cond_resched (); + next_yield = jiffies +HZ ; + } }kleave ("" );
Andrew Morton
maintainerQuoted 3 lines · On Thu, 11 Nov 2010 14:33:16 -0600 "Steven J. Magnani" <[email protected]>…
Depending on processor speed, page size, and the amount of memory a process is allowed to amass, cleanup of a large VM may freeze the system for many seconds. This can result in a watchdog timeout.
hm, that's no good.
Quoted 17 lines
Make sure other tasks receive some service when cleaning up large VMs.
Signed-off-by Steven J. Magnani <[email protected]>---
diff -uprNa/mm/nommu.cb/mm/nommu.cmm/nommu.c +1
-0@@ -1656,6 +1656,7 @@ SYSCALL_DEFINE2(munmap, unsigned long, avoid exit_mmap (struct mm_struct *mm) {struct vm_area_struct *vma; +unsigned long next_yield = jiffies +HZ ;if (!mm)return ;@@ -1668,6 +1669,11 @@ void exit_mmap(struct mm_struct *mm) mm->mmap = vma->vm_next;
mm/nommu.c void exit_mmap(struct mm_struct *mm) · line 1679
Quoted 10 lines
mm/nommu.c +5
-0delete_vma_from_mm (vma);delete_vma (mm, vma); +/* Yield periodically to prevent watchdog timeout */ +if (time_after (jiffies, next_yield)) { +cond_resched (); + next_yield = jiffies +HZ ; + } }kleave ("" );
You might be able to do this a bit more neatly with __ratelimit:
DEFINE_RATELIMIT_STATE(rl, HZ, 1); ... if (___ratelimit(&rl, NULL)) cond_resched();
but ___ratelimit() isn't really ready for that - it still has (easily fixed) assumptions that it's being used for printk ratelimiting.
But anyway. cond_resched() is pretty efficient and one second is still a very long time. I suspect you don't need the ratelimiting at all?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 25 lines · Andrew Morton
Quoted 22 lines · On Thu, 11 Nov 2010 14:33:16 -0600 "Steven J. Magnani" <[email protected]>…
mm/nommu.c +6
-0@@ -1656,6 +1656,7 @@ SYSCALL_DEFINE2(munmap, unsigned long, avoid exit_mmap (struct mm_struct *mm) {struct vm_area_struct *vma; +unsigned long next_yield = jiffies +HZ ;if (!mm)return ;@@ -1668,6 +1669,11 @@ void exit_mmap(struct mm_struct *mm) mm->mmap = vma->vm_next;delete_vma_from_mm (vma);delete_vma (mm, vma); +/* Yield periodically to prevent watchdog timeout */ +if (time_after (jiffies, next_yield)) { +cond_resched (); + next_yield = jiffies +HZ ; + } }kleave ("" );
[snip]
Quoted 2 lines
cond_resched()is pretty efficient and one second is still a very long time. I suspect you don't need the ratelimiting at all?
Probably not, but the issue was that disposal of "large" VMs can starve the system. Since these are not the norm (otherwise this would have been fixed long ago) I was attempting to limit the impact on more "normal"-sized VMs. Responsiveness is not great with a one-second ratelimit, and as KOSAKI Motohiro points out this fix won't work on systems with short watchdog intervals. I assumed that these were not common.
As efficient as schedule() may be, it still scares me to call it on reclaim of every block of memory allocated by a terminating process, particularly on the relatively slow processors that inhabit NOMMU land. It wasn't obvious to me that it has a quick exit. But since we are talking about sharing the CPU with other processes perhaps this is only an issue in an OOM scenario, when fast reclaim might be more important.
I can certainly respin the patch to call cond_resched() unconditionally if that's the consensus.
Regards,
------------------------------------------------------------------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
Andrew Morton
maintainerQuoted 38 lines · On Mon, 15 Nov 2010 08:29:11 -0600 "Steven J. Magnani" <[email protected]>…
Quoted 25 lines · Andrew Morton
Quoted 22 lines · On Thu, 11 Nov 2010 14:33:16 -0600 "Steven J. Magnani" <[email protected]>…
mm/nommu.c +6
-0@@ -1656,6 +1656,7 @@ SYSCALL_DEFINE2(munmap, unsigned long, avoid exit_mmap (struct mm_struct *mm) {struct vm_area_struct *vma; +unsigned long next_yield = jiffies +HZ ;if (!mm)return ;@@ -1668,6 +1669,11 @@ void exit_mmap(struct mm_struct *mm) mm->mmap = vma->vm_next;delete_vma_from_mm (vma);delete_vma (mm, vma); +/* Yield periodically to prevent watchdog timeout */ +if (time_after (jiffies, next_yield)) { +cond_resched (); + next_yield = jiffies +HZ ; + } }kleave ("" );[snip]
Quoted 2 lines
cond_resched()is pretty efficient and one second is still a very long time. I suspect you don't need the ratelimiting at all?Probably not, but the issue was that disposal of "large" VMs can starve the system. Since these are not the norm (otherwise this would have been fixed long ago) I was attempting to limit the impact on more "normal"-sized VMs. Responsiveness is not great with a one-second ratelimit, and as KOSAKI Motohiro points out this fix won't work on systems with short watchdog intervals. I assumed that these were not common.
Quoted 3 lines
As efficient as
schedule()may be, it still scares me to call it on reclaim of every block of memory allocated by a terminating process, particularly on the relatively slow processors that inhabit NOMMU land.
This is cond_resched(), not schedule()! cond_resched() is just a few instructions, except for the super-rare case where it calls schedule().
Quoted 6 lines
It wasn't obvious to me that it has a quick exit. But since we are talking about sharing the CPU with other processes perhaps this is only an issue in an OOM scenario, when fast reclaim might be more important.
I can certainly respin the patch to call
cond_resched()unconditionally if that's the consensus.
You have a consensus of 1 so far :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 8 lines · Andrew Morton
Quoted 3 lines · On Mon, 15 Nov 2010 08:29:11 -0600 "Steven J. Magnani" <[email protected]>…
As efficient as
schedule()may be, it still scares me to call it on reclaim of every block of memory allocated by a terminating process, particularly on the relatively slow processors that inhabit NOMMU land.This is
cond_resched(), notschedule()!cond_resched()is just a few instructions, except for the super-rare case where it callsschedule().
The light comes on..._cond_resched() is overloaded. I was looking at the static version, which calls schedule(). The extern version is much more lightweight.
I'll respin the patch.
Thanks,
------------------------------------------------------------------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 20 lines
Depending on processor speed, page size, and the amount of memory a process is allowed to amass, cleanup of a large VM may freeze the system for many seconds. This can result in a watchdog timeout.
Make sure other tasks receive some service when cleaning up large VMs.
Signed-off-by Steven J. Magnani <[email protected]>---
diff -uprNa/mm/nommu.cb/mm/nommu.cmm/nommu.c +1
-0@@ -1656,6 +1656,7 @@ SYSCALL_DEFINE2(munmap, unsigned long, avoid exit_mmap (struct mm_struct *mm) {struct vm_area_struct *vma; +unsigned long next_yield = jiffies +HZ ;if (!mm)return ;
mm/nommu.c void exit_mmap(struct mm_struct *mm) · line 1676
Quoted 8 lines
mm/nommu.c +5
-0@@ -1668,6 +1669,11 @@ void exit_mmap(struct mm_struct *mm) mm->mmap = vma->vm_next;delete_vma_from_mm (vma);delete_vma (mm, vma); +/* Yield periodically to prevent watchdog timeout */ +if (time_after (jiffies, next_yield)) { +cond_resched (); + next_yield = jiffies +HZ ; + }
If watchdog tiemr interval is less than HZ, this logic doesn't work. right? If so, I would suggest just remove time_after() and call cond_resched() every time because cond_resched is no-op if TIF_NEED_RESCHED is not setted.