metano.conf - Added on image file name the IMAGE_BASENAME * Added IMAGE_BASENAME on Metano Distro configuration file on IMAGE_NAME * This will help we to identify the names of our images :) * By: angelox_123 (from IRC #metano_linux), developer and mainteiner of Metano Distro
PATCH 1/1 metano.conf - Added on image file name the IMAGE_BASENAME * Added IMAGE_BASENAME on Metano Distro configuration file on IMAGE_NAME * This will help we to identify the names of our images :) * By: angelox_123 (from IRC #metano_linux), developer and mainteiner of Metano Distro
--- conf/distro/metano.conf | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
conf/distro/metano.conf +1 -4
@@ -56,7 +56,7 @@ IPKG_VARIANT = "opkg" ############################################################################# # IMAGES CONFIGURATION ############################################################################# -IMAGE_NAME = "Metano_Linux-PD.Edition-${DISTRO_VERSION}-${MACHINE}" +IMAGE_NAME = "Metano_Linux-PD.Edition-${IMAGE_BASENAME}-${DISTRO_VERSION}-${MACHINE}" CACHE = "${TMPDIR}/cache/${LIBC}/${MACHINE}" DEPLOY_DIR ?= "${TMPDIR}/deploy/${LIBC}"
@@ -119,12 +119,9 @@ DISTRO_EXTRA_RRECOMMENDS += " \ kernel-module-ext2 \ kernel-module-ext3 \ kernel-module-af-packet \ - mplayer \ alsa-lib \ alsa-utils \ nano \ - gpe-filemanager \ - gpe-mini-browser \ ${XSERVER} \ avahi-daemon \ avahi-autoipd \
Signature · 1 line
1.7.2.3
Quoted 5 lines · On Thu, 2010-11-11 at 22:17 -0200, angelox_123 wrote:
CACHE = "${TMPDIR}/cache/${LIBC}/${MACHINE}"
DEPLOY_DIR?= "${TMPDIR}/deploy/${LIBC}"conf/distro/metano.conf +0
-0@@ -119,12 +119,9 @@ DISTRO_EXTRA_RRECOMMENDS += " \ kernel-module-ext2 \ kernel-module-ext3 \
conf/distro/metano.conf DISTRO_EXTRA_RRECOMMENDS += " \ · line 127
Quoted 10 lines
conf/distro/metano.conf +0
-3kernel-module-af-packet \ - mplayer \ alsa-lib \ alsa-utils \ nano \ - gpe-filemanager \ - gpe-mini-browser \ ${XSERVER} \ avahi-daemon \ avahi-autoipd \
Are you removing mplayer because of some do_rootfs issues with iwmmxt on a1200?
If I remember well here was the issue:do_rootfs didn't find mplayer because it didn't look in iwmmxt.
iwmmxt is a package extra arch:PACKAGE_EXTRA_ARCHS += "iwmmxt" is in conf/machine/include/motorola-ezx-base.inc which is required by a1200.conf
Denis.
PATCH 1/1 metano.conf - Added on image file name the IMAGE_BASENAME
* Added IMAGE_BASENAME on Metano Distro configuration file on IMAGE_NAME
* This will help we to identify the names of our images :)
* By: angelox_123 (from IRC #metano_linux),developer and mainteiner of Metano Distro
--- conf/distro/metano.conf | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
conf/distro/metano.conf +1 -4
@@ -56,7 +56,7 @@ IPKG_VARIANT = "opkg" ############################################################################# # IMAGES CONFIGURATION ############################################################################# -IMAGE_NAME = "Metano_Linux-PD.Edition-${DISTRO_VERSION}-${MACHINE}" +IMAGE_NAME = "Metano_Linux-PD.Edition-${IMAGE_BASENAME}-${DISTRO_VERSION}-${MACHINE}" CACHE = "${TMPDIR}/cache/${LIBC}/${MACHINE}" DEPLOY_DIR ?= "${TMPDIR}/deploy/${LIBC}"
@@ -119,12 +119,9 @@ DISTRO_EXTRA_RRECOMMENDS += " \ kernel-module-ext2 \ kernel-module-ext3 \ kernel-module-af-packet \ - mplayer \ alsa-lib \ alsa-utils \ nano \ - gpe-filemanager \ - gpe-mini-browser \ ${XSERVER} \ avahi-daemon \ avahi-autoipd \
Signature · 1 line
1.7.2.3
Re: [PATCH] metano.conf - Added on image file name the IMAGE_BASENAME
According to the commit policy [1] a colon goes after the changed file.
[PATCH] metano.conf: add IMAGE_BASENAME to IMAGE_NAME
Am Donnerstag, den 11.11.2010, 22:24 -0200 schrieb angelox_123:
Sorry for nitpicking the commit message. Since you are going to send further patches, I think it is beneficial since you can consider these rules in the future. The commit messages of Git are normally very well written and can serve as an example [2]. Also beware that I am no native speaker either so my remarks could be wrong.
Quoted 1 line
* Added
IMAGE_BASENAMEon Metano Distro configuration file onIMAGE_NAME
Add IMAGE_BASENAME to IMAGE_NAME in Metano’s configuration file.
(Use present tense in the commit message.)
Quoted 1 line
* This will help we to identify the names of our images :)
s/we/me/
Quoted 1 line
* By:
angelox_123(from IRC #metano_linux),developer and mainteiner of Metano Distro
maint*a*iner
Quoted 1 line
Signed-off-by angelox_123 <[email protected]>
Since non of your patches have been pushed yet (?), is it on purpose you are using your IRC nick name in the SOB line? I would prefer your real name but it is no requirement as far as I know. For the statistics you should decide what you are going to use and stick to it.
Quoted 20 lines
--- conf/distro/metano.conf | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)conf/distro/metano.conf +1
-1@@ -56,7 +56,7 @@ IPKG_VARIANT = "opkg" ############################################################################# # IMAGES CONFIGURATION ############################################################################# -IMAGE_NAME = "Metano_Linux-PD.Edition-${DISTRO_VERSION}-${MACHINE}" +IMAGE_NAME = "Metano_Linux-PD.Edition-${IMAGE_BASENAME}-${DISTRO_VERSION}-${MACHINE}" CACHE = "${TMPDIR}/cache/${LIBC}/${MACHINE}" DEPLOY_DIR ?= "${TMPDIR}/deploy/${LIBC}"@@ -119,12 +119,9 @@ DISTRO_EXTRA_RRECOMMENDS += " \ kernel-module-ext2 \ kernel-module-ext3 \
conf/distro/metano.conf DISTRO_EXTRA_RRECOMMENDS += " \ · line 127
Quoted 10 lines
conf/distro/metano.conf +0
-3kernel-module-af-packet \ - mplayer \ alsa-lib \ alsa-utils \ nano \ - gpe-filemanager \ - gpe-mini-browser \ ${XSERVER} \ avahi-daemon \ avahi-autoipd \
The removal of these programs are not mentioned in the commit message and should be in a separate patch. You can use git rebase -i HEAD~4 and git add --patch to split this up.
Thanks,
Paul
[1] http://wiki.openembedded.org/index.php/Commit_Policy
[2] http://git.kernel.org/?p=git/git.git;a=log
PATCH 1/1 metano.conf: Change eglibc to glibc
* Change eglibc to glibc on Metano's configuration file
--- conf/distro/metano.conf | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
conf/distro/metano.conf +1 -1
@@ -81,7 +81,7 @@ MACHINE_OVERRIDES += "${MACHINE_CLASS}" ############################################################################# # TOOLCHAIN SELECTION ############################################################################# -LIBC ?= "eglibc" +LIBC ?= "glibc" require conf/distro/include/sane-toolchain.inc require conf/distro/include/arm-thumb.inc
Signature · 1 line
1.7.2.3
Re: [PATCH] metano.conf: Change eglibc to glibc
Quoted 2 lines · On Sun, Nov 14, 2010 at 4:20 PM, angelox_123 <[email protected]> wrote:
* Change eglibc to glibc on Metano's configuration file
moving forwards eglibc is being adopted more is there any particular reason this distro should stick to glibc ?
Quoted 27 lines
Signed-off-by Angelo S. Mavridis Bartolome <[email protected]>---
conf/distro/metano.conf | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)conf/distro/metano.conf +1
-1@@ -81,7 +81,7 @@ MACHINE_OVERRIDES += "${MACHINE_CLASS}" ############################################################################# # TOOLCHAIN SELECTION ############################################################################# -LIBC ?= "eglibc" +LIBC ?= "glibc"require conf/distro/include/sane-toolchain.inc
require conf/distro/include/arm-thumb.inc--
1.7.2.3_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel