Skip to contentSkip to conversation

DaVinci: remove bogus DEF_BOOTM definition

PATCH New Wolfgang Denk 2 participants 5 messages Nov 13, 2010 – Nov 19, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DaVinci: remove bogus DEF_BOOTM definition

Some boar config files defined DEF_BOOTM but this was not used anywhere in the code. Remove this bogus define.

Cc Sandeep Paulraj <[email protected]>
---
 include/configs/da830evm.h       |    1 -
 include/configs/da850evm.h       |    1 -
 include/configs/davinci_dvevm.h  |    1 -
 include/configs/davinci_sonata.h |    1 -
 include/configs/tnetv107x_evm.h  |    1 -
 5 files changed, 0 insertions(+), 5 deletions(-)
include/configs/da830evm.h +0 -1
index 1feada9..a7db2f8 100644
@@ -115,7 +115,6 @@
 #define CONFIG_SYS_ALE_MASK		0x8
 #define CONFIG_SYS_MAX_NAND_DEVICE	1 /* Max number of NAND devices */
 #define NAND_MAX_CHIPS			1
-#define DEF_BOOTM			""
 #endif
 
 #ifdef CONFIG_USE_NOR
include/configs/da850evm.h +0 -1
index 7b04be0..b3fb1f2 100644
@@ -99,7 +99,6 @@
 #undef CONFIG_SYS_NAND_HW_ECC
 #define CONFIG_SYS_MAX_NAND_DEVICE	1 /* Max number of NAND devices */
 #define NAND_MAX_CHIPS			1
-#define DEF_BOOTM			""
 #endif
 
 /*
include/configs/davinci_dvevm.h +0 -1
index 186726d..e1b1db1 100644
@@ -138,7 +138,6 @@
 #define CONFIG_SYS_NAND_HW_ECC
 #define CONFIG_SYS_MAX_NAND_DEVICE	1	/* Max number of NAND devices */
 #define CONFIG_ENV_OFFSET		0x0	/* Block 0--not used by bootcode */
-#define DEF_BOOTM		""
 #elif defined(CONFIG_SYS_USE_NOR)
 #ifdef CONFIG_NOR_UART_BOOT
 #define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is loaded by a bootloader */
include/configs/davinci_sonata.h +0 -1
index 0dc89ef..f0eeb90 100644
@@ -126,7 +126,6 @@
 #define CONFIG_SYS_NAND_HW_ECC
 #define CONFIG_SYS_MAX_NAND_DEVICE	1	/* Max number of NAND devices */
 #define CONFIG_ENV_OFFSET		0x0	/* Block 0--not used by bootcode */
-#define DEF_BOOTM		""
 #elif defined(CONFIG_SYS_USE_NOR)
 #ifdef CONFIG_NOR_UART_BOOT
 #define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is loaded by a bootloader */
include/configs/tnetv107x_evm.h +0 -1
index 68290ef..3627ce7 100644
@@ -86,7 +86,6 @@
 #define CONFIG_JFFS2_NAND
 #define NAND_MAX_CHIPS			1
 #define CONFIG_ENV_OFFSET		0x180000
-#define DEF_BOOTM			""
 
 /*
  * davinci_nand is a bit of a misnomer since this particular EMIF block is
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 DaVinci: remove bogus DEF_BOOTM definition

Quoted 8 lines

Some boar config files defined DEF_BOOTM but this was not used anywhere in the code. Remove this bogus define.

Cc Sandeep Paulraj <[email protected]>

---

Wolfgang,

Pushed to u-boot-ti/master

My pull request in the morning did not have this patch.

Can you pull this one too? I can send in an updated pull request.

Thanks,
Sandeep

#2 lore raw

PATCH 1/1 DaVinci: remove bogus DEF_BOOTM definition

Dear Sandeep,

Quoted 6 lines · In message <[email protected]> you…

Pushed to u-boot-ti/master

My pull request in the morning did not have this patch.

Can you pull this one too? I can send in an updated pull request.

Thanks. There is no need for a new pull request.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...this does not mean that some of us should not want, in  a  rather
dispassionate sort of way, to put a bullet through csh's head."
                   - Larry Wall in <[email protected]>
#3 lore raw

PATCH 1/1 DaVinci: remove bogus DEF_BOOTM definition

Quoted 12 lines

Dear Sandeep,

In message <[email protected]>

Quoted 5 lines · you

Pushed to u-boot-ti/master

My pull request in the morning did not have this patch.

Quoted 7 lines
Quoted 1 line

Can you pull this one too? I can send in an updated pull request.

Thanks. There is no need for a new pull request.

Best regards,

Wolfgang Denk

Wolfgang,

Thanks,

I am beginning to like patchwork. That is how I caught the fact that I missed your patch.

Regards,
Sandeep

#4 lore raw

PATCH 1/1 DaVinci: remove bogus DEF_BOOTM definition

Dear Sandeep,

Quoted 2 lines · In message <[email protected]> you…

I am beginning to like patchwork. That is how I caught the fact that I missed your patch.

That's great, thanks!

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... Jesus cried with a loud voice: Lazarus, come forth; the bug  hath
been  found  and  thy  program  runneth.  And  he  that was dead came
forth...                              -- John 11:43-44 [version 2.0?]