Skip to contentSkip to conversation

sata-via: enable magic transmission fix for vt6420

PATCH In review Peter Zijlstra 3 participants 5 messages Nov 14, 2010 – Nov 15, 2010 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sata-via: enable magic transmission fix for vt6420

I was able to reproduce and test the transmission error on vt6420 hardware with the 2G WD drives. Adding the controller ID to this fix seems to result in a properly working system.

---
 drivers/ata/sata_via.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/ata/sata_via.c +2 -2
index 4730c42..2822492 100644
@@ -577,7 +577,7 @@ static void svia_configure(struct pci_dev *pdev)
 	}
 
 	/*
-	 * vt6421 has problems talking to some drives.  The following
+	 * vt642[01] has problems talking to some drives.  The following
 	 * is the fix from Joseph Chan <[email protected]>.
 	 *
 	 * When host issues HOLD, device may send up to 20DW of data
@@ -597,7 +597,7 @@ static void svia_configure(struct pci_dev *pdev)
 	 * https://bugzilla.kernel.org/show_bug.cgi?id=15173
 	 * http://article.gmane.org/gmane.linux.ide/46352
 	 */
-	if (pdev->device == 0x3249) {
+	if (pdev->device == 0x3249 || pdev->device == 0x3149) {
 		pci_read_config_byte(pdev, 0x52, &tmp8);
 		tmp8 |= 1 << 2;
 		pci_write_config_byte(pdev, 0x52, tmp8);
#1 lore raw
Quoted 1 line · Peter Zijlstra

hardware with the 2G WD drives. Adding the controller ID to this fix

Clearly that was meant to say 2T drives :-)

#2 lore raw
In reply to Peter Zijlstra
Quoted 5 lines · Peter Zijlstra

I was able to reproduce and test the transmission error on vt6420 hardware with the 2G WD drives. Adding the controller ID to this fix seems to result in a properly working system.

Please CC linux-ide and myself on all libata patches, as MAINTAINERS and drivers/ata/sata_via.c both indicate.

#3 lore raw
Quoted 9 lines · Jeff Garzik
Quoted 5 lines · Peter Zijlstra

I was able to reproduce and test the transmission error on vt6420 hardware with the 2G WD drives. Adding the controller ID to this fix seems to result in a properly working system.

Please CC linux-ide and myself on all libata patches, as MAINTAINERS and drivers/ata/sata_via.c both indicate.

Oh, I thought I had CC'ed you, you're in the signoff trail of the initial patch, I must have fudged it. Sorry about that.

#4 lore raw
In reply to Peter Zijlstra

Hello, Peter.

Quoted 3 lines · Peter Zijlstra

I was able to reproduce and test the transmission error on vt6420 hardware with the 2G WD drives. Adding the controller ID to this fix seems to result in a properly working system.

Yeah, there was another report on bugzilla and I contacted Joseph a few days ago for confirmation. There are multiple PCI IDs for vt6420 and I think we'll probably have to apply the workaround to all of them. Joseph, can you please confirm this?

Thanks.

Signature · 1 line
tejun