ARM: cns3xxx: Fixup the missing second parameter to addruart macro to allow them to build.
Subsystems (2)
PATCH 1/1 ARM: cns3xxx: Fixup the missing second parameter to addruart macro to allow them to build.
From: Mac Lin <[email protected]>
Fixup the missing second parameter to addruart macro to allow them to build, according to to commit 0e17226f7cd289504724466f4298abc9bdfca3fe.
Enabling DEBUG in head.S would cause:rch/arm/boot/compressed/head.S: Assembler messages:arch/arm/boot/compressed/head.S:1037: Error: too many positional arguments arch/arm/boot/compressed/head.S:1055: Error: too many positional arguments
--- arch/arm/mach-cns3xxx/include/mach/debug-macro.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-cns3xxx/include/mach/debug-macro.S +1 -1
@@ -10,7 +10,7 @@ * published by the Free Software Foundation. */ - .macro addruart,rx + .macro addruart,rx,rtmp mrc p15, 0, \rx, c1, c0 tst \rx, #1 @ MMU enabled? moveq \rx, #0x10000000
Signature · 1 line
1.7.3
PATCH 1/1 ARM: cns3xxx: Fixup the missing second parameter to addruart macro to allow them to build.
Hello,
Quoted 20 lines · On Mon, Nov 15, 2010 at 06:01:54AM +0800, mkl0301 at gmail.com wrote:
From: Mac Lin <[email protected]>
Fixup the missing second parameter to addruart macro to allow them to build, according to to commit
0e17226f7cd289504724466f4298abc9bdfca3fe.Enabling DEBUG in
head.Swould cause:rch/arm/boot/compressed/head.S: Assembler messages:arch/arm/boot/compressed/head.S:1037: Error: too many positional argumentsarch/arm/boot/compressed/head.S:1055: Error: too many positional argumentsSigned-off-by Mac Lin <[email protected]>--- arch/arm/mach-cns3xxx/include/mach/debug-macro.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-cns3xxx/include/mach/debug-macro.S +0
-0
arch/arm/mach-cns3xxx/include/mach/debug-macro.S line 16
Quoted 8 lines
arch/arm/mach-cns3xxx/include/mach/debug-macro.S +1
-1@@ -10,7 +10,7 @@ * published by the Free Software Foundation. */ - .macro addruart,rx + .macro addruart,rx,rtmp mrc p15, 0, \rx, c1, c0 tst \rx, #1 @ MMU enabled? moveq \rx, #0x10000000
This doesn't apply to current Russell's (or Linus') tree. (And is wrong there BTW.) Which version does your patch apply to?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 ARM: cns3xxx: Fixup the missing second parameter to addruart macro to allow them to build.
Quoted 26 lines · Uwe Kleine-K?nig
Hello,
Quoted 23 lines · On Mon, Nov 15, 2010 at 06:01:54AM +0800, mkl0301 at gmail.com wrote:
From: Mac Lin <[email protected]>
Fixup the missing second parameter to addruart macro to allow them to build, according to to commit
0e17226f7cd289504724466f4298abc9bdfca3fe.Enabling DEBUG in
head.Swould cause:rch/arm/boot/compressed/head.S: Assembler messages:arch/arm/boot/compressed/head.S:1037: Error: too many positional argumentsarch/arm/boot/compressed/head.S:1055: Error: too many positional argumentsSigned-off-by Mac Lin <[email protected]>--- arch/arm/mach-cns3xxx/include/mach/debug-macro.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-cns3xxx/include/mach/debug-macro.S +0
-0@@ -10,7 +10,7 @@ * published by the Free Software Foundation. */
Quoted 7 lines
arch/arm/mach-cns3xxx/include/mach/debug-macro.S line 16
Quoted 5 lines
arch/arm/mach-cns3xxx/include/mach/debug-macro.S +1
-1- .macro addruart,rx + .macro addruart,rx,rtmp mrc p15, 0, \rx, c1, c0 tst \rx, #1 @ MMU enabled? moveq \rx, #0x10000000This doesn't apply to current Russell's (or Linus') tree. (And is wrong there BTW.) Which version does your patch apply to?
Uwe,
I know you're trying to help by acking all patches you can find, but you need to think a little deeper first, otherwise you're going to create confusion. This is the second instance this morning...
For instance, with this patch it isn't applicable to the current -rc - which builds fine. This patch is addressing an issue on 2.6.35 and 2.6.36 kernels, and applies fine there. I've already forwarded this to the stable kernel maintainers, along with a note explaining why the usual rule of "get it into Linus' tree first" can't apply.
PATCH 1/1 ARM: cns3xxx: Fixup the missing second parameter to addruart macro to allow them to build.
Hello Russell,
Quoted 35 lines · Russell King - ARM Linux
Quoted 26 lines · Uwe Kleine-K?nig
Hello,
Quoted 23 lines · On Mon, Nov 15, 2010 at 06:01:54AM +0800, mkl0301 at gmail.com wrote:
From: Mac Lin <[email protected]>
Fixup the missing second parameter to addruart macro to allow them to build, according to to commit
0e17226f7cd289504724466f4298abc9bdfca3fe.Enabling DEBUG in
head.Swould cause:rch/arm/boot/compressed/head.S: Assembler messages:arch/arm/boot/compressed/head.S:1037: Error: too many positional argumentsarch/arm/boot/compressed/head.S:1055: Error: too many positional argumentsSigned-off-by Mac Lin <[email protected]>--- arch/arm/mach-cns3xxx/include/mach/debug-macro.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-cns3xxx/include/mach/debug-macro.S +0
-0@@ -10,7 +10,7 @@ * published by the Free Software Foundation. */Quoted 7 lines
arch/arm/mach-cns3xxx/include/mach/debug-macro.S line 16
Quoted 5 lines
arch/arm/mach-cns3xxx/include/mach/debug-macro.S +1
-1- .macro addruart,rx + .macro addruart,rx,rtmp mrc p15, 0, \rx, c1, c0 tst \rx, #1 @ MMU enabled? moveq \rx, #0x10000000This doesn't apply to current Russell's (or Linus') tree. (And is wrong there BTW.) Which version does your patch apply to?
Quoted 3 lines
Uwe,
I know you're trying to help by acking all patches you can find, but
hmm, do you consider that good or bad? Note I don't do this using procmail or such :-)
Quoted 8 lines
you need to think a little deeper first, otherwise you're going to create confusion. This is the second instance this morning...
For instance, with this patch it isn't applicable to the current -rc - which builds fine. This patch is addressing an issue on 2.6.35 and 2.6.36 kernels, and applies fine there. I've already forwarded this to the stable kernel maintainers, along with a note explaining why the usual rule of "get it into Linus' tree first" can't apply.
That's what I suspected, so I asked about the version the patch applies to. IMHO this is a valueable information for the commit log or the patch description that doesn't make it into git.
My intention was to reduce confusion and I wonder who do you think will be confused by my email?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 ARM: cns3xxx: Fixup the missing second parameter to addruart macro to allow them to build.
2010/11/15 Uwe Kleine-K?nig <[email protected]>:
Quoted 51 lines
Hello Russell,
Quoted 34 lines · Russell King - ARM Linux
Quoted 26 lines · Uwe Kleine-K?nig
Hello,
Quoted 23 lines · On Mon, Nov 15, 2010 at 06:01:54AM +0800, mkl0301 at gmail.com wrote:
From: Mac Lin <[email protected]>
Fixup the missing second parameter to addruart macro to allow them to build, according to to commit
0e17226f7cd289504724466f4298abc9bdfca3fe.Enabling DEBUG in
head.Swould cause:rch/arm/boot/compressed/head.S: Assembler messages:arch/arm/boot/compressed/head.S:1037: Error: too many positional argumentsarch/arm/boot/compressed/head.S:1055: Error: too many positional argumentsSigned-off-by Mac Lin <[email protected]>---
?arch/arm/mach-cns3xxx/include/mach/debug-macro.S | ? ?2 +- ?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-cns3xxx/include/mach/debug-macro.S +0
-0@@ -10,7 +10,7 @@? * published by the Free Software Foundation.
? */Quoted 7 lines
Quoted 5 lines
- ? ? ? ? .macro ?addruart,rx
+ ? ? ? ? .macro ?addruart,rx,rtmp
? ? ? ? ? mrc ? ? p15, 0, \rx, c1, c0
? ? ? ? ? tst ? ? \rx, #1 ? ? ? ? ? ? ? ? @ MMU enabled? ? ? ? ? ? moveq ? \rx, ? ? ?#0x10000000This doesn't apply to current Russell's (or Linus') tree. ?(And is wrong there BTW.) ?Which version does your patch apply to?
Quoted 3 lines
Uwe,
I know you're trying to help by acking all patches you can find, but
hmm, do you consider that good or bad? ?Note I don't do this using procmail or such :-)
Quoted 8 lines
you need to think a little deeper first, otherwise you're going to create confusion. ?This is the second instance this morning...
For instance, with this patch it isn't applicable to the current -rc - which builds fine. ?This patch is addressing an issue on 2.6.35 and 2.6.36 kernels, and applies fine there. ?I've already forwarded this to the stable kernel maintainers, along with a note explaining why the usual rule of "get it into Linus' tree first" can't apply.
Quoted 6 lines
That's what I suspected, so I asked about the version the patch applies to. ?IMHO this is a valueable information for the commit log or the patch description that doesn't make it into git.
My intention was to reduce confusion and I wonder who do you think will be confused by my email?
I'm terribly sorry for not adding the kernel source and version information.
The patch is base on Catalin's tree, which based on 2.6.36 of Linus' tree. It is tested on 2.6.36 mostly, but should be able to be applied on 2.6.35 as well.
I was not aware of the changes in 2.6.37-rc1. It seems ok for building image with DEBUG enabled.
Best Regards,
Mac Lin