Skip to contentSkip to conversation

coding-style: Add exception to M12 rule for external enums

PATCH In review Sjur Brændeland 2 participants 5 messages Nov 17, 2010

lore
Share & tools
lore

Sjur Brændeland

author
#0 lore raw

PATCH 1/1 coding-style: Add exception to M12 rule for external enums

From: Sjur Brændeland <[email protected]>

---
 doc/coding-style.txt |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
doc/coding-style.txt +4 -0
index 6fa355e..fb43891 100644
@@ -205,6 +205,10 @@ default:  // wrong
 	break;
 }
 
+However if the enum comes from an external header file outside ofono
+we cannot make any assumption of how the enum is defined and this
+rule might not apply.
+
 O1: Shorten the name
 ====================
 Better to use abbreviation, rather than full name, to name a variable,
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH 1/1 todo: Add Location Service (AGPS) task.

From: Sjur Brændeland <[email protected]>

---
 TODO |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
TODO +8 -0
index bf2305b..dec43fd 100644
@@ -496,3 +496,11 @@ Miscellaneous
 
   Priority: Low
   Complexity: C4
+
+- Add Location Service API for providing basic E911 suport.
+  This will be based on the 27.007 defined AT commands using
+  XML for transport of positioning request and responses.
+
+  Priority: Medium
+  Complexity: C2
+  Owner: Sjur Brændeland <[email protected]>
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [PATCH] todo: Add Location Service (AGPS) task.

Hi Sjur,

Quoted 6 lines · Sjur Brændeland

From: Sjur Brændeland <[email protected]>

---
 TODO |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

Patch has been applied, thanks.

Regards,
-Denis

author
#3 lore raw

PATCH 1/1 stemodem: Change use of types

In reply to Sjur Brændeland

From: Sjur Brændeland <[email protected]>

Use the type __u32 for sequence counting rather than guint32, and "void *" instead of gpointer.
Reduce the size of RTNL message buffer from 4096 to 1024, as this should be sufficient to hold the NEWLINK message.

---
 drivers/stemodem/caif_rtnl.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
drivers/stemodem/caif_rtnl.c +7 -7
index 5d4073a..4c00446 100644
@@ -41,7 +41,7 @@
 #define NLMSG_TAIL(nmsg) \
 	((struct rtattr *) (((void *) (nmsg)) + NLMSG_ALIGN((nmsg)->nlmsg_len)))
 
-#define RTNL_MSG_SIZE 4096
+#define RTNL_MSG_SIZE 1024
 
 struct rtnl_msg {
 	struct nlmsghdr n;

@@ -50,17 +50,17 @@ struct rtnl_msg {
 };
 
 struct iplink_req {
-	guint32 rtnlmsg_seqnr;
-	gpointer user_data;
+	__u32 rtnlmsg_seqnr;
+	void *user_data;
 	caif_rtnl_create_cb_t callback;
 };
 
 static GSList *pending_requests;
-static guint32 rtnl_seqnr;
+static __u32 rtnl_seqnr;
 static guint rtnl_watch;
 static GIOChannel *rtnl_channel;
 
-static struct iplink_req *find_request(guint32 seq)
+static struct iplink_req *find_request(__u32 seq)
 {
 	GSList *list;
 

@@ -169,7 +169,7 @@ static int add_attribute(struct nlmsghdr *n, unsigned int maxlen, int type,
 	return 0;
 }
 
-static inline void prep_rtnl_req(struct rtnl_msg *msg, int reqtype, guint seqnr)
+static inline void prep_rtnl_req(struct rtnl_msg *msg, int reqtype, __u32 seqnr)
 {
 	msg->n.nlmsg_len = NLMSG_LENGTH(sizeof(struct ifinfomsg));
 	msg->n.nlmsg_flags = NLM_F_REQUEST|NLM_F_CREATE|NLM_F_EXCL;

@@ -179,7 +179,7 @@ static inline void prep_rtnl_req(struct rtnl_msg *msg, int reqtype, guint seqnr)
 }
 
 static gboolean netlink_event(GIOChannel *chan,
-				GIOCondition cond, gpointer data)
+				GIOCondition cond, void *data)
 {
 	unsigned char buf[RTNL_MSG_SIZE];
 	int len, sk;
Signature · 1 line
1.7.0.4