ext4: ext4_fill_super shouldn't return 0 on corruption
PATCH 1/1 ext4: ext4_fill_super shouldn't return 0 on corruption
At the start of ext4_fill_super, ret is set to -EINVAL, and any failure path out of that function returns ret. However, the generic_check_addressable clause sets ret = 0 (if it passes), which means that a subsequent failure (e.g. a group checksum error) returns 0 even though the mount should fail. This causes vfs_kern_mount in turn to think that the mount succeeded, leading to an oops.
Signed-off-by "Lukas Czerner" <[email protected]>
Acked-by Darrick J. Wong <[email protected]>
Signed-off-by Lukas Czerner <[email protected]>
--- fs/ext4/super.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
fs/ext4/super.c +3 -2
@@ -3268,13 +3268,14 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)* Test whether we have more sectors than will fit in sector_t, * and whether the max offset is addressable by the page cache. */ - ret =generic_check_addressable (sb->s_blocksize_bits, + err =generic_check_addressable (sb->s_blocksize_bits,ext4_blocks_count (es)); -if (ret) { +if (err) {ext4_msg (sb,KERN_ERR ,"filesystem" " too large to mount safely on this system" );if (sizeof (sector_t) <8 )ext4_msg (sb,KERN_WARNING ,"CONFIG_LBDAF not enabled" ); + ret = err; goto failed_mount; }
Signature · 1 line
1.7.2.3