Skip to contentSkip to conversation

checkpatch: teach checkpatch about rcu

PATCH In review Michael S. Tsirkin 2 participants 3 messages Nov 18, 2010 – Nov 21, 2010 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: teach checkpatch about rcu

I got this:
+ struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
which is because checkpatch does not know about __rcu. So here's a patch to teach it about that tag.

---
 scripts/checkpatch.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/checkpatch.pl +1 -0
index 2039acd..1b11c8e 100755
@@ -143,6 +143,7 @@ our $Sparse	= qr{
 			__must_check|
 			__init_refok|
 			__kprobes|
+			__rcu|
 			__ref
 		}x;
 
Signature · 1 line
1.7.3.2.91.g446ac
#1 lore raw
Quoted 15 lines · Michael S. Tsirkin

I got this:
+ struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
which is because checkpatch does not know about __rcu. So here's a patch to teach it about that tag.

---
 scripts/checkpatch.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/checkpatch.pl +0 -0
index 2039acd..1b11c8e 100755

scripts/checkpatch.pl our $Sparse = qr{ · line 149

Quoted 7 lines
scripts/checkpatch.pl +1 -0
@@ -143,6 +143,7 @@ our $Sparse	= qr{
 			__must_check|
 			__init_refok|
 			__kprobes|
+			__rcu|
 			__ref
 		}x;
 

Hmm, why __percpu is in $Attribute, and __rcu in $Sparse ?

#2 lore raw
Quoted 11 lines · Eric Dumazet
Quoted 10 lines · Michael S. Tsirkin

I got this:
+ struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
which is because checkpatch does not know about __rcu. So here's a patch to teach it about that tag.

---
 scripts/checkpatch.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 16 lines

scripts/checkpatch.pl our $Sparse = qr{ · line 149

Quoted 12 lines
scripts/checkpatch.pl +1 -0
index 2039acd..1b11c8e 100755
@@ -143,6 +143,7 @@ our $Sparse	= qr{
 			__must_check|
 			__init_refok|
 			__kprobes|
+			__rcu|
 			__ref
 		}x;
 

Hmm, why __percpu is in $Attribute, and __rcu in $Sparse ?

I can't say: we have __kernel and __user and __iomem address spaces in $Sparse and only __percpu in $Attribute, so I thought address spaces belong in $Sparse and __percpu just sneaked in there with a ton of other attributes added by 03f1df7da5696ddfa6e167b37e0c0ce5aad3de79.

Should __percpu be moved to $Sparse perhaps?

Signature · 1 line
MST