Skip to contentSkip to conversation

debug_core: cleanup kgdb_cpu_enter() that removing smp_mb()

PATCH New Dongdong Deng 1 participant 1 message Nov 26, 2010 KGDB / KDB /debug_core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 debug_core: cleanup kgdb_cpu_enter() that removing smp_mb()

Commit dfee3a7b92208b30f77876068aece9ea571270c2(debug_core:
refactor locking for master/slave cpus) uses spin_lock to replace the atomic counter lock mechanism, and most kgdb data was designed to per-cpu, thus the 'smp_mb()' operation is useless here now.

---
 kernel/debug/debug_core.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
kernel/debug/debug_core.c +0 -3
index 722968f..1b019b5 100644
@@ -492,9 +492,6 @@ acquirelock:
 	kgdb_info[cpu].ret_state = 0;
 	kgdb_info[cpu].irq_depth = hardirq_count() >> HARDIRQ_SHIFT;
 
-	/* Make sure the above info reaches the primary CPU */
-	smp_mb();
-
 	if (exception_level == 1) {
 		if (raw_spin_trylock(&dbg_master_lock))
 			atomic_xchg(&kgdb_active, cpu);
Signature · 1 line
1.6.0.4