Skip to contentSkip to conversation

usb: Remove usb_dev_init() from ehci-ppc4xx.c

PATCH New Stefan Roese 2 participants 2 messages Nov 26, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: Remove usb_dev_init() from ehci-ppc4xx.c

Calling usb_dev_init() from within the EHCI host driver is wrong. The EHCI host driver should have no dependency/interconnection to the USB device driver.

---
 drivers/usb/host/ehci-ppc4xx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-ppc4xx.c +0 -1
index 946a0a0..1179919 100644
@@ -34,7 +34,6 @@ int ehci_hcd_init(void)
 	hccr = (struct ehci_hccr *)(CONFIG_SYS_PPC4XX_USB_ADDR);
 	hcor = (struct ehci_hcor *)((uint32_t) hccr +
 		HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
-	usb_dev_init();
 	return 0;
 }
 
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 usb: Remove usb_dev_init() from ehci-ppc4xx.c

Hi,

2010/11/26 Stefan Roese <[email protected]>:

Quoted 9 lines

Calling usb_dev_init() from within the EHCI host driver is wrong. The EHCI host driver should have no dependency/interconnection to the USB device driver.

---
?drivers/usb/host/ehci-ppc4xx.c | ? ?1 -
?1 files changed, 0 insertions(+), 1 deletions(-)

Applied to u-boot-usb. Thanks.

Kind regards,

Remy