ppc4xx/POST: Change ethernet test loop count from 192 to 16
PATCH 1/1 ppc4xx/POST: Change ethernet test loop count from 192 to 16
This patch changes the PPC4xx ethernet POST loop test count from currently 192 (256 - 64) to 16 which should be enough. The main reason for this is to reduce the boot time on boards using this POST test, like the lwmon5 board. This change reduces the boot time by about 600ms on the lwmon5 board.
--- post/cpu/ppc4xx/ether.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
post/cpu/ppc4xx/ether.c +2 -2
@@ -76,8 +76,8 @@ DECLARE_GLOBAL_DATA_PTR;#define SDR0_MFR_ETH_CLK_SEL_V (n) ((0x01<<27) / (n+1))#endif -#define MIN_PACKET_LENGTH 64 -#define MAX_PACKET_LENGTH 256 +#define MIN_PACKET_LENGTH 256 +#define MAX_PACKET_LENGTH (256 + 16)#define TEST_NUM 1 static volatile mal_desc_t tx __cacheline_aligned;
Signature · 1 line
1.7.3.2
PATCH 1/1 ppc4xx/POST: Change ethernet test loop count from 192 to 16
Dear Stefan Roese,
Quoted 16 lines · In message <[email protected]> you wrote:
This patch changes the PPC4xx ethernet POST loop test count from currently 192 (256 - 64) to 16 which should be enough. The main reason for this is to reduce the boot time on boards using this POST test, like the lwmon5 board. This change reduces the boot time by about 600ms on the lwmon5 board.
Signed-off-by Stefan Roese <[email protected]>--- post/cpu/ppc4xx/ether.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)post/cpu/ppc4xx/ether.c +0
-0
post/cpu/ppc4xx/ether.c DECLARE_GLOBAL_DATA_PTR; · line 80
Quoted 7 lines
post/cpu/ppc4xx/ether.c +2
-2@@ -76,8 +76,8 @@ DECLARE_GLOBAL_DATA_PTR;#define SDR0_MFR_ETH_CLK_SEL_V (n) ((0x01<<27) / (n+1))#endif -#define MIN_PACKET_LENGTH 64 -#define MAX_PACKET_LENGTH 256 +#define MIN_PACKET_LENGTH 256 +#define MAX_PACKET_LENGTH (256 + 16)
Maybe it does indeed make sense to test a wider range of package sizes. Actually I'd even like to see longer packets tested as well.
How about:
#define MIN_PACKET_LENGTH 64 #define MAX_PACKET_LENGTH 1518
and changing the
for (l = MIN_PACKET_LENGTH; l <= MAX_PACKET_LENGTH; l++) {
into
for (l = MIN_PACKET_LENGTH; l <= MAX_PACKET_LENGTH; l+=91) {Then you still have 16 tests, but with a much wider range of packet sizes (64...1429).
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] "Am besten betrachten Sie Fehlermeldungen als eine Art Psycho-Test, mit dem herausgefunden werden soll, wie belastbar Sie sind." - Dr. R. Wonneberger, Kompaktf?hrer LaTeX, Kap. 1.6: Fehlermeldungen
PATCH 1/1 ppc4xx/POST: Change ethernet test loop count from 192 to 16
Hi Wolfgang,
Quoted 13 lines · On Friday 26 November 2010 16:13:23 Wolfgang Denk wrote:
post/cpu/ppc4xx/ether.c DECLARE_GLOBAL_DATA_PTR; · line 80
Quoted 4 lines
post/cpu/ppc4xx/ether.c +2
-2-#define MIN_PACKET_LENGTH 64 -#define MAX_PACKET_LENGTH 256 +#define MIN_PACKET_LENGTH 256 +#define MAX_PACKET_LENGTH (256 + 16)Maybe it does indeed make sense to test a wider range of package sizes. Actually I'd even like to see longer packets tested as well.
How about:
#define MIN_PACKET_LENGTH 64 #define MAX_PACKET_LENGTH 1518
Quoted 8 lines
and changing the
for (l = MIN_PACKET_LENGTH; l <= MAX_PACKET_LENGTH; l++) { into for (l = MIN_PACKET_LENGTH; l <= MAX_PACKET_LENGTH; l+=91) {Then you still have 16 tests, but with a much wider range of packet sizes (64...1429).
I don't like this "l+=91" statement. How about making it a bit more flexible. Something like this:
#define MIN_PACKET_LENGTH 64
#define MAX_PACKET_LENGTH 1518
#ifndef CONFIG_SYS_POST_ETH_LOOPS
#define CONFIG_SYS_POST_ETH_LOOPS 10
#endif
#define PACKET_INCR ((MAX_PACKET_LENGTH - MIN_PACKET_LENGTH) / \
CONFIG_SYS_POST_ETH_LOOPS)
and
for (l = MIN_PACKET_LENGTH; l <= MAX_PACKET_LENGTH; l += PACKET_INCR) {
This way, boards could also override the default loop counter. I switched to a default of 10 this time. This still seems enough for me. Especially with the longer frames now.
What do you think?
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: [email protected]
PATCH 1/1 ppc4xx/POST: Change ethernet test loop count from 192 to 16
Dear Stefan Roese,
Quoted 11 lines · In message <[email protected]> you wrote:
I don't like this "l+=91" statement. How about making it a bit more flexible. Something like this:
#define
MIN_PACKET_LENGTH64
#defineMAX_PACKET_LENGTH1518
#ifndefCONFIG_SYS_POST_ETH_LOOPS
#defineCONFIG_SYS_POST_ETH_LOOPS10
#endif
#definePACKET_INCR((MAX_PACKET_LENGTH-MIN_PACKET_LENGTH) / \
CONFIG_SYS_POST_ETH_LOOPS)
Agreed. For the final version, please check how MAX_PACKET_LENGTH is used (I didn't do this) and verify that 1518 is the correct value to use here.
Thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Prof: So the American government went to IBM to come up with a
data encryption standard and they came up with ...
Student: EBCDIC!