Skip to contentSkip to conversation

Fix libthread_db matching

PATCH New Javier Viguera 2 participants 3 messages Nov 26, 2010 – Nov 27, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

cover Fix libthread_db matching

Following patch fixes a little bug with the matching of libthread_db library so it is not stripped. Testing with two different toolchains (one based on glibc and the other on uclibc) shows that the current expression matches the symbolic link while the corrected one matches the real file.

$ ls -o */*/sys-root/lib/libthread_db.so*
arm-cortex_a8-linux-gnueabi/arm-cortex_a8-linux-gnueabi/sys-root/lib/libthread_db.so.1 -> libthread_db-1.0.so
arm-unknown-linux-uclibcgnueabi/arm-unknown-linux-uclibcgnueabi/sys-root/lib/libthread_db.so.1 -> libthread_db-0.9.30.3.so
$ ls -o */*/sys-root/lib/libthread_db*.so
arm-cortex_a8-linux-gnueabi/arm-cortex_a8-linux-gnueabi/sys-root/lib/libthread_db-1.0.so
arm-unknown-linux-uclibcgnueabi/arm-unknown-linux-uclibcgnueabi/sys-root/lib/libthread_db-0.9.30.3.so

Javier Viguera (1):
target-finalize: do not strip libthread_db

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
1.7.3.2

#1 lore raw

PATCH 1/1 target-finalize: do not strip libthread_db

Fix previous commit not to strip libthread_db library. In the previous commit the wildcard was incorrectly matching the symbolic link instead of the real library file.

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index 6752aa6..fc165e1 100644
@@ -418,7 +418,7 @@ ifneq ($(BR2_HAVE_DOCUMENTATION),y)
 	rm -rf $(TARGET_DIR)/usr/share/gtk-doc
 	-rmdir $(TARGET_DIR)/usr/share 2>/dev/null
 endif
-	find $(TARGET_DIR) -type f -perm +111 '!' -name 'libthread_db.so*' | \
+	find $(TARGET_DIR) -type f -perm +111 '!' -name 'libthread_db*.so' | \
 		xargs $(STRIPCMD) 2>/dev/null || true
 	find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \
 		xargs -r $(STRIPCMD) $(STRIP_STRIP_UNNEEDED)
Signature · 1 line
1.7.3.2
#2 lore raw

PATCH 1/1 target-finalize: do not strip libthread_db

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Javier" == Javier Viguera <[email protected]> writes:

Javier> Fix previous commit not to strip libthread_db library. In the previous Javier> commit the wildcard was incorrectly matching the symbolic link instead Javier> of the real library file.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard