Skip to contentSkip to conversation

ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe

PATCH In review Axel Lin 4 participants 5 messages Nov 29, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe

Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.

---
 sound/soc/fsl/mpc8610_hpcd.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/fsl/mpc8610_hpcd.c +1 -0
index 0d7dcf1..7d7847a 100644
@@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "platform device add failed\n");
 		goto error;
 	}
+	dev_set_drvdata(&pdev->dev, sound_device);
 
 	of_node_put(codec_np);
 
Signature · 1 line
1.7.2
author
#1 lore raw

PATCH 2/2 ASoC: Add missing dev_set_drvdata in p1022_ds_probe

Otherwise, calling dev_get_drvdata in p1022_ds_remove returns NULL.

---
 sound/soc/fsl/p1022_ds.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/fsl/p1022_ds.c +1 -0
index 63b9eaa..026b756 100644
@@ -498,6 +498,7 @@ static int p1022_ds_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "platform device add failed\n");
 		goto error;
 	}
+	dev_set_drvdata(&pdev->dev, sound_device);
 
 	of_node_put(codec_np);
 
Signature · 1 line
1.7.2
Acked-by on v1 1/2
#2 lore raw
In reply to Axel Lin
Quoted 12 lines · Axel Lin

Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.

---
 sound/soc/fsl/mpc8610_hpcd.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/fsl/mpc8610_hpcd.c +0 -0
index 0d7dcf1..7d7847a 100644

sound/soc/fsl/mpc8610_hpcd.c static int mpc8610_hpcd_probe(struct platform_device *pdev) · line 504

Quoted 7 lines
sound/soc/fsl/mpc8610_hpcd.c +1 -0
@@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "platform device add failed\n");
 		goto error;
 	}
+	dev_set_drvdata(&pdev->dev, sound_device);
 
 	of_node_put(codec_np);
 

All

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk