ARM S3C24XX: Fix compilation of PM code for S3C2416
Subsystems (2)
PATCH 1/1 ARM S3C24XX: Fix compilation of PM code for S3C2416
S3C2416 PM code uses low-level sleep routines from S3C2412 code, but these routines are compiled only for S3C2412 SoC.
Split S3C2412_PM to two parts: S3C2412_PM, S3C2412_PM_SLEEP and select last in S3C2416's Kconfig.
--- arch/arm/mach-s3c2412/Kconfig | 7 +++++++ arch/arm/mach-s3c2412/Makefile | 3 ++- arch/arm/mach-s3c2416/Kconfig | 1 + 3 files changed, 10 insertions(+), 1 deletions(-)
arch/arm/mach-s3c2412/Kconfig +7 -0
@@ -28,9 +28,16 @@ config S3C2412_DMA config S3C2412_PM bool + select S3C2412_PM_SLEEP help Internal config node to apply S3C2412 power management +config S3C2412_PM_SLEEP + bool + help + Internal config node to apply sleep for S3C2412 power management. + Can be selected by another SoCs with similar sleep procedure. + # Note, the S3C2412 IOtiming support is in plat-s3c24xx config S3C2412_CPUFREQ
arch/arm/mach-s3c2412/Makefile +2 -1
@@ -14,7 +14,8 @@ obj-$(CONFIG_CPU_S3C2412) += irq.o obj-$(CONFIG_CPU_S3C2412) += clock.o obj-$(CONFIG_CPU_S3C2412) += gpio.o obj-$(CONFIG_S3C2412_DMA) += dma.o -obj-$(CONFIG_S3C2412_PM) += pm.o sleep.o +obj-$(CONFIG_S3C2412_PM) += pm.o +obj-$(CONFIG_S3C2412_PM_SLEEP) += sleep.o obj-$(CONFIG_S3C2412_CPUFREQ) += cpu-freq.o # Machine support
arch/arm/mach-s3c2416/Kconfig +1 -0
@@ -27,6 +27,7 @@ config S3C2416_DMA config S3C2416_PM bool + select S3C2412_PM_SLEEP help Internal config node to apply S3C2416 power management
Signature · 1 line
1.7.2.3
PATCH 1/1 ARM S3C24XX: Fix compilation of PM code for S3C2416
Quoted 7 lines · Yauhen Kharuzhy
S3C2416 PM code uses low-level sleep routines from S3C2412 code, but these routines are compiled only for S3C2412 SoC.
Split
S3C2412_PMto two parts:S3C2412_PM,S3C2412_PM_SLEEPand select last in S3C2416'sKconfig.Signed-off-by Yauhen Kharuzhy <[email protected]>
ping?
Signature · 5 lines
Yauhen Kharuzhy jekhor _at_ gmail.com JID: jek at jabber.ru A: No Q: Should I quote below my post?
PATCH 1/1 ARM S3C24XX: Fix compilation of PM code for S3C2416
In reply to Yauhen KharuzhyReview
Quoted 36 lines · Yauhen Kharuzhy
S3C2416 PM code uses low-level sleep routines from S3C2412 code, but these routines are compiled only for S3C2412 SoC.
Split
S3C2412_PMto two parts:S3C2412_PM,S3C2412_PM_SLEEPand select last in S3C2416'sKconfig.Signed-off-by Yauhen Kharuzhy <[email protected]>--- arch/arm/mach-s3c2412/Kconfig | 7 +++++++ arch/arm/mach-s3c2412/Makefile | 3 ++- arch/arm/mach-s3c2416/Kconfig | 1 + 3 files changed, 10 insertions(+), 1 deletions(-)arch/arm/mach-s3c2412/Kconfig +7
-0@@ -28,9 +28,16 @@ config S3C2412_DMA config S3C2412_PM bool + select S3C2412_PM_SLEEP help Internal config node to apply S3C2412 power management +config S3C2412_PM_SLEEP + bool + help + Internal config node to apply sleep for S3C2412 power management. + Can be selected by another SoCs with similar sleep procedure. + # Note, the S3C2412 IOtiming support is in plat-s3c24xx config S3C2412_CPUFREQ(quoted diff) +0
-0
b/arch/arm/mach-s3c2412/Makefile
Quoted 26 lines
index 530ec46..6c48a91 100644
arch/arm/mach-s3c2412/Makefile +2
-1@@ -14,7 +14,8 @@ obj-$(CONFIG_CPU_S3C2412) += irq.o obj-$(CONFIG_CPU_S3C2412) += clock.o obj-$(CONFIG_CPU_S3C2412) += gpio.o obj-$(CONFIG_S3C2412_DMA) += dma.o -obj-$(CONFIG_S3C2412_PM) += pm.o sleep.o +obj-$(CONFIG_S3C2412_PM) += pm.o +obj-$(CONFIG_S3C2412_PM_SLEEP) += sleep.o obj-$(CONFIG_S3C2412_CPUFREQ) += cpu-freq.o # Machine supportarch/arm/mach-s3c2416/Kconfig +1
-1@@ -27,6 +27,7 @@ config S3C2416_DMA config S3C2416_PM bool + select S3C2412_PM_SLEEP help Internal config node to apply S3C2416 power management --
Quoted 1 line
1.7.2.3
Hi,
Yeah, ok...will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.