Skip to contentSkip to conversation

bluez-dtl1-workaround not provided?

PATCH New Andrea Adami 6 participants 9 messages Nov 25, 2010 – Dec 1, 2010

lore
Share & tools
lore
#0 lore raw

Hello,

build from scratch of console image for c7x0/armv5te leads to:

...
Configuring sysvinit.
Collected errors:
* satisfy_dependencies_for: Cannot satisfy the following dependencies
for task-base-extended:
* <--->bluez-dtl1-workaround *.
* opkg_install_cmd: Cannot install package task-base-extended.
* resolve_conffiles: Existing conffile
/oe/build/tmp/rootfs/console-image/etc/device_table is different from the conffile in the new package. The new conffile will be placed at /oe/build/tmp/rootfs/console-image/etc/device_table-opkg.

A quick grep reveals:

andrea@mizar /oe/openembedded $ grep -R bluez-dtl1-workaround . Binary file ./.git/index matches ./classes/kernel.bbclass:DEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround" ./classes/kernel.bbclass:RDEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround" ./conf/machine/jornada7xx.conf:MACHINE_EXTRA_RDEPENDS = "kernel-modules bluez-dtl1-workaround"
./recipes/tasks/task-base.bb: ${@base_contains('COMBINED_FEATURES',
'pcmcia', 'bluez-dtl1-workaround', '',d)} \
./recipes/tasks/task-base.bb:# bluez-dtl1-workaround above is workaround for bitbake not handling DEPENDS on it in
andrea@mizar /oe/openembedded $

So, first doubt is: why make this mandatory for everyone having pcmcia? Second, why is it failing now?

Any idea?

Andrea

#1 lore raw

2010/11/25 Andrea Adami <[email protected]>:

Quoted 32 lines

Hello,

build from scratch of console image for c7x0/armv5te leads to:

...
Configuring sysvinit.
Collected errors:
 * satisfy_dependencies_for: Cannot satisfy the following dependencies for task-base-extended:
 * <--->bluez-dtl1-workaround *.
 * opkg_install_cmd: Cannot install package task-base-extended.
 * resolve_conffiles: Existing conffile /oe/build/tmp/rootfs/console-image/etc/device_table is different from the conffile in the new package. The new conffile will be placed at /oe/build/tmp/rootfs/console-image/etc/device_table-opkg.

A quick grep reveals:

andrea@mizar /oe/openembedded $ grep -R bluez-dtl1-workaround . Binary file ./.git/index matches ./classes/kernel.bbclass:DEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround" ./classes/kernel.bbclass:RDEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround" ./conf/machine/jornada7xx.conf:MACHINE_EXTRA_RDEPENDS = "kernel-modules bluez-dtl1-workaround" ./recipes/tasks/task-base.bb:    ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'bluez-dtl1-workaround', '',d)} \
./recipes/tasks/task-base.bb:# bluez-dtl1-workaround above is workaround for bitbake not handling DEPENDS on it in
andrea@mizar /oe/openembedded $

Quoted 7 lines

So, first doubt is: why make this mandatory for everyone having pcmcia? Second, why is it failing now?

Any idea?

Andrea

And the strange thing is if you build the package bluez-dtl1-workaround manually first and after that build the image it works.
Guess something is wrong with depends

Frans

#2 lore raw
In reply to Andrea Adami
Quoted 3 lines · Andrea Adami

Hello,

build from scratch of console image for c7x0/armv5te leads to:

With new kernel I had this some time ago.. I'm using this patch since then, but never send it here as I didn't look why this was needed before..

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]

From df57c608af9e0a98ff1a1b3dc8259d80f86f09b9 Mon Sep 17 00:00:00 2001
From: Martin Jansa <[email protected]>
Date: Tue, 10 Aug 2010 21:37:29 +0200
Subject: [PATCH 04/18] kernel: kill bluez-dtl1-workaround

---
 classes/kernel.bbclass     |    5 -----
 recipes/tasks/task-base.bb |    1 -
 2 files changed, 0 insertions(+), 6 deletions(-)
classes/kernel.bbclass +0 -5
index 7039d27..5874d75 100644
@@ -266,11 +266,6 @@ ALLOW_EMPTY_kernel = "1"
 ALLOW_EMPTY_kernel-base = "1"
 ALLOW_EMPTY_kernel-image = "1"
 
-# Userspace workarounds for kernel modules issues
-# This is shame, fix the kernel instead!
-DEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround"
-RDEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround"
-
 # renamed modules
 RPROVIDES_kernel-module-aes-generic = "kernel-module-aes"
 
recipes/tasks/task-base.bb +0 -1
index ecc5278..7fc7cee 100644
@@ -266,7 +266,6 @@ RRECOMMENDS_task-base-bluetooth = "\
     ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'kernel-module-bluecard-cs', '',d)} \
     ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'kernel-module-bluetoothuart-cs', '',d)} \
     ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'kernel-module-dtl1-cs', '',d)} \
-    ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'bluez-dtl1-workaround', '',d)} \
     "
 # bluez-dtl1-workaround above is workaround for bitbake not handling DEPENDS on it in
 # kernel.bbclass. It should be there as long as kernel-module-dtl1-cs is, but not longer.
Signature · 1 line
1.7.3.2
#3 lore raw
Quoted 9 lines · Martin Jansa
Quoted 3 lines · Andrea Adami

Hello,

build from scratch of console image for c7x0/armv5te leads to:

With new kernel I had this some time ago.. I'm using this patch since then, but never send it here as I didn't look why this was needed before..

patch looks ok to me. Please install into master and release branch

Thx
-Khem

Quoted 9 lines

--
Martin 'JaMa' Jansa     jabber: [email protected]

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#4 lore raw

PATCH v2 1/1 kernel.bbclass: put bluez-dtl1-workaround to DEPENDS directly

* DEPENDS_kernel-module-dtl1-cs aren't probably included in run queue
* RDEPENDS_kernel-module-dtl1-cs probably also doesn't put it to run queue, because kernel-module-* are created by
PACKAGES_DYNAMIC += "kernel-module-*"
so not even known before even building kernel, but does work ok in runtime
* bluez-dtl1-workaround is small and fast to build so won't hurt to build even when kernel doesn't have this bluez module enabled in defconfig

---
 classes/kernel.bbclass     |    3 +--
 recipes/tasks/task-base.bb |    4 ----
 2 files changed, 1 insertions(+), 6 deletions(-)
classes/kernel.bbclass +1 -2
index 7039d27..422bcd7 100644
@@ -1,7 +1,7 @@
 inherit linux-kernel-base module_strip
 
 PROVIDES += "virtual/kernel"
-DEPENDS += "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}depmod-${@get_kernelmajorversion('${PV}')} virtual/${TARGET_PREFIX}gcc${KERNEL_CCSUFFIX} update-modules"
+DEPENDS += "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}depmod-${@get_kernelmajorversion('${PV}')} virtual/${TARGET_PREFIX}gcc${KERNEL_CCSUFFIX} update-modules bluez-dtl1-workaround"
 
 # we include gcc above, we dont need virtual/libc
 INHIBIT_DEFAULT_DEPS = "1"
@@ -268,7 +268,6 @@ ALLOW_EMPTY_kernel-image = "1"
 
 # Userspace workarounds for kernel modules issues
 # This is shame, fix the kernel instead!
-DEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround"
 RDEPENDS_kernel-module-dtl1-cs = "bluez-dtl1-workaround"
 
 # renamed modules
recipes/tasks/task-base.bb +0 -4
index ecc5278..6e2d9f0 100644
@@ -266,11 +266,7 @@ RRECOMMENDS_task-base-bluetooth = "\
     ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'kernel-module-bluecard-cs', '',d)} \
     ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'kernel-module-bluetoothuart-cs', '',d)} \
     ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'kernel-module-dtl1-cs', '',d)} \
-    ${@base_contains('COMBINED_FEATURES', 'pcmcia', 'bluez-dtl1-workaround', '',d)} \
     "
-# bluez-dtl1-workaround above is workaround for bitbake not handling DEPENDS on it in
-# kernel.bbclass. It should be there as long as kernel-module-dtl1-cs is, but not longer.
-
 RDEPENDS_task-base-irda = "\
     irda-utils"
 
Signature · 1 line
1.7.3.2
#5 lore raw
In reply to Andrea Adami

Dnia czwartek, 25 listopada 2010 o 18:24:36 Andrea Adami napisał(a):

Quoted 1 line

So, first doubt is: why make this mandatory for everyone having pcmcia?

This is for those rare people who still use bluetooth cf cards based on crappy chipset made by nokia. Card does not survive suspend/resume, gives very slow transfers etc. I had such one and rarely used.

Regards,

Signature · 3 lines
JID:      [email protected]
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz
#6 lore raw
In reply to Andrea Adami
Quoted 1 line · Andrea Adami

So, first doubt is: why make this mandatory for everyone having pcmcia?

It shouldn't be. The dependency in kernel-module-dtl1-cs should be sufficient to pull it in for (only) those people who are installing the driver that needs those bits.

p.

#7 lore raw
Quoted 8 lines · Phil Blundell
Quoted 1 line · Andrea Adami

So, first doubt is: why make this mandatory for everyone having pcmcia?

It shouldn't be.  The dependency in kernel-module-dtl1-cs should be sufficient to pull it in for (only) those people who are installing the driver that needs those bits.

p.

The issue appeared again with today's metadata building glibc/uclibc/eglibc images.
Can we clear the sensible task / classes before release?

Andrea

#8 lore raw
In reply to Phil Blundell
Quoted 6 lines · Phil Blundell
Quoted 1 line · Andrea Adami

So, first doubt is: why make this mandatory for everyone having pcmcia?

It shouldn't be. The dependency in kernel-module-dtl1-cs should be sufficient to pull it in for (only) those people who are installing the driver that needs those bits.

but many machine configs have
MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
which pulls kernel-module-dtl1-cs to every image

Regards,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]