nfs: Discard ACL cache on mode update
Subsystems (2)
PATCH 1/1 nfs: Discard ACL cache on mode update
An update of mode bits can result in ACL value being changed. We need to mark the acl cache invalid when we update mode. Similarly we need to update file attribute when we change ACL value
Signed-off-by Aneesh Kumar K.V <[email protected]>
--- fs/nfs/nfs4proc.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
fs/nfs/nfs4proc.c +9 -0
@@ -3356,6 +3356,8 @@ ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;
@@ -3384,6 +3386,13 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 ); +/* +* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +spin_lock (&inode->i_lock); +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ; +spin_unlock (&inode->i_lock);nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;
Signature · 1 line
1.7.1
Trond Myklebust
AppliedQuoted 26 lines · Aneesh Kumar K.V
An update of mode bits can result in ACL value being changed. We need to mark the acl cache invalid when we update mode. Similarly we need to update file attribute when we change ACL value
Signed-off-by Aneesh Kumar K.V <[email protected]>--- fs/nfs/nfs4proc.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)fs/nfs/nfs4proc.c +2
-0@@ -3356,6 +3356,8 @@ ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret =nfs_revalidate_inode (server, inode);if (ret <0 )return ret; +if (NFS_I (inode)->cache_validity &NFS_INO_INVALID_ACL ) +nfs_zap_acl_cache (inode); ret =nfs4_read_cached_acl (inode, buf, buflen);if (ret != -ENOENT )return ret;@@ -3384,6 +3386,13 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflnfs_inode_return_delegation (inode);buf_to_pages (buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret =nfs4_call_sync (server, &msg, &arg, &res,1 );
fs/nfs/nfs4proc.c static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl · line 3398
Quoted 10 lines
fs/nfs/nfs4proc.c +7
-0+/* +* Acl update can result in inode attribute update. +* so mark the attribute cache invalid. +*/ +spin_lock (&inode->i_lock); +NFS_I (inode)->cache_validity |=NFS_INO_INVALID_ATTR ; +spin_unlock (&inode->i_lock);nfs_access_zap_cache (inode);nfs_zap_acl_cache (inode);return ret;
Thanks! Applied...
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com