ASoC: Make the DAI ops constant in the DAI structure
PATCH 1/2 ASoC: Make the DAI ops constant in the DAI structure
Neither drivers nor the core should be fiddling with the actual ops structure at runtime.
Signed-off-by Mark Brown <[email protected]>
--- include/sound/soc-dai.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/sound/soc-dai.h +1 -1
@@ -203,7 +203,7 @@ struct snd_soc_dai_driver {int (*resume)(struct snd_soc_dai *dai);/* ops */ -struct snd_soc_dai_ops *ops; +const struct snd_soc_dai_ops *ops;/* DAI capabilities */ struct snd_soc_pcm_stream capture;
Signature · 1 line
1.7.1
PATCH 2/2 ASoC: Move active copy of CODEC read and write into runtime structure
We shouldn't be assigning to the driver structure (which really ought to be const, further patch to follow) though there's unlikely to be any actual problem except in the unlikely case that two devices with the same driver but different bus types appear in the same system.
Signed-off-by Mark Brown <[email protected]>
--- include/sound/soc.h | 2 ++ sound/soc/soc-cache.c | 4 ++-- sound/soc/soc-core.c | 6 ++++-- 3 files changed, 8 insertions(+), 4 deletions(-)
include/sound/soc.h +2 -0
@@ -476,6 +476,8 @@ struct snd_soc_codec {void *control_data;/* codec control (i2c/3wire) data */ hw_write_t hw_write;unsigned int (*hw_read)(struct snd_soc_codec *,unsigned int ); +unsigned int (*read)(struct snd_soc_codec *,unsigned int ); +int (*write)(struct snd_soc_codec *,unsigned int ,unsigned int );void *reg_cache;const struct snd_soc_cache_ops *cache_ops;struct mutex cache_rw_mutex;
sound/soc/soc-cache.c +2 -2
@@ -728,8 +728,8 @@ int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,return -EINVAL ; } - codec->driver->write = io_types[i].write; - codec->driver->read = io_types[i].read; + codec->write = io_types[i].write; + codec->read = io_types[i].read;switch (control) {case SND_SOC_CUSTOM :
sound/soc/soc-core.c +4 -2
@@ -2077,7 +2077,7 @@ unsigned int snd_soc_read(struct snd_soc_codec *codec, unsigned int reg) {unsigned int ret; - ret = codec->driver->read (codec, reg); + ret = codec->read (codec, reg);dev_dbg (codec->dev,"read %x => %x\n" , reg, ret);trace_snd_soc_reg_read (codec, reg, ret);
@@ -2090,7 +2090,7 @@ unsigned int snd_soc_write(struct snd_soc_codec *codec, {dev_dbg (codec->dev,"write %x = %x\n" , reg, val);trace_snd_soc_reg_write (codec, reg, val); -return codec->driver->write (codec, reg, val); +return codec->write (codec, reg, val); }EXPORT_SYMBOL_GPL (snd_soc_write);
@@ -3448,6 +3448,8 @@ int snd_soc_register_codec(struct device *dev,INIT_LIST_HEAD (&codec->dapm.widgets);INIT_LIST_HEAD (&codec->dapm.paths); + codec->write = codec_drv->write; + codec->read = codec_drv->read; codec->dapm.bias_level =SND_SOC_BIAS_OFF ; codec->dapm.dev = dev; codec->dapm.codec = codec;
Signature · 1 line
1.7.1
Quoted 5 lines · Mark Brown
Neither drivers nor the core should be fiddling with the actual ops structure at runtime.
Signed-off-by Mark Brown <[email protected]>---
Both
Acked-by Liam Girdwood <[email protected]>
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk