Skip to contentSkip to conversation

cxgb4: fix MAC address hash filter

PATCH Applied Dimitris Michailidis 2 participants 2 messages Dec 3, 2010 – Dec 8, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb4: fix MAC address hash filter

Fix the calculation of the inexact hash-based MAC address filter. It's 64 bits but current code is missing a ULL. Results in filtering out some legitimate packets.

---
 drivers/net/cxgb4/t4_hw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/cxgb4/t4_hw.c +1 -1
index bb813d9..e97521c 100644
@@ -2408,7 +2408,7 @@ int t4_alloc_mac_filt(struct adapter *adap, unsigned int mbox,
 		if (index < NEXACT_MAC)
 			ret++;
 		else if (hash)
-			*hash |= (1 << hash_mac_addr(addr[i]));
+			*hash |= (1ULL << hash_mac_addr(addr[i]));
 	}
 	return ret;
 }
Signature · 1 line
1.5.4
maintainer Applied
#1 lore raw

From: Dimitris Michailidis <[email protected]>
Date: Fri, 3 Dec 2010 12:39:04 -0800

Quoted 5 lines

Fix the calculation of the inexact hash-based MAC address filter. It's 64 bits but current code is missing a ULL. Results in filtering out some legitimate packets.

Applied, thanks.