Skip to contentSkip to conversation

wxwidgets: added libxinerama to DEPENDS

PATCH Superseded Matt Thompson 3 participants 4 messages Dec 5, 2010

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wxwidgets: added libxinerama to DEPENDS

---
 recipes/wxwidgets/wxwidgets.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/wxwidgets/wxwidgets.inc +1 -1
index 2fb2bef..4c4f77f 100644
@@ -2,7 +2,7 @@ DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat
 HOMEPAGE = "http://www.wxwidgets.org"
 SECTION = "x11/libs"
 LICENSE = "wxWindows"
-DEPENDS = "gtk+ jpeg tiff libpng zlib expat"
+DEPENDS = "gtk+ jpeg tiff libpng zlib expat libxinerama"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/wxwindows/wxWidgets-${PV}.tar.bz2"
 
Signature · 1 line
1.7.1
#1 lore raw

Hi,

Quoted 10 lines · Matt Thompson
---
  recipes/wxwidgets/wxwidgets.inc |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
recipes/wxwidgets/wxwidgets.inc +0 -0
index 2fb2bef..4c4f77f 100644

recipes/wxwidgets/wxwidgets.inc DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat · line 6

Quoted 6 lines
recipes/wxwidgets/wxwidgets.inc +1 -1
@@ -2,7 +2,7 @@ DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat
  HOMEPAGE = "http://www.wxwidgets.org"
  SECTION = "x11/libs"
  LICENSE = "wxWindows"
-DEPENDS = "gtk+ jpeg tiff libpng zlib expat"
+DEPENDS = "gtk+ jpeg tiff libpng zlib expat libxinerama"
 

maybe this is obvious for wxwidgets'users but can you please add a comment detailing why this is needed ?

Thanks,
Eric

#2 lore raw
Quoted 22 lines · Eric Bénard

Hi,

Quoted 10 lines · Matt Thompson
---
  recipes/wxwidgets/wxwidgets.inc |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
recipes/wxwidgets/wxwidgets.inc +0 -0
index 2fb2bef..4c4f77f 100644

recipes/wxwidgets/wxwidgets.inc DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat · line 6

Quoted 6 lines
recipes/wxwidgets/wxwidgets.inc +1 -1
@@ -2,7 +2,7 @@ DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat
  HOMEPAGE = "http://www.wxwidgets.org"
  SECTION = "x11/libs"
  LICENSE = "wxWindows"
-DEPENDS = "gtk+ jpeg tiff libpng zlib expat"
+DEPENDS = "gtk+ jpeg tiff libpng zlib expat libxinerama"
 

maybe this is obvious for wxwidgets'users but can you please add a comment detailing why this is needed ?

Quoted 7 lines

Thanks,
Eric

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

I'm not entirely sure myself, but under the recipes fails to build wxwidgets without libxinerama on my box at least.

I'm using the overo-oe branch of openembedded, but it appears as though they haven't made any changes to this recipe, so I sent the patch here. I'm also using their configuration files if that matters.

This is my first time sending a patch via a mailing list, so should I amend my commit with an additional line in the commit message to the effect of "wxwidgets depends on libxinerama, which was missing from the recipe" and then perform git send-email again as detailed in the wiki? Is there some additional step to mark it as a revision to this patch?

#3 lore raw
Quoted 38 lines · Matthew Thompson
Quoted 22 lines · Eric Bénard

Hi,

Quoted 14 lines · Matt Thompson

---
  recipes/wxwidgets/wxwidgets.inc |    2 +-

  1 files changed, 1 insertions(+), 1 deletions(-)
recipes/wxwidgets/wxwidgets.inc +0 -0
index 2fb2bef..4c4f77f 100644
@@ -2,7 +2,7 @@ DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat

  HOMEPAGE = "http://www.wxwidgets.org"
  SECTION = "x11/libs"
  LICENSE = "wxWindows"

recipes/wxwidgets/wxwidgets.inc DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat · line 5

Quoted 2 lines
recipes/wxwidgets/wxwidgets.inc +1 -1
-DEPENDS = "gtk+ jpeg tiff libpng zlib expat"
+DEPENDS = "gtk+ jpeg tiff libpng zlib expat libxinerama"

maybe this is obvious for wxwidgets'users but can you please add a comment detailing why this is needed ?

Quoted 7 lines

Thanks,
Eric

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

I'm not entirely sure myself, but under the recipes fails to build wxwidgets without libxinerama on my box at least.

I'm using the overo-oe branch of openembedded, but it appears as though they haven't made any changes to this recipe, so I sent the patch here. I'm also using their configuration files if that matters.

Quoted 5 lines

This is my first time sending a patch via a mailing list, so should I amend my commit with an additional line in the commit message to the effect of "wxwidgets depends on libxinerama, which was missing from the recipe" and then perform git send-email again as detailed in the wiki? Is there some additional step to mark it as a revision to this patch?

If you include a snippet of the failure message then anyone else encountering the problem will find your patch in the archives (which is useful even after it gets applied).

-Graham