proc: fix single_open usage
PATCH 1/1 proc: fix single_open usage
fix some single_open function usage, use private_data as parameter
Signed-off-by Jovi Zhang <[email protected]>
fs/proc/base.c | 29 +++-------------------------- 1 files changed, 3 insertions(+), 26 deletions(-)
fs/proc/base.c +3 -26
@@ -751,14 +751,7 @@ static int proc_single_show(struct seq_file *m, void *v)static int proc_single_open (struct inode *inode,struct file *filp) { -int ret; - ret =single_open (filp, proc_single_show,NULL ); -if (!ret) { -struct seq_file *m = filp->private_data; - - m->private = inode; - } -return ret; +return single_open (filp, proc_single_show, inode); }static const struct file_operations proc_single_file_operations = {
@@ -1386,15 +1379,7 @@ sched_write(struct file *file, const char __user *buf,static int sched_open (struct inode *inode,struct file *filp) { -int ret; - - ret =single_open (filp, sched_show,NULL ); -if (!ret) { -struct seq_file *m = filp->private_data; - - m->private = inode; - } -return ret; +return single_open (filp, sched_show, inode); }static const struct file_operations proc_pid_sched_operations = {
@@ -1454,15 +1439,7 @@ static int comm_show(struct seq_file *m, void *v)static int comm_open (struct inode *inode,struct file *filp) { -int ret; - - ret =single_open (filp, comm_show,NULL ); -if (!ret) { -struct seq_file *m = filp->private_data; - - m->private = inode; - } -return ret; +return single_open (filp, comm_show, inode); }static const struct file_operations proc_pid_set_comm_operations = {
Quoted 3 lines · On Mon, 6 Dec 2010, [email protected] wrote:
fix some
single_openfunction usage, useprivate_dataas parameterSigned-off-by Jovi Zhang <[email protected]>
Acked-by David Rientjes <[email protected]>
Quoted 6 lines
fix some
single_openfunction usage, useprivate_dataas parameterSigned-off-by Jovi Zhang <[email protected]>fs/proc/base.c | 29 +++-------------------------- 1 files changed, 3 insertions(+), 26 deletions(-)
Looks good to me.
Reviewed-by KOSAKI Motohiro <[email protected]>
Quoted 55 lines
fs/proc/base.c +3
-26@@ -751,14 +751,7 @@ static int proc_single_show(struct seq_file *m, void *v)static int proc_single_open (struct inode *inode,struct file *filp) { -int ret; - ret =single_open (filp, proc_single_show,NULL ); -if (!ret) { -struct seq_file *m = filp->private_data; - - m->private = inode; - } -return ret; +return single_open (filp, proc_single_show, inode); }static const struct file_operations proc_single_file_operations = {@@ -1386,15 +1379,7 @@ sched_write(struct file *file, const char __user *buf,static int sched_open (struct inode *inode,struct file *filp) { -int ret; - - ret =single_open (filp, sched_show,NULL ); -if (!ret) { -struct seq_file *m = filp->private_data; - - m->private = inode; - } -return ret; +return single_open (filp, sched_show, inode); }static const struct file_operations proc_pid_sched_operations = {@@ -1454,15 +1439,7 @@ static int comm_show(struct seq_file *m, void *v)static int comm_open (struct inode *inode,struct file *filp) { -int ret; - - ret =single_open (filp, comm_show,NULL ); -if (!ret) { -struct seq_file *m = filp->private_data; - - m->private = inode; - } -return ret; +return single_open (filp, comm_show, inode); }static const struct file_operations proc_pid_set_comm_operations = {