Skip to contentSkip to conversation

Make N-PHY support experimental

PATCH New Rafał Miłecki 10 participants 49 messages Dec 7, 2010 – Dec 21, 2010 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

cover Make N-PHY support experimental

Finally, thanks for Larry and Francesco I got b43 working with BCM4328 chipset!

It's not perfectly stable yet, but scanning and associating to open network works! It has to be tested, improved, there are some PHY errors from time to time, but generally it works :)

Rafa?? Mi??ecki (4):
b43: N-PHY: silence warnings
b43: set TMS to work with current band width for N-PHY
b43: fix split of N-PHY devices into supported and not (based on PHY
rev)
b43: rename config option for N-PHY, drop BROKEN

 drivers/net/wireless/b43/Kconfig      |   13 +++++++------
 drivers/net/wireless/b43/Makefile     |    8 ++++----
 drivers/net/wireless/b43/main.c       |   12 +++++++++---
 drivers/net/wireless/b43/phy_common.c |    9 ++++++++-
 drivers/net/wireless/b43/phy_common.h |    2 ++
 drivers/net/wireless/b43/phy_n.c      |   16 ++++++----------
 6 files changed, 36 insertions(+), 24 deletions(-)
#1 lore raw

PATCH 1/4 b43: N-PHY: silence warnings

---
 drivers/net/wireless/b43/phy_n.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
drivers/net/wireless/b43/phy_n.c +6 -2
index f78f4e9..d41da7f 100644
@@ -258,7 +258,8 @@ static void b43_nphy_tx_power_fix(struct b43_wldev *dev)
 
 	for (i = 0; i < 2; i++) {
 		if (dev->phy.rev >= 3) {
-			/* TODO */
+			/* FIXME: support 5GHz */
+			txgain = b43_ntab_tx_gain_rev3plus_2ghz[txpi[i]];
 			radio_gain = (txgain >> 16) & 0x1FFFF;
 		} else {
 			txgain = b43_ntab_tx_gain_rev0_1_2[txpi[i]];
@@ -613,6 +614,8 @@ static void b43_nphy_rx_iq_coeffs(struct b43_wldev *dev, bool write,
 	}
 }
 
+#if 0
+/* Ready but not used anywhere */
 /* http://bcm-v4.sipsolutions.net/802.11/PHY/N/RxCalPhyCleanup */
 static void b43_nphy_rx_cal_phy_cleanup(struct b43_wldev *dev, u8 core)
 {
@@ -694,6 +697,7 @@ static void b43_nphy_rx_cal_phy_setup(struct b43_wldev *dev, u8 core)
 	b43_nphy_rf_control_intc_override(dev, 1, rxval, (core + 1));
 	b43_nphy_rf_control_intc_override(dev, 1, txval, (2 - core));
 }
+#endif
 
 /* http://bcm-v4.sipsolutions.net/802.11/PHY/N/CalcRxIqComp */
 static void b43_nphy_calc_rx_iq_comp(struct b43_wldev *dev, u8 mask)
@@ -3088,7 +3092,7 @@ static int b43_nphy_rev2_cal_rx_iq(struct b43_wldev *dev,
 	u8 rfctl[2];
 	u8 afectl_core;
 	u16 tmp[6];
-	u16 cur_hpf1, cur_hpf2, cur_lna;
+	u16 uninitialized_var(cur_hpf1), uninitialized_var(cur_hpf2), cur_lna;
 	u32 real, imag;
 	enum ieee80211_band band;
 
Signature · 1 line
1.6.3.3
#2 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

In reply to Rafał Miłecki
---
 drivers/net/wireless/b43/main.c       |    6 ++++++
 drivers/net/wireless/b43/phy_common.c |    7 +++++++
 drivers/net/wireless/b43/phy_common.h |    2 ++
 drivers/net/wireless/b43/phy_n.c      |    7 -------
 4 files changed, 15 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/main.c +6 -0
index fa48803..670fd7b 100644
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
 	flags |= B43_TMSLOW_PHYCLKEN;
 	flags |= B43_TMSLOW_PHYRESET;
+	if (dev->phy.type == B43_PHYTYPE_N) {
+		if (b43_channel_type_is_40mhz(dev->phy.channel_type))
+			flags |= B43_TMSLOW_PHYCLKSPEED_160MHZ;
+		else
+			flags |= B43_TMSLOW_PHYCLKSPEED_80MHZ;
+	}
 	ssb_device_enable(dev->dev, flags);
 	msleep(2);		/* Wait for the PLL to turn on. */
 
drivers/net/wireless/b43/phy_common.c +7 -0
index 0a91fc3..412f1b6 100644
@@ -429,6 +429,13 @@ void b43_phyop_switch_analog_generic(struct b43_wldev *dev, bool on)
 	b43_write16(dev, B43_MMIO_PHY0, on ? 0 : 0xF4);
 }
 
+
+bool b43_channel_type_is_40mhz(enum nl80211_channel_type channel_type)
+{
+	return (channel_type == NL80211_CHAN_HT40MINUS ||
+		channel_type == NL80211_CHAN_HT40PLUS);
+}
+
 /* http://bcm-v4.sipsolutions.net/802.11/PHY/Cordic */
 struct b43_c32 b43_cordic(int theta)
 {
drivers/net/wireless/b43/phy_common.h +2 -0
index 2ed60e5..2401bee 100644
@@ -436,6 +436,8 @@ int b43_phy_shm_tssi_read(struct b43_wldev *dev, u16 shm_offset);
  */
 void b43_phyop_switch_analog_generic(struct b43_wldev *dev, bool on);
 
+bool b43_channel_type_is_40mhz(enum nl80211_channel_type channel_type);
+
 struct b43_c32 b43_cordic(int theta);
 
 #endif /* LINUX_B43_PHY_COMMON_H_ */
drivers/net/wireless/b43/phy_n.c +0 -7
index d41da7f..3517341 100644
@@ -88,13 +88,6 @@ static void b43_nphy_rf_control_override(struct b43_wldev *dev, u16 field,
 static void b43_nphy_rf_control_intc_override(struct b43_wldev *dev, u8 field,
 						u16 value, u8 core);
 
-static inline bool b43_channel_type_is_40mhz(
-					enum nl80211_channel_type channel_type)
-{
-	return (channel_type == NL80211_CHAN_HT40MINUS ||
-		channel_type == NL80211_CHAN_HT40PLUS);
-}
-
 void b43_nphy_set_rxantenna(struct b43_wldev *dev, int antenna)
 {//TODO
 }
Signature · 1 line
1.6.3.3
#3 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

Quoted 13 lines · Rafa? Mi?ecki
---
 drivers/net/wireless/b43/main.c       |    6 ++++++
 drivers/net/wireless/b43/phy_common.c |    7 +++++++
 drivers/net/wireless/b43/phy_common.h |    2 ++
 drivers/net/wireless/b43/phy_n.c      |    7 -------
 4 files changed, 15 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 5 lines
drivers/net/wireless/b43/main.c +2 -0
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
 	flags |= B43_TMSLOW_PHYCLKEN;
 	flags |= B43_TMSLOW_PHYRESET;
+	if (dev->phy.type == B43_PHYTYPE_N) {
+		if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

Quoted 4 lines
drivers/net/wireless/b43/main.c +4 -0
+			flags |= B43_TMSLOW_PHYCLKSPEED_160MHZ;
+		else
+			flags |= B43_TMSLOW_PHYCLKSPEED_80MHZ;
+	}
Signature · 1 line
Greetings Michael.
#4 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 15 lines · Rafa? Mi?ecki
Quoted 14 lines

---

?drivers/net/wireless/b43/main.c ? ? ? | ? ?6 ++++++
?drivers/net/wireless/b43/phy_common.c | ? ?7 +++++++
?drivers/net/wireless/b43/phy_common.h | ? ?2 ++
?drivers/net/wireless/b43/phy_n.c ? ? ?| ? ?7 -------

?4 files changed, 15 insertions(+), 7 deletions(-)

drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
Quoted 6 lines

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 4 lines
drivers/net/wireless/b43/main.c +2 -0
 ? ? ? flags |= B43_TMSLOW_PHYCLKEN;
 ? ? ? flags |= B43_TMSLOW_PHYRESET;
+ ? ? if (dev->phy.type == B43_PHYTYPE_N) {
+ ? ? ? ? ? ? if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

Yeah, that core switching seems to be a little tricky. I didn't figure it out completely yet. We may need to fix that, or fix calls to this function.

Thanks for reviewing!

Signature · 1 line
Rafa?
#5 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

W dniu 9 grudnia 2010 15:12 u?ytkownik Rafa? Mi?ecki <[email protected]> napisa?:

Quoted 23 lines

W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 15 lines · Rafa? Mi?ecki
Quoted 14 lines

---

?drivers/net/wireless/b43/main.c ? ? ? | ? ?6 ++++++
?drivers/net/wireless/b43/phy_common.c | ? ?7 +++++++
?drivers/net/wireless/b43/phy_common.h | ? ?2 ++
?drivers/net/wireless/b43/phy_n.c ? ? ?| ? ?7 -------

?4 files changed, 15 insertions(+), 7 deletions(-)

drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
Quoted 6 lines

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 4 lines
drivers/net/wireless/b43/main.c +2 -0
 ? ? ? flags |= B43_TMSLOW_PHYCLKEN;
 ? ? ? flags |= B43_TMSLOW_PHYRESET;
+ ? ? if (dev->phy.type == B43_PHYTYPE_N) {
+ ? ? ? ? ? ? if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

Quoted 5 lines

Yeah, that core switching seems to be a little tricky. I didn't figure it out completely yet. We may need to fix that, or fix calls to this function.

Thanks for reviewing!

In other words: it will work for now, but we need to fix that in future if we want to get 40 MHz channels working.

Signature · 1 line
Rafa?
#6 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

Quoted 24 lines · Rafa? Mi?ecki

W dniu 9 grudnia 2010 15:12 u?ytkownik Rafa? Mi?ecki <[email protected]> napisa?:

Quoted 23 lines

W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 21 lines · Rafa? Mi?ecki
Quoted 13 lines
---
 drivers/net/wireless/b43/main.c       |    6 ++++++
 drivers/net/wireless/b43/phy_common.c |    7 +++++++
 drivers/net/wireless/b43/phy_common.h |    2 ++
 drivers/net/wireless/b43/phy_n.c      |    7 -------
 4 files changed, 15 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 5 lines
drivers/net/wireless/b43/main.c +2 -0
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
      flags |= B43_TMSLOW_PHYCLKEN;
      flags |= B43_TMSLOW_PHYRESET;
+     if (dev->phy.type == B43_PHYTYPE_N) {
+             if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

Quoted 8 lines
Quoted 5 lines

Yeah, that core switching seems to be a little tricky. I didn't figure it out completely yet. We may need to fix that, or fix calls to this function.

Thanks for reviewing!

In other words: it will work for now, but we need to fix that in future if we want to get 40 MHz channels working.

That's exactly what I was saying. ;)
To answer my original question: No, channel_type is not set, but the code will work for non-40mhz.

This seems a bit tricky to fix, though. Maybe we should reset the wireless core twice. Once initially and once again after the configuration was set. The first reset would just be to be able to access the PHY and wireless core at all to probe it.

Signature · 1 line
Greetings Michael.
#7 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

W dniu 9 grudnia 2010 15:19 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 34 lines · Rafa? Mi?ecki
Quoted 24 lines

W dniu 9 grudnia 2010 15:12 u?ytkownik Rafa? Mi?ecki <[email protected]> napisa?:

Quoted 23 lines

W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 21 lines · Rafa? Mi?ecki
Quoted 13 lines

---

?drivers/net/wireless/b43/main.c ? ? ? | ? ?6 ++++++
?drivers/net/wireless/b43/phy_common.c | ? ?7 +++++++
?drivers/net/wireless/b43/phy_common.h | ? ?2 ++
?drivers/net/wireless/b43/phy_n.c ? ? ?| ? ?7 -------

?4 files changed, 15 insertions(+), 7 deletions(-)

drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 5 lines
drivers/net/wireless/b43/main.c +2 -0
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
 ? ? ? flags |= B43_TMSLOW_PHYCLKEN;
 ? ? ? flags |= B43_TMSLOW_PHYRESET;
+ ? ? if (dev->phy.type == B43_PHYTYPE_N) {
+ ? ? ? ? ? ? if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

Quoted 8 lines
Quoted 5 lines

Yeah, that core switching seems to be a little tricky. I didn't figure it out completely yet. We may need to fix that, or fix calls to this function.

Thanks for reviewing!

In other words: it will work for now, but we need to fix that in future if we want to get 40 MHz channels working.

Quoted 8 lines

That's exactly what I was saying. ;)
To answer my original question: No, channel_type is not set, but the code will work for non-40mhz.

This seems a bit tricky to fix, though. Maybe we should reset the wireless core twice. Once initially and once again after the configuration was set. The first reset would just be to be able to access the PHY and wireless core at all to probe it.

Even more tricky is that we already reset code twice... At least in b43_wireless_core_attach. Will have to redesign that a little.

Signature · 1 line
Rafa?
#8 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

Quoted 39 lines · Rafa? Mi?ecki

W dniu 9 grudnia 2010 15:19 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 38 lines · Rafa? Mi?ecki
Quoted 24 lines

W dniu 9 grudnia 2010 15:12 u?ytkownik Rafa? Mi?ecki <[email protected]> napisa?:

Quoted 23 lines

W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 21 lines · Rafa? Mi?ecki
Quoted 13 lines
---
 drivers/net/wireless/b43/main.c       |    6 ++++++
 drivers/net/wireless/b43/phy_common.c |    7 +++++++
 drivers/net/wireless/b43/phy_common.h |    2 ++
 drivers/net/wireless/b43/phy_n.c      |    7 -------
 4 files changed, 15 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 5 lines
drivers/net/wireless/b43/main.c +2 -0
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
      flags |= B43_TMSLOW_PHYCLKEN;
      flags |= B43_TMSLOW_PHYRESET;
+     if (dev->phy.type == B43_PHYTYPE_N) {
+             if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

Quoted 8 lines
Quoted 5 lines

Yeah, that core switching seems to be a little tricky. I didn't figure it out completely yet. We may need to fix that, or fix calls to this function.

Thanks for reviewing!

In other words: it will work for now, but we need to fix that in future if we want to get 40 MHz channels working.

That's exactly what I was saying. ;)
To answer my original question: No, channel_type is not set, but the code will work for non-40mhz.

Quoted 7 lines
Quoted 4 lines

This seems a bit tricky to fix, though. Maybe we should reset the wireless core twice. Once initially and once again after the configuration was set. The first reset would just be to be able to access the PHY and wireless core at all to probe it.

Even more tricky is that we already reset code twice... At least in b43_wireless_core_attach. Will have to redesign that a little.

I don't think so.
We will have to live with at least two resets.
The first is to make the device accessible, so that we can fetch the device type and revision numbers (phy type, rev, radio type,....) After that is done, the device is shut down completely and reinitialized when the interface comes up with the correct parameters.
It is important that no device setup is done whatsoever at attach stage. Doing so would also break suspend/resume.

I do not think a redesign of the init code is required.

Signature · 1 line
Greetings Michael.
#9 lore raw

PATCH 2/4 b43: set TMS to work with current band width for N-PHY

In reply to Rafał Miłecki
Quoted 25 lines · Rafa? Mi?ecki

W dniu 9 grudnia 2010 15:19 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 24 lines · Rafa? Mi?ecki
Quoted 23 lines

W dniu 9 grudnia 2010 15:12 u?ytkownik Rafa? Mi?ecki <[email protected]> napisa?:

Quoted 22 lines

W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <[email protected]> napisa?:

Quoted 21 lines · Rafa? Mi?ecki
Quoted 13 lines
---
 drivers/net/wireless/b43/main.c       |    6 ++++++
 drivers/net/wireless/b43/phy_common.c |    7 +++++++
 drivers/net/wireless/b43/phy_common.h |    2 ++
 drivers/net/wireless/b43/phy_n.c      |    7 -------
 4 files changed, 15 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/main.c +0 -0
index fa48803..670fd7b 100644

drivers/net/wireless/b43/main.c void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags) · line 1154

Quoted 5 lines
drivers/net/wireless/b43/main.c +2 -0
@@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
 
      flags |= B43_TMSLOW_PHYCLKEN;
      flags |= B43_TMSLOW_PHYRESET;
+     if (dev->phy.type == B43_PHYTYPE_N) {
+             if (b43_channel_type_is_40mhz(dev->phy.channel_type))

Is channel_type already set at this time?

The more I think about this, the wronger it looks to me.
Why do we care about the channel type at reset time anyway? I guess the channel type is a parameter that can change any time on an operating card. So just unconditionally set B43_TMSLOW_PHYCLKSPEED_80MHZ at reset time and set the correct TMSLOW bits later when channel_type is actually changed. That seems to be the only sane thing to do. I guess we don't want to fully reset the device when channel_type changes, do we?

Signature · 1 line
Greetings Michael.
#10 lore raw

PATCH 3/4 b43: fix split of N-PHY devices into supported and not (based on PHY rev)

In reply to Rafał Miłecki
---
 drivers/net/wireless/b43/main.c  |    2 +-
 drivers/net/wireless/b43/phy_n.c |    1 -
 2 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/wireless/b43/main.c +1 -1
index 670fd7b..4d97aac 100644
@@ -4054,7 +4054,7 @@ static int b43_phy_versioning(struct b43_wldev *dev)
 		break;
 #ifdef CONFIG_B43_NPHY
 	case B43_PHYTYPE_N:
-		if (phy_rev > 4)
+		if (phy_rev > 2)
 			unsupported = 1;
 		break;
 #endif
drivers/net/wireless/b43/phy_n.c +0 -1
index 3517341..61875c8 100644
@@ -3515,7 +3515,6 @@ int b43_phy_initn(struct b43_wldev *dev)
 	if (phy->rev >= 3)
 		b43_nphy_spur_workaround(dev);
 
-	b43err(dev->wl, "IEEE 802.11n devices are not supported, yet.\n");
 	return 0;
 }
 
Signature · 1 line
1.6.3.3
#11 lore raw

PATCH 4/4 b43: rename config option for N-PHY, drop BROKEN

In reply to Rafał Miłecki
---
 drivers/net/wireless/b43/Kconfig      |   13 +++++++------
 drivers/net/wireless/b43/Makefile     |    8 ++++----
 drivers/net/wireless/b43/main.c       |    4 ++--
 drivers/net/wireless/b43/phy_common.c |    2 +-
 4 files changed, 14 insertions(+), 13 deletions(-)
drivers/net/wireless/b43/Kconfig +7 -6
index 0a00d42..47033f6 100644
@@ -86,15 +86,16 @@ config B43_PIO
 	select SSB_BLOCKIO
 	default y
 
-config B43_NPHY
-	bool "Pre IEEE 802.11n support (BROKEN)"
-	depends on B43 && EXPERIMENTAL && BROKEN
+config B43_PHY_N
+	bool "Support for 802.11n (N-PHY) devices (EXPERIMENTAL)"
+	depends on B43 && EXPERIMENTAL
 	---help---
-	  Support for the IEEE 802.11n draft.
+	  Support for the N-PHY.
 
-	  THIS IS BROKEN AND DOES NOT WORK YET.
+	  This enables support for devices with N-PHY revision up to 2.
 
-	  SAY N.
+	  Say N if you expect high stability and performance. Saying Y will not
+	  affect other devices support and may provide support for basic needs.
 
 config B43_PHY_LP
 	bool "Support for low-power (LP-PHY) devices (EXPERIMENTAL)"
drivers/net/wireless/b43/Makefile +4 -4
index 69d4af0..cef334a 100644
@@ -1,12 +1,12 @@
 b43-y				+= main.o
 b43-y				+= tables.o
-b43-$(CONFIG_B43_NPHY)		+= tables_nphy.o
-b43-$(CONFIG_B43_NPHY)		+= radio_2055.o
-b43-$(CONFIG_B43_NPHY)		+= radio_2056.o
+b43-$(CONFIG_B43_PHY_N)		+= tables_nphy.o
+b43-$(CONFIG_B43_PHY_N)		+= radio_2055.o
+b43-$(CONFIG_B43_PHY_N)		+= radio_2056.o
 b43-y				+= phy_common.o
 b43-y				+= phy_g.o
 b43-y				+= phy_a.o
-b43-$(CONFIG_B43_NPHY)		+= phy_n.o
+b43-$(CONFIG_B43_PHY_N)		+= phy_n.o
 b43-$(CONFIG_B43_PHY_LP)	+= phy_lp.o
 b43-$(CONFIG_B43_PHY_LP)	+= tables_lpphy.o
 b43-y				+= sysfs.o
drivers/net/wireless/b43/main.c +2 -2
index 4d97aac..9ae3f61 100644
@@ -4052,7 +4052,7 @@ static int b43_phy_versioning(struct b43_wldev *dev)
 		if (phy_rev > 9)
 			unsupported = 1;
 		break;
-#ifdef CONFIG_B43_NPHY
+#ifdef CONFIG_B43_PHY_N
 	case B43_PHYTYPE_N:
 		if (phy_rev > 2)
 			unsupported = 1;
@@ -5097,7 +5097,7 @@ static void b43_print_driverinfo(void)
 #ifdef CONFIG_B43_PCMCIA
 	feat_pcmcia = "M";
 #endif
-#ifdef CONFIG_B43_NPHY
+#ifdef CONFIG_B43_PHY_N
 	feat_nphy = "N";
 #endif
 #ifdef CONFIG_B43_LEDS
drivers/net/wireless/b43/phy_common.c +1 -1
index 412f1b6..b5c5ce9 100644
@@ -50,7 +50,7 @@ int b43_phy_allocate(struct b43_wldev *dev)
 		phy->ops = &b43_phyops_g;
 		break;
 	case B43_PHYTYPE_N:
-#ifdef CONFIG_B43_NPHY
+#ifdef CONFIG_B43_PHY_N
 		phy->ops = &b43_phyops_n;
 #endif
 		break;
Signature · 1 line
1.6.3.3
maintainer
#12 lore raw

cover Make N-PHY support experimental

In reply to Rafał Miłecki
Quoted 5 lines · Rafa? Mi?ecki

Finally, thanks for Larry and Francesco I got b43 working with BCM4328 chipset!

It's not perfectly stable yet, but scanning and associating to open network works! It has to be tested, improved, there are some PHY errors from time to time, but generally it works :)

Wow! Congrats to all involved!!

johannes

#13 lore raw

cover Make N-PHY support experimental

In reply to Rafał Miłecki

2010/12/7 Rafa? Mi?ecki <[email protected]>:

Quoted 1 line

Finally, thanks for Larry and Francesco I got b43 working with BCM4328 chipset!

Do you mean BCM4321 (14e4:4328)? BCM4328 is AFAIK handled by brcmfmac.

Quoted 25 lines

It's not perfectly stable yet, but scanning and associating to open network works! It has to be tested, improved, there are some PHY errors from time to time, but generally it works :)

Rafa? Mi?ecki (4):
?b43: N-PHY: silence warnings
?b43: set TMS to work with current band width for N-PHY ?b43: fix split of N-PHY devices into supported and not (based on PHY ? ?rev)
?b43: rename config option for N-PHY, drop BROKEN

?drivers/net/wireless/b43/Kconfig ? ? ?| ? 13 +++++++------
?drivers/net/wireless/b43/Makefile ? ? | ? ?8 ++++----
?drivers/net/wireless/b43/main.c ? ? ? | ? 12 +++++++++---
?drivers/net/wireless/b43/phy_common.c | ? ?9 ++++++++-
?drivers/net/wireless/b43/phy_common.h | ? ?2 ++
?drivers/net/wireless/b43/phy_n.c ? ? ?| ? 16 ++++++----------

?6 files changed, 36 insertions(+), 24 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
#14 lore raw

cover Make N-PHY support experimental

Quoted 9 lines · Gábor Stefanik

2010/12/7 Rafał Miłecki <[email protected]>:

Quoted 1 line

Finally, thanks for Larry and Francesco I got b43 working with BCM4328 chipset!

Do you mean BCM4321 (14e4:4328)? BCM4328 is AFAIK handled by brcmfmac.

Quoted 4 lines

It's not perfectly stable yet, but scanning and associating to open network works! It has to be tested, improved, there are some PHY errors from time to time, but generally it works :)

With my device:

04:00.0 Network controller [0280]: Broadcom Corporation BCM4321 802.11a/b/g/n [14e4:4328] (rev 03)
Subsystem: Hewlett-Packard Company BCM4321 802.11a/b/g/n Wireless LAN
Controller [103c:1366]
Kernel driver in use: b43-pci-bridge

Excerpt of log:

[ 1184.780924] b43-pci-bridge 0000:04:00.0: PCI INT A -> Link[LK4E] -> GSI 20
(level, low) -> IRQ 20
[ 1184.780945] b43-pci-bridge 0000:04:00.0: setting latency timer to 64
[ 1184.800166] ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x13, vendor 0x4243)
[ 1184.800176] ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0C, vendor 0x4243)
[ 1184.800184] ssb: Core 2 found: PCI-E (cc 0x820, rev 0x04, vendor 0x4243)
[ 1184.800192] ssb: Core 3 found: PCI (cc 0x804, rev 0x0D, vendor 0x4243)
[ 1184.800200] ssb: Core 4 found: USB 1.1 Host (cc 0x817, rev 0x04, vendor 0x4243)
[ 1184.820062] ssb: Switching to ChipCommon core, index 0
[ 1184.820202] ssb: chipcommon status is 0x0
[ 1184.820211] ssb: SPROM offset is 0x1000
[ 1184.828653] ssb: SPROM revision 5 detected.
[ 1184.848037] ssb: Switching to PCI-E core, index 2
[ 1184.848659] ssb: Sonics Silicon Backplane found on PCI device 0000:04:00.0
[ 1184.897825] b43-phy0: Broadcom 4321 WLAN found (core revision 12)
[ 1184.916062] ssb: Switching to IEEE 802.11 core, index 1
[ 1184.940038] b43-phy0 debug: Found PHY: Analog 5, Type 4, Revision 2
[ 1184.940064] b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2055, Revision 4
[ 1184.975224] Registered led device: b43-phy0::tx
[ 1184.978455] Registered led device: b43-phy0::rx
[ 1184.980387] Registered led device: b43-phy0::radio
[ 1185.256050] b43-phy0: Loading firmware version 508.1107 (2009-06-26 19:16:02)
[ 1185.256059] ssb: Switching to ChipCommon core, index 0
[ 1185.256123] ssb: Switching to IEEE 802.11 core, index 1
[ 1185.332045] b43-phy0 debug: Chip initialized
[ 1185.333522] b43-phy0 debug: 64-bit DMA initialized
[ 1185.333570] b43-phy0 debug: QoS enabled
[ 1185.353497] b43-phy0 debug: Wireless interface started
[ 1185.353512] b43-phy0 debug: Adding Interface type 2
[ 1188.041790] b43-phy0 debug: Using hardware based encryption for keyidx: 0,
mac: c0:3f:0e:be:2b:45
[ 1191.134922] b43-phy0 debug: Disabling hardware based encryption for keyidx:
0, mac: c0:3f:0e:be:2b:45
[ 1192.823490] b43-phy0 debug: Using hardware based encryption for keyidx: 0,
mac: ff:ff:ff:ff:ff:ff
[ 1192.824306] b43-phy0 debug: Using hardware based encryption for keyidx: 1,
mac: ff:ff:ff:ff:ff:ff
[ 1192.824630] b43-phy0 debug: Using hardware based encryption for keyidx: 2,
mac: ff:ff:ff:ff:ff:ff
[ 1192.824989] b43-phy0 debug: Using hardware based encryption for keyidx: 3,
mac: ff:ff:ff:ff:ff:ff
[ 1194.896063] b43-phy0 ERROR: PHY transmission error

It connects and authenticates with WEP, but not with WPA2. It appears to be limited to CCK rates. Setting a rate above 11Mb/s results in complete failure.

Transmit rate is 4.6 Mb/s at 11M. All in all, not bad for first life.

Larry

#15 lore raw

cover Make N-PHY support experimental

In reply to Gábor Stefanik

I have a bit more info regarding the problem with WPA2 encryption on an N PHY. As shown in the NetworkManager log attached, Authentication is successful, but DHCP fails. Either the transmit data is improperly encrypted, or the decryption fails. I will use wireshark to sort that out. Note: Using software encryption makes no difference.

Larry

Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): device state change: 8 -> 3 (reason 0)
Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): deactivating device (reason: 0).
Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): canceled DHCP transaction, dhcp client pid 5982
Dec  7 21:13:37 larrylap NetworkManager: <WARN>  check_one_route(): (wlan5) error -34 returned from rtnl_route_del(): Sucess#012
Dec  7 21:13:37 larrylap NetworkManager: <debug> [1291778017.386964] run_netconfig(): Spawning '/sbin/netconfig modify --service NetworkManager'
Dec  7 21:13:37 larrylap NetworkManager: <debug> [1291778017.403700] write_to_netconfig(): Writing to netconfig: INTERFACE='wlan5'#012
Dec  7 21:13:37 larrylap NetworkManager: <info>  Clearing nscd hosts cache.
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) starting connection 'lwfdjf_rad'
Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): device state change: 3 -> 4 (reason 0)
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) scheduled...
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) started...
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) scheduled...
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) complete.
Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  completed -> disconnected
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) starting...
Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): device state change: 4 -> 5 (reason 0)
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5/wireless): connection 'lwfdjf_rad' has security, and secrets exist.  No new secrets needed
.
Dec  7 21:13:37 larrylap NetworkManager: <info>  Config: added 'ssid' value 'lwfdjf_rad'
Dec  7 21:13:37 larrylap NetworkManager: <info>  Config: added 'scan_ssid' value '1'
Dec  7 21:13:37 larrylap NetworkManager: <info>  Config: added 'key_mgmt' value 'WPA-PSK'
Dec  7 21:13:37 larrylap NetworkManager: <info>  Config: added 'psk' value '<omitted>'
Dec  7 21:13:37 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) complete.
Dec  7 21:13:37 larrylap NetworkManager: <info>  Config: set interface ap_scan to 1
Dec  7 21:13:37 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  disconnected -> scanning
Dec  7 21:13:37 larrylap nm-dispatcher.action: Script '/etc/NetworkManager/dispatcher.d/autofs' exited with error status 1.
Dec  7 21:13:38 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  scanning -> associating
Dec  7 21:13:38 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  associating -> associated
Dec  7 21:13:38 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  associated -> 4-way handshake
Dec  7 21:13:38 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  4-way handshake -> group handshake
Dec  7 21:13:38 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  group handshake -> completed
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5/wireless) Stage 2 of 5 (Device Configure) successful.  Connected to wireless network 'lwfdjf_rad'.
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) scheduled.
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) started...
Dec  7 21:13:38 larrylap NetworkManager: <info>  (wlan5): device state change: 5 -> 7 (reason 0)
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Beginning DHCP transaction (timeout in 45 seconds)
Dec  7 21:13:38 larrylap NetworkManager: <info>  dhclient started with pid 7150
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) scheduled...
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) complete.
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) started...
Dec  7 21:13:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) complete.
Dec  7 21:13:38 larrylap NetworkManager: <info>  DHCP: device wlan5 state changed normal exit -> preinit
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): device state change: 7 -> 3 (reason 0)
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): deactivating device (reason: 0).
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): canceled DHCP transaction, dhcp client pid 7150
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) starting connection 'Larry_wep'
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): device state change: 3 -> 4 (reason 0)
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) scheduled...
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) started...
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) scheduled...
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) complete.
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) starting...
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): device state change: 4 -> 5 (reason 0)
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5/wireless): access point 'Larry_wep' has security, but secrets are required.
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): device state change: 5 -> 6 (reason 0)
Dec  7 21:14:19 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) complete.
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  completed -> disconnected
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): device state change: 6 -> 3 (reason 38)
Dec  7 21:14:19 larrylap NetworkManager: <info>  (wlan5): deactivating device (reason: 38).
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) starting connection 'lwfdjf_rad'
Dec  7 21:14:23 larrylap NetworkManager: <info>  (wlan5): device state change: 3 -> 4 (reason 0)
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) scheduled...
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) started...
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) scheduled...
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) complete.
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) starting...
Dec  7 21:14:23 larrylap NetworkManager: <info>  (wlan5): device state change: 4 -> 5 (reason 0)
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5/wireless): access point 'lwfdjf_rad' has security, but secrets are required.
Dec  7 21:14:23 larrylap NetworkManager: <info>  (wlan5): device state change: 5 -> 6 (reason 0)
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) complete.
Dec  7 21:14:23 larrylap NetworkManager: <WARN>  secrets_update_setting(): Failed to update connection secrets: 1 802-1x
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) scheduled...
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) started...
Dec  7 21:14:23 larrylap NetworkManager: <info>  (wlan5): device state change: 6 -> 4 (reason 0)
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) scheduled...
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) complete.
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) starting...
Dec  7 21:14:23 larrylap NetworkManager: <info>  (wlan5): device state change: 4 -> 5 (reason 0)
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5/wireless): connection 'lwfdjf_rad' has security, and secrets exist.  No new secrets needed.
Dec  7 21:14:23 larrylap NetworkManager: <info>  Config: added 'ssid' value 'lwfdjf_rad'
Dec  7 21:14:23 larrylap NetworkManager: <info>  Config: added 'scan_ssid' value '1'
Dec  7 21:14:23 larrylap NetworkManager: <info>  Config: added 'key_mgmt' value 'WPA-PSK'
Dec  7 21:14:23 larrylap NetworkManager: <info>  Config: added 'psk' value '<omitted>'
Dec  7 21:14:23 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) complete.
Dec  7 21:14:23 larrylap NetworkManager: <info>  Config: set interface ap_scan to 1
Dec  7 21:14:23 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  disconnected -> scanning
Dec  7 21:14:24 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  scanning -> associating
Dec  7 21:14:24 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  associating -> associated
Dec  7 21:14:24 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  associated -> 4-way handshake
Dec  7 21:14:24 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  4-way handshake -> group handshake
Dec  7 21:14:24 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  group handshake -> completed
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5/wireless) Stage 2 of 5 (Device Configure) successful.  Connected to wireless network 'lwfdjf_rad'.
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) scheduled.
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) started...
Dec  7 21:14:24 larrylap NetworkManager: <info>  (wlan5): device state change: 5 -> 7 (reason 0)
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Beginning DHCP transaction (timeout in 45 seconds)
Dec  7 21:14:24 larrylap NetworkManager: <info>  dhclient started with pid 7177
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) scheduled...
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) complete.
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) started...
Dec  7 21:14:24 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) complete.
Dec  7 21:14:24 larrylap NetworkManager: <info>  DHCP: device wlan5 state changed normal exit -> preinit
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): device state change: 7 -> 3 (reason 0)
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): deactivating device (reason: 0).
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): canceled DHCP transaction, dhcp client pid 7177
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) starting connection 'Larry_wep'
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): device state change: 3 -> 4 (reason 0)
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) scheduled...
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) started...
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) scheduled...
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) complete.
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  completed -> disconnected
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) starting...
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): device state change: 4 -> 5 (reason 0)
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5/wireless): access point 'Larry_wep' has security, but secrets are required.
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): device state change: 5 -> 6 (reason 0)
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) complete.
Dec  7 21:14:32 larrylap NetworkManager: <WARN>  secrets_update_setting(): Failed to update connection secrets: 1 802-1x
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) scheduled...
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) started...
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): device state change: 6 -> 4 (reason 0)
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) scheduled...
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 1 of 5 (Device Prepare) complete.
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) starting...
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): device state change: 4 -> 5 (reason 0)
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5/wireless): connection 'Larry_wep' has security, and secrets exist.  No new secrets needed.
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'ssid' value 'Larry_wep'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'scan_ssid' value '1'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'key_mgmt' value 'NONE'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'wep_key0' value '<omitted>'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'wep_key1' value '<omitted>'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'wep_key2' value '<omitted>'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'wep_key3' value '<omitted>'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: added 'wep_tx_keyidx' value '0'
Dec  7 21:14:32 larrylap NetworkManager: <info>  Activation (wlan5) Stage 2 of 5 (Device Configure) complete.
Dec  7 21:14:32 larrylap NetworkManager: <info>  Config: set interface ap_scan to 1
Dec  7 21:14:32 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  disconnected -> scanning
Dec  7 21:14:34 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  scanning -> associating
Dec  7 21:14:34 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  associating -> associated
Dec  7 21:14:34 larrylap NetworkManager: <info>  (wlan5): supplicant connection state:  associated -> completed
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5/wireless) Stage 2 of 5 (Device Configure) successful.  Connected to wireless network 'Larry_wep'.
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) scheduled.
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) started...
Dec  7 21:14:34 larrylap NetworkManager: <info>  (wlan5): device state change: 5 -> 7 (reason 0)
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Beginning DHCP transaction (timeout in 45 seconds)
Dec  7 21:14:34 larrylap NetworkManager: <info>  dhclient started with pid 7187
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) scheduled...
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Stage 3 of 5 (IP Configure Start) complete.
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) started...
Dec  7 21:14:34 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP6 Configure Get) complete.
Dec  7 21:14:34 larrylap NetworkManager: <info>  DHCP: device wlan5 state changed normal exit -> preinit
Dec  7 21:14:38 larrylap NetworkManager: <info>  DHCP: device wlan5 state changed preinit -> reboot
Dec  7 21:14:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP4 Configure Get) scheduled...
Dec  7 21:14:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP4 Configure Get) started...
Dec  7 21:14:38 larrylap NetworkManager: <info>    address 192.168.3.102
Dec  7 21:14:38 larrylap NetworkManager: <info>    prefix 24 (255.255.255.0)
Dec  7 21:14:38 larrylap NetworkManager: <info>    gateway 192.168.3.1
Dec  7 21:14:38 larrylap NetworkManager: <info>    nameserver '192.168.2.1'
Dec  7 21:14:38 larrylap NetworkManager: <info>    domain name 'lan'
Dec  7 21:14:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 5 of 5 (IP Configure Commit) scheduled...
Dec  7 21:14:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 4 of 5 (IP4 Configure Get) complete.
Dec  7 21:14:38 larrylap NetworkManager: <info>  Activation (wlan5) Stage 5 of 5 (IP Configure Commit) started...
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.043901] run_netconfig(): Spawning '/sbin/netconfig modify --service NetworkManager'
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.056161] write_to_netconfig(): Writing to netconfig: INTERFACE='wlan5'#012
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.056433] write_to_netconfig(): Writing to netconfig: DNSSEARCH='lan lan'#012
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.056500] write_to_netconfig(): Writing to netconfig: DNSSERVERS='192.168.2.1'#012
Dec  7 21:14:39 larrylap NetworkManager: <info>  Clearing nscd hosts cache.
Dec  7 21:14:39 larrylap NetworkManager: <info>  (wlan5): device state change: 7 -> 8 (reason 0)
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.088730] run_netconfig(): Spawning '/sbin/netconfig modify --service NetworkManager'
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.119134] write_to_netconfig(): Writing to netconfig: INTERFACE='wlan5'#012
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.119375] write_to_netconfig(): Writing to netconfig: DNSSEARCH='lan lan'#012
Dec  7 21:14:39 larrylap NetworkManager: <debug> [1291778079.119435] write_to_netconfig(): Writing to netconfig: DNSSERVERS='192.168.2.1'#012
Dec  7 21:14:39 larrylap NetworkManager: <info>  Clearing nscd hosts cache.
Dec  7 21:14:39 larrylap NetworkManager: <info>  Policy set 'Larry_wep' (wlan5) as default for routing and DNS.
Dec  7 21:14:39 larrylap NetworkManager: <info>  Activation (wlan5) successful, device activated.
Dec  7 21:14:39 larrylap NetworkManager: <info>  Activation (wlan5) Stage 5 of 5 (IP Configure Commit) complete.
Dec  7 21:14:39 larrylap nm-dispatcher.action: Script '/etc/NetworkManager/dispatcher.d/autofs' exited with error status 1.
#16 lore raw

cover Make N-PHY support experimental

2010/12/8 Larry Finger <[email protected]>:

Quoted 5 lines

I have a bit more info regarding the problem with WPA2 encryption on an N PHY. As shown in the NetworkManager log attached, Authentication is successful, but DHCP fails. Either the transmit data is improperly encrypted, or the decryption fails. I will use wireshark to sort that out. Note: Using software encryption makes no difference.

Hm, I expected software encryption to work, that's weird. I don't really have nice access to my development machine, so some tests would be great.

Signature · 1 line
Rafa?
#17 lore raw

cover Make N-PHY support experimental

Quoted 10 lines · Rafał Miłecki

2010/12/8 Larry Finger <[email protected]>:

Quoted 5 lines

I have a bit more info regarding the problem with WPA2 encryption on an N PHY. As shown in the NetworkManager log attached, Authentication is successful, but DHCP fails. Either the transmit data is improperly encrypted, or the decryption fails. I will use wireshark to sort that out. Note: Using software encryption makes no difference.

Hm, I expected software encryption to work, that's weird. I don't really have nice access to my development machine, so some tests would be great.

Actually, when I got wireshark all setup on my netbook and tried again, WPA2 worked with hardware encryption. I'm not sure what the problem was the first time.

I still have no idea why OFDM rates are failing. Any thoughts?

My device lists the following:

Network controller [0280]: Broadcom Corporation BCM4321 802.11a/b/g/n [14e4:4328] (rev 03)
ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x13, vendor 0x4243)
ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0C, vendor 0x4243)
ssb: Core 2 found: PCI-E (cc 0x820, rev 0x04, vendor 0x4243)
ssb: Core 3 found: PCI (cc 0x804, rev 0x0D, vendor 0x4243)
ssb: Core 4 found: USB 1.1 Host (cc 0x817, rev 0x04, vendor 0x4243)

It has a rev 2 PHY, and a rev 4 0x2055 radio.

I am willing to buy a higher PHY rev device for testing. Any idea what is in a 4324A-BRCM1036? See
http://cgi.ebay.com/Broadcom-Mini-PCI-e-802-11-a-b-g-n-Wireless-Card-/190477425068?pt=LH_DefaultDomain_0&hash=item2c5956d9ac.

Larry

maintainer
#18 lore raw

cover Make N-PHY support experimental

Quoted 4 lines · Larry Finger

It has a rev 2 PHY, and a rev 4 0x2055 radio.

I am willing to buy a higher PHY rev device for testing. Any idea what is in a 4324A-BRCM1036?

It says BCM94322 on the image, and if that's any indication, I have a 4322 with pci ID 14e4:432b (but it's an Apple build):

b43-phy0: Broadcom 4322 WLAN found (core revision 16) b43-phy0 debug: Found PHY: Analog 8, Type 4, Revision 4 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2056, Revision 3

johannes

#19 lore raw

cover Make N-PHY support experimental

2010/12/9 Johannes Berg <[email protected]>:

Quoted 7 lines · Larry Finger
Quoted 5 lines

It has a rev 2 PHY, and a rev 4 0x2055 radio.

I am willing to buy a higher PHY rev device for testing. Any idea what is in a 4324A-BRCM1036?

Quoted 6 lines

It says BCM94322 on the image, and if that's any indication, I have a 4322 with pci ID 14e4:432b (but it's an Apple build):

b43-phy0: Broadcom 4322 WLAN found (core revision 16) b43-phy0 debug: Found PHY: Analog 8, Type 4, Revision 4 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2056, Revision 3

I actually asked for some hardware donations on my blog and in news on polish portal, but didn't receive any serious offer.

Johannes: is there any chance you could put this card in some machine I could get ssh access to? Or is that some daily-user-card or you don't really have free machine? Of course I don't need that now, first we have to make PHY 2 support more complete. But maybe after Christmas/new year I could focus on that.

Signature · 1 line
Rafa?
maintainer
#20 lore raw

cover Make N-PHY support experimental

Quoted 2 lines · Rafa? Mi?ecki

I actually asked for some hardware donations on my blog and in news on polish portal, but didn't receive any serious offer.

There probably are still money donations left to buy some ... ?

Quoted 5 lines

Johannes: is there any chance you could put this card in some machine I could get ssh access to? Or is that some daily-user-card or you don't really have free machine? Of course I don't need that now, first we have to make PHY 2 support more complete. But maybe after Christmas/new year I could focus on that.

I can't, unless I magically get a new laptop -- this card is built into my macbook that I use all the time. I'd have a mostly-free machine, and I don't use the card, but it's not a replacable part.

johannes

#21 lore raw

cover Make N-PHY support experimental

2010/12/9 Johannes Berg <[email protected]>:

Quoted 5 lines · Rafa? Mi?ecki
Quoted 2 lines

I actually asked for some hardware donations on my blog and in news on polish portal, but didn't receive any serious offer.

There probably are still money donations left to buy some ... ?

The problem I was afraid of was recognizing PHY revision without buying a card, just from looking at photos. It seems however, that will be the only solution.

Quoted 9 lines
Quoted 5 lines

Johannes: is there any chance you could put this card in some machine I could get ssh access to? Or is that some daily-user-card or you don't really have free machine? Of course I don't need that now, first we have to make PHY 2 support more complete. But maybe after Christmas/new year I could focus on that.

I can't, unless I magically get a new laptop -- this card is built into my macbook that I use all the time. I'd have a mostly-free machine, and I don't use the card, but it's not a replacable part.

OK, I'll just think about buying some card :)

Signature · 1 line
Rafa?
#22 lore raw

cover Make N-PHY support experimental

Quoted 18 lines · Rafał Miłecki

2010/12/9 Johannes Berg <[email protected]>:

Quoted 5 lines · Rafał Miłecki
Quoted 2 lines

I actually asked for some hardware donations on my blog and in news on polish portal, but didn't receive any serious offer.

There probably are still money donations left to buy some ... ?

The problem I was afraid of was recognizing PHY revision without buying a card, just from looking at photos. It seems however, that will be the only solution.

Quoted 6 lines
Quoted 5 lines

Johannes: is there any chance you could put this card in some machine I could get ssh access to? Or is that some daily-user-card or you don't really have free machine? Of course I don't need that now, first we have to make PHY 2 support more complete. But maybe after Christmas/new year I could focus on that.

Quoted 5 lines
Quoted 3 lines

I can't, unless I magically get a new laptop -- this card is built into my macbook that I use all the time. I'd have a mostly-free machine, and I don't use the card, but it's not a replacable part.

OK, I'll just think about buying some card :)

I sent a question to the seller of the card I mentioned earlier asking them to tell me the PCI IDs and explaining why I needed to know. If they answer, we will at least know if it is a 14e4:432b. If so, then it certainly will have a PHY rev

Quoted 1 line

2. At that price, I'm willing to buy it myself, but there should be money

available to get things for Rafał. Who has those funds? I think the last time I got something though the donations, it was Stefano, but that was a long time ago.

Rafał: If I get a rev > 2 card, you can certainly ssh into my computer for testing, or I can do the runs here and send you the dumps.

Larry

Larry

#23 lore raw

cover Make N-PHY support experimental

Quoted 11 lines · Larry Finger

I sent a question to the seller of the card I mentioned earlier asking them to tell me the PCI IDs and explaining why I needed to know. If they answer, we will at least know if it is a 14e4:432b. If so, then it certainly will have a PHY rev

Quoted 1 line

2. At that price, I'm willing to buy it myself, but there should be money

available to get things for Rafał. Who has those funds? I think the last time I got something though the donations, it was Stefano, but that was a long time ago.

Rafał: If I get a rev > 2 card, you can certainly ssh into my computer for testing, or I can do the runs here and send you the dumps.

Larry

I have a 14e4:432b card and am willing to help any way I can.

Signature · 1 line
0x00
#24 lore raw

cover Make N-PHY support experimental

Quoted 5 lines · Jon Saul
Quoted 4 lines · Larry Finger

I sent a question to the seller of the card I mentioned earlier asking them to tell me the PCI IDs and explaining why I needed to know. If they answer, we will at least know if it is a 14e4:432b. If so, then it certainly will have a PHY rev

Quoted 1 line

2. At that price, I'm willing to buy it myself, but there should be money

Quoted 8 lines
Quoted 7 lines

available to get things for Rafał. Who has those funds? I think the last time I got something though the donations, it was Stefano, but that was a long time ago.

Rafał: If I get a rev > 2 card, you can certainly ssh into my computer for testing, or I can do the runs here and send you the dumps.

Larry

I have a 14e4:432b card and am willing to help any way I can.

Thanks for the offer. I bought one that should have those ID values on Ebay today. If it is not a 432b, or some other N PHY with rev > 2, I have the right to return it. The seller did not know the IDs. In that case, I will contact you to see what we can arrange.

Larry

#26 lore raw

b43 N PHY status report

In reply to Gábor Stefanik

Rafał,

The N PHY driver is remarkably stable. So far, my link has been up for nearly 16 hours under normal conditions - I have not yet tried any stress tests. Other than the PHY errors that you noted, my link has only reported 2 other unusual events. I have had 3 "Deauthentication for reason 3" from which it recovered in one try. Also logged are 9 instances of "RX: Packet size underrun (2)/Packet dropped" events. Again, these caused no problems.

Larry

#27 lore raw

b43 N PHY status report

Quoted 1 line · Larry Finger

The N PHY driver is remarkably stable.

Are there some N PHY MiniPCI cards? (Not Express.)

//Peter

#28 lore raw

b43 N PHY status report

Quoted 4 lines · Peter Stuge
Quoted 1 line · Larry Finger

The N PHY driver is remarkably stable.

Are there some N PHY MiniPCI cards? (Not Express.)

On Ebay, Mini PCIe is the only format shown for 802.11n devices. There is one listing in which a picture of the card is not shown, but I am not aware of any other format.

Larry

#29 lore raw

b43 N PHY status report

Quoted 5 lines · Larry Finger
Quoted 1 line

Are there some N PHY MiniPCI cards? (Not Express.)

On Ebay, Mini PCIe is the only format shown for 802.11n devices. There is one listing in which a picture of the card is not shown, but I am not aware of any other format.

There are reference designs:

http://www.broadcom.com/products/Wireless-LAN/802.11-Wireless-LAN-Solutions/BCM94321MP
http://www.broadcom.com/products/Wireless-LAN/802.11-Wireless-LAN-Solutions/BCM94322MP

..so hopefully also some cards in a corner of the world..

Auction from November:

http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=270634152387
http://cgi.ebay.co.uk/ws/eBayISAPI.dll?VISuperSize&item=270634152387

The silkscreen says 2008 so maybe some more can still be found, although Google doesn't find any.

//Peter

#31 lore raw

b43 N PHY status report

2010/12/10 Peter Stuge <[email protected]>:

Quoted 5 lines
Quoted 3 lines · Peter Stuge

Auction from November:

http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=270634152387

Quoted 8 lines

Make that
http://cgi.ebay.co.uk/ws/eBayISAPI.dll?ViewItem&item=270634152387

Quoted 1 line

http://cgi.ebay.co.uk/ws/eBayISAPI.dll?VISuperSize&item=270634152387

and
http://i.ebayimg.com/16/!B2kGntQBGk~$(KGrHqR,!iIE)qvw8QW3BMjCQu1iiw~~_3.JPG

I've got a mail from user who unmounted his wireless card from Asus WL-500W. This card is MiniPCI (not express!) and from all the specs I can see this router is 802.11n. Also, this card has 3 antennas connectors. One weird thing is that this card is labeled as BCM4312...

I asked for renting this card, it would be nice to test b43 to support such a card as well.

Signature · 1 line
Rafa?
#32 lore raw

b43 N PHY status report

Quoted 8 lines · Rafa? Mi?ecki

I've got a mail from user who unmounted his wireless card from Asus WL-500W. This card is MiniPCI (not express!) and from all the specs I can see this router is 802.11n. Also, this card has 3 antennas connectors. One weird thing is that this card is labeled as BCM4312...

I asked for renting this card, it would be nice to test b43 to support such a card as well.

Ebay has the MiniPCI card from an Asus WL-500W for a "buy now" price of $34.99 US. The photo clearly shows the Broadcom logo on a chip.

Who is in charge of the funds that were donated to the b43 project? This item should be purchased for Rafal.

Larry

#33 lore raw

b43 N PHY status report

W dniu 13 grudnia 2010 18:41 u?ytkownik Larry Finger <[email protected]> napisa?:

Quoted 7 lines · Rafa? Mi?ecki
Quoted 6 lines

I've got a mail from user who unmounted his wireless card from Asus WL-500W. This card is MiniPCI (not express!) and from all the specs I can see this router is 802.11n. Also, this card has 3 antennas connectors. One weird thing is that this card is labeled as BCM4312...

Quoted 8 lines
Quoted 2 lines

I asked for renting this card, it would be nice to test b43 to support such a card as well.

Ebay has the MiniPCI card from an Asus WL-500W for a "buy now" price of $34.99 US. The photo clearly shows the Broadcom logo on a chip.

Who is in charge of the funds that were donated to the b43 project? This item should be purchased for Rafal.

I actually got some donations from Polish users, plus I should get that card rented from user I mentioned a littler earlier.

The bad part is that I'll probably have to return that card after few months. But do we need that card for long long future, how do you think?

Signature · 1 line
Rafa?
#34 lore raw

b43 N PHY status report

Quoted 7 lines · Rafa? Mi?ecki

I actually got some donations from Polish users, plus I should get that card rented from user I mentioned a littler earlier.

The bad part is that I'll probably have to return that card after few months. But do we need that card for long long future, how do you think?

Depending on the chip model, a few months should be sufficient. If you find that you need one longer, we should be able to find one for purchase.

Larry

#35 lore raw

b43 N PHY status report

In reply to Larry Finger
Quoted 2 lines · Larry Finger

Ebay has the MiniPCI card from an Asus WL-500W for a "buy now" price of $34.99 US.

More than one available?

//Peter

#36 lore raw

b43 N PHY status report

Quoted 5 lines · Peter Stuge
Quoted 2 lines · Larry Finger

Ebay has the MiniPCI card from an Asus WL-500W for a "buy now" price of $34.99 US.

More than one available?

No, just the one card by itself. There are a number of Asus WL-500W routers ranging from $49.99 used to $121 new. The latter are in the UK.

Larry

#37 lore raw

b43 N PHY status report

In reply to Peter Stuge
Quoted 4 lines · Peter Stuge
Quoted 1 line · Larry Finger

The N PHY driver is remarkably stable.

Are there some N PHY MiniPCI cards? (Not Express.)

I searched a lot in the past and unfortunately I never found a mini-pci card with N-PHY. Cards installed in MacBook since 2007 (and I believe also in some Lenovo notebooks) have a different connector but I don't know what it is, maybe it's just another adapter for mini-pci-e.

Would you mind reporting here if you will ever find mini-pci N-PHY?

Thanks,
-Francesco

Informativa sulla privacy: http://help.ing.unibs.it/privacy.php

#38 lore raw

b43 N PHY status report

In reply to Larry Finger
Quoted 8 lines · Larry Finger

Rafa?,

The N PHY driver is remarkably stable. So far, my link has been up for nearly 16 hours under normal conditions - I have not yet tried any stress tests. Other than the PHY errors that you noted, my link has only reported 2 other unusual events. I have had 3 "Deauthentication for reason 3" from which it recovered in one try. Also logged are 9 instances of "RX: Packet size underrun (2)/Packet dropped" events. Again, these caused no problems.

Hi Rafa?,

I confirm Larry's feedbacks. I tried both on a 32bit and a 64bit architectures (the first is frodo), and it works. I too see only CCK packets. On 64bit arch (Atom) it works but when I try to unload the module I get this

[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1

and the device is never release (by who?). I have to reboot.

I'm using two cards, one reports

[  311.439406] b43-phy0: Broadcom 4321 WLAN found (core revision 12)
[  311.480046] b43-phy0 debug: Found PHY: Analog 5, Type 4, Revision 2
[  311.480075] b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2055, Revision 4

The other (an Apple original card) reports

[   82.726931] b43-phy0: Broadcom 4321 WLAN found (core revision 11)
[   82.768030] b43-phy0 debug: Found PHY: Analog 5, Type 4, Revision 1
[   82.768062] b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2055, Revision 4

Thanks,
-Francesco

Informativa sulla privacy: http://help.ing.unibs.it/privacy.php

maintainer
#39 lore raw

b43 N PHY status report

Quoted 3 lines · Francesco Gringoli
[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1

and the device is never release (by who?). I have to reboot.

That's a bug in the ipv6 code, upgrade your kernel :-)

johannes

#40 lore raw

b43 N PHY status report

Quoted 7 lines · Johannes Berg
Quoted 3 lines · Francesco Gringoli
[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1

and the device is never release (by who?). I have to reboot.

That's a bug in the ipv6 code, upgrade your kernel :-)

I would not have seen that as IPv6 is disabled in my kernels.

Larry

#41 lore raw

b43 N PHY status report

Quoted 10 lines · Larry Finger
Quoted 7 lines · Johannes Berg
Quoted 3 lines · Francesco Gringoli
[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1

and the device is never release (by who?). I have to reboot.

That's a bug in the ipv6 code, upgrade your kernel :-)

I would not have seen that as IPv6 is disabled in my kernels.

Are you serious? Disabling ipv6 with ipv4 exhaustion expected in January?

Quoted 7 lines

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
maintainer
#42 lore raw

b43 N PHY status report

Quoted 6 lines · G?bor Stefanik
Quoted 5 lines · Larry Finger
Quoted 4 lines · Johannes Berg
Quoted 2 lines · Francesco Gringoli
[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

and the device is never release (by who?). I have to reboot.

That's a bug in the ipv6 code, upgrade your kernel :-)

I would not have seen that as IPv6 is disabled in my kernels.

Are you serious? Disabling ipv6 with ipv4 exhaustion expected in January?

Can we stop this thread right here and go on-topic again please?

johannes

#43 lore raw

b43 N PHY status report

Quoted 9 lines · Johannes Berg
Quoted 8 lines · G?bor Stefanik
Quoted 7 lines · Larry Finger
Quoted 6 lines · Johannes Berg
Quoted 3 lines · Francesco Gringoli
[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1

and the device is never release (by who?). I have to reboot.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

That's a bug in the ipv6 code, upgrade your kernel :-)

I would not have seen that as IPv6 is disabled in my kernels.

Are you serious? Disabling ipv6 with ipv4 exhaustion expected in January?

Can we stop this thread right here and go on-topic again please?

On-topic:

Anyone working on or testing network device drivers should be using IPv6. IPv6 will exercise code paths and network behaviour that Legacy IP rarely does, in particular using multicast to do neighbour discovery. And on wireless networks when multicast will be handled differently by the AP, that makes more difference than on wired where it's mostly the MAC filters that get neglected.

I've seen a number of broken drivers because their authors were only testing with Legacy IP and not IPv6.

It's not hard to set up IPv6. Larry, if you need any pointers I'd be more than happy to help.

Signature · 1 line
dwmw2
#44 lore raw

b43 N PHY status report

2010/12/21 David Woodhouse <[email protected]>:

Quoted 27 lines · Johannes Berg
Quoted 9 lines · G?bor Stefanik
Quoted 8 lines · Larry Finger
Quoted 7 lines · Johannes Berg
Quoted 6 lines · Francesco Gringoli
Quoted 4 lines
[ 1117.516031] unregister_netdevice: waiting for wlan1 to become free. Usage count = 1

and the device is never release (by who?). I have to reboot.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

That's a bug in the ipv6 code, upgrade your kernel :-)

I would not have seen that as IPv6 is disabled in my kernels.

Are you serious? Disabling ipv6 with ipv4 exhaustion expected in January?

Can we stop this thread right here and go on-topic again please?

On-topic:

Anyone working on or testing network device drivers should be using IPv6. IPv6 will exercise code paths and network behaviour that Legacy IP rarely does, in particular using multicast to do neighbour discovery. And on wireless networks when multicast will be handled differently by the AP, that makes more difference than on wired where it's mostly the MAC filters that get neglected.

Quoted 5 lines

I've seen a number of broken drivers because their authors were only testing with Legacy IP and not IPv6.

It's not hard to set up IPv6. Larry, if you need any pointers I'd be more than happy to help.

I've router with OpenWRT, so that probably should be possible for me to setup IPv6. However first I want to have working basic PHY and radio configuration.

Signature · 1 line
Rafa?
#45 lore raw

b43 N PHY status report

In reply to David Woodhouse
Quoted 10 lines · David Woodhouse

On-topic:

Anyone working on or testing network device drivers should be using IPv6. IPv6 will exercise code paths and network behaviour that Legacy IP rarely does, in particular using multicast to do neighbour discovery. And on wireless networks when multicast will be handled differently by the AP, that makes more difference than on wired where it's mostly the MAC filters that get neglected.

Quoted 5 lines

I've seen a number of broken drivers because their authors were only testing with Legacy IP and not IPv6.

It's not hard to set up IPv6. Larry, if you need any pointers I'd be more than happy to help.

I have no problem setting it up. I disabled it mostly to reduce the number of modules in a kernel recompile. It doesn't make much difference on either of my multi-core boxes, but some of the lower-powered units already take hours to build.

I take your point, and will be reenabling IPv6.

Larry

#46 lore raw

b43 N PHY status report

In reply to Larry Finger

It's not been so stable on my BCM4312, but it's still stable. It can keep the connection for ~3 hours here.

2010/12/8 Larry Finger <[email protected]>

Quoted 24 lines

Rafa?,

The N PHY driver is remarkably stable. So far, my link has been up for nearly 16
hours under normal conditions - I have not yet tried any stress tests. Other
than the PHY errors that you noted, my link has only reported 2 other unusual
events. I have had 3 "Deauthentication for reason 3" from which it recovered in
one try. Also logged are 9 instances of "RX: Packet size underrun (2)/Packet
dropped" events. Again, these caused no problems.

Larry

_______________________________________________
b43-dev mailing list
b43-dev at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

Signature · 4 lines
Blog: http://www.gtklocker.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20101210/6a7db86e/attachment.html>
#47 lore raw

b43 N PHY status report

Quoted 2 lines · Konstantinos Karantias

It's not been so stable on my BCM4312, but it's still stable. It can keep the connection for ~3 hours here.

Your BCM4312 probably has an LP PHY. We were reporting on the N PHY devices.

I have 2 LP PHY units - both stay connected although one of them gets "cookie out of order" errors on occasion. Please report the exact details for your device.

Larry

#48 lore raw

cover Make N-PHY support experimental

In reply to Gábor Stefanik

W dniu 7 grudnia 2010 23:57 u?ytkownik G?bor Stefanik <[email protected]> napisa?:

Quoted 4 lines

2010/12/7 Rafa? Mi?ecki <[email protected]>:

Quoted 1 line

Finally, thanks for Larry and Francesco I got b43 working with BCM4328 chipset!

Do you mean BCM4321 (14e4:4328)? BCM4328 is AFAIK handled by brcmfmac.

Yeah, I removed following hack some time ago:
- } else if (bus->chip_id == 0x4321) {
- /* the BCM4328 has a chipid == 0x4321 and a rev 4 SPROM */
and got lost what is my chipset. You're right.

Signature · 1 line
Rafa?