block cfq: select new workload if priority changed
PATCH 1/1 block cfq: select new workload if priority changed
If priority is changed, continue checking workload_expires and service tree count of previous workload is meaningless. We should always choose the workload with lowest key of new priority in such case.
--- block/cfq-iosched.c | 5 +++++ 1 file changed, 5 insertions(+)
block/cfq-iosched.c +5 -0
@@ -2116,6 +2116,7 @@ static void choose_service_tree(struct cunsigned count;struct cfq_rb_root *st;unsigned group_slice; +enum wl_prio_t original_prio = cfqd->serving_prio;if (!cfqg) { cfqd->serving_prio =IDLE_WORKLOAD ;
@@ -2134,6 +2135,9 @@ static void choose_service_tree(struct creturn ; } +if (original_prio != cfqd->serving_prio) + goto new_workload; +/* * For RT and BE, we have to choose also the type * (SYNC, SYNC_NOIDLE, ASYNC), and to compute a workload
@@ -2148,6 +2152,7 @@ static void choose_service_tree(struct cif (count && !time_after (jiffies, cfqd->workload_expires))return ; +new_workload:/* otherwise select new workload type */ cfqd->serving_type =cfq_choose_wl (cfqd, cfqg, cfqd->serving_prio);
Quoted 2 lines · Shaohua Li
If priority is changed, continue checking
workload_expiresand service tree count of previous workload is meaningless. We should always choose the workload
I'd change that first sentence to:
If priority is changed, continuing to check workload_expires and service tree count of the previous workload does not make sense.
Quoted 3 lines
with lowest key of new priority in such case.
Signed-off-by Shaohua Li <[email protected]>
This makes sense to me.
Shaohua Li
Reviewed-by Jeff MoyerQuoted 10 lines · Jeff Moyer
Quoted 2 lines · Shaohua Li
If priority is changed, continue checking
workload_expiresand service tree count of previous workload is meaningless. We should always choose the workloadI'd change that first sentence to:
If priority is changed, continuing to check
workload_expiresand service tree count of the previous workload does not make sense.
Quoted 7 lines
Quoted 3 lines
with lowest key of new priority in such case.
Signed-off-by Shaohua Li <[email protected]>This makes sense to me.
Reviewed-by Jeff Moyer <[email protected]>
Thanks, modified the the changelog.
If priority is changed, continuing to check workload_expires and service tree count of the previous workload does not make sense. We should always choose the workload with lowest key of new priority in such case.
--- block/cfq-iosched.c | 5 +++++ 1 file changed, 5 insertions(+)
block/cfq-iosched.c +5 -0
@@ -2116,6 +2116,7 @@ static void choose_service_tree(struct cunsigned count;struct cfq_rb_root *st;unsigned group_slice; +enum wl_prio_t original_prio = cfqd->serving_prio;if (!cfqg) { cfqd->serving_prio =IDLE_WORKLOAD ;
@@ -2134,6 +2135,9 @@ static void choose_service_tree(struct creturn ; } +if (original_prio != cfqd->serving_prio) + goto new_workload; +/* * For RT and BE, we have to choose also the type * (SYNC, SYNC_NOIDLE, ASYNC), and to compute a workload
@@ -2148,6 +2152,7 @@ static void choose_service_tree(struct cif (count && !time_after (jiffies, cfqd->workload_expires))return ; +new_workload:/* otherwise select new workload type */ cfqd->serving_type =cfq_choose_wl (cfqd, cfqg, cfqd->serving_prio);
Jens Axboe
AppliedQuoted 11 lines · Shaohua Li
Quoted 10 lines · Jeff Moyer
Quoted 2 lines · Shaohua Li
If priority is changed, continue checking
workload_expiresand service tree count of previous workload is meaningless. We should always choose the workloadI'd change that first sentence to:
If priority is changed, continuing to check
workload_expiresand service tree count of the previous workload does not make sense.
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
with lowest key of new priority in such case.
Signed-off-by Shaohua Li <[email protected]>This makes sense to me.
Reviewed-by Jeff Moyer <[email protected]>Thanks, modified the the changelog.
Thanks, applied to for-2.6.38/core
Signature · 1 line
Jens Axboe