Skip to contentSkip to conversation

ASoC: WM8580: Fix R8 initial value

PATCH In review Jassi Brar 4 participants 4 messages Dec 9, 2010

Subsystems (3)
lore
Share & tools
lore

Jassi Brar

author
#0 lore raw

PATCH 1/1 ASoC: WM8580: Fix R8 initial value

From: Seungwhan Youn <[email protected]>

Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.

---
 sound/soc/codecs/wm8580.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/wm8580.c +1 -1
index 6e95332..6be373d 100644
@@ -179,7 +179,7 @@
 static const u16 wm8580_reg[] = {
 	0x0121, 0x017e, 0x007d, 0x0014, /*R3*/
 	0x0121, 0x017e, 0x007d, 0x0194, /*R7*/
-	0x001c, 0x0002, 0x0002, 0x00c2, /*R11*/
+	0x0010, 0x0002, 0x0002, 0x00c2, /*R11*/
 	0x0182, 0x0082, 0x000a, 0x0024, /*R15*/
 	0x0009, 0x0000, 0x00ff, 0x0000, /*R19*/
 	0x00ff, 0x00ff, 0x00ff, 0x00ff, /*R23*/
Signature · 1 line
1.6.2.5
#2 lore raw
In reply to Jassi Brar
Quoted 6 lines · Jassi Brar

From: Seungwhan Youn <[email protected]>

Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.

---

You really should include your signoff in patches when sending ones written by other people to say that you're certifying that the patch is legally OK to submit - that's what the signoff stuff is about, it's about saying that you take responsibility for the patch.

In this case it's not so important as it's a trivially obvious fix so probably below the individually copyrightable threashold anyway so I've applied.

#3 lore raw
Quoted 5 lines · Mark Brown
Quoted 4 lines · Jassi Brar

From: Seungwhan Youn <[email protected]>

Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.

Quoted 7 lines
Quoted 2 lines

---

You really should include your signoff in patches when sending ones written by other people to say that you're certifying that the patch is legally OK to submit - that's what the signoff stuff is about, it's about saying that you take responsibility for the patch.

Ok, will take care in future.
Thanks.