Skip to contentSkip to conversation

LEDs: fix check for return value of blink_set callback

PATCH In review Vasily Khoruzhick 2 participants 2 messages Dec 10, 2010 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 LEDs: fix check for return value of blink_set callback

blink_set callback should return 0 on success, but check in led-class.c is invalid. It results in software fallback even if hw support is available.

---
 drivers/leds/led-class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/led-class.c +1 -1
index 211e21f..d5a4ade 100644
@@ -267,7 +267,7 @@ void led_blink_set(struct led_classdev *led_cdev,
 		   unsigned long *delay_off)
 {
 	if (led_cdev->blink_set &&
-	    led_cdev->blink_set(led_cdev, delay_on, delay_off))
+	    !led_cdev->blink_set(led_cdev, delay_on, delay_off))
 		return;
 
 	/* blink with 1 Hz as default if nothing specified */
Signature · 1 line
1.7.3.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Vasily Khoruzhick

blink_set callback should return 0 on success, but check in led-class.c is invalid. It results in software fallback even if hw support is available.

Quoted 17 lines
---
 drivers/leds/led-class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/led-class.c +1 -1
index 211e21f..d5a4ade 100644
@@ -267,7 +267,7 @@ void led_blink_set(struct led_classdev *led_cdev,
 		   unsigned long *delay_off)
 {
 	if (led_cdev->blink_set &&
-	    led_cdev->blink_set(led_cdev, delay_on, delay_off))
+	    !led_cdev->blink_set(led_cdev, delay_on, delay_off))
 		return;
 
 	/* blink with 1 Hz as default if nothing specified */