ata: pata_at91.c bugfix for high master clock
Subsystems (2)
PATCH 1/1 ata: pata_at91.c bugfix for high master clock
The AT91SAM9 microcontrollers with master clock higher then 105 MHz and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and pata_at91 driver does detect ATA device.
--- drivers/ata/pata_at91.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)
drivers/ata/pata_at91.c +9 -2
@@ -33,12 +33,14 @@#define DRV_NAME "pata_at91" -#define DRV_VERSION "0.1" +#define DRV_VERSION "0.2"#define CF_IDE_OFFSET 0x00c00000#define CF_ALT_IDE_OFFSET 0x00e00000#define CF_IDE_RES_SIZE 0x08 +#define NCS_RD_PULSE_LIMIT 0x3f/* maximal value for pulse bitfields */ +struct at91_ide_info {unsigned long mode;unsigned int cs;
@@ -50,7 +52,7 @@ struct at91_ide_info { };static const struct ata_timing initial_timing = - {XFER_PIO_0 ,70 ,290 ,240 ,600 ,165 ,150 ,600 ,0 }; + {XFER_PIO_0 ,70 ,290 ,240 ,600 ,165 ,150 ,0 ,600 ,0 };static unsigned long calc_mck_cycles (unsigned long ns,unsigned long mck_hz) {
@@ -109,6 +111,11 @@ static void set_smc_timing(struct device *dev,/* (CS0, CS1, DIR, OE) <= (CFCE1, CFCE2, CFRNW, NCSX) timings */ ncs_read_setup =1 ; ncs_read_pulse = read_cycle -2 ; +if (ncs_read_pulse >NCS_RD_PULSE_LIMIT ) { + ncs_read_pulse =NCS_RD_PULSE_LIMIT ; +dev_dbg (dev,"ncs_read_pulse limited to maximal value %lu\n" , + ncs_read_pulse); + }/* Write timings same as read timings */ write_cycle = read_cycle;
Signature · 1 line
1.7.0.4
Here is a typo in the patch description:
Quoted 4 lines
The AT91SAM9 microcontrollers with master clock higher then 105 MHz and PIO0, have overflow of the
NCS_RD_PULSEvalue in the MSB. This lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse andpata_at91driver does detect ATA device.
"...driver DOES NOT detect ATA device."
PATCH 1/1 ata: pata_at91.c bugfix for high master clock
In reply to Igor PlyatovHello Igor,
Quoted 40 lines · On Fri, 10 Dec 2010 23:03:50 +0300 Igor Plyatov <[email protected]> wrote:
The AT91SAM9 microcontrollers with master clock higher then 105 MHz and PIO0, have overflow of the
NCS_RD_PULSEvalue in the MSB. This lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse andpata_at91driver does detect ATA device.Signed-off-by Igor Plyatov <[email protected]>--- drivers/ata/pata_at91.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)drivers/ata/pata_at91.c +2
-1@@ -33,12 +33,14 @@#define DRV_NAME "pata_at91" -#define DRV_VERSION "0.1" +#define DRV_VERSION "0.2"#define CF_IDE_OFFSET 0x00c00000#define CF_ALT_IDE_OFFSET 0x00e00000#define CF_IDE_RES_SIZE 0x08 +#define NCS_RD_PULSE_LIMIT 0x3f/* maximal value for pulse bitfields */ +
structat91_ide_info{drivers/ata/pata_at91.c +1
-1unsigned long mode;unsigned int cs;@@ -50,7 +52,7 @@ struct at91_ide_info { };static const struct ata_timing initial_timing = - {XFER_PIO_0 ,70 ,290 ,240 ,600 ,165 ,150 ,600 ,0 }; + {XFER_PIO_0 ,70 ,290 ,240 ,600 ,165 ,150 ,0 ,600 ,0 };static unsigned long calc_mck_cycles (unsigned long ns,unsigned long mck_hz) {
drivers/ata/pata_at91.c static void set_smc_timing(struct device *dev, · line 116
Quoted 6 lines
drivers/ata/pata_at91.c +3
-0@@ -109,6 +111,11 @@ static void set_smc_timing(struct device *dev,/* (CS0, CS1, DIR, OE) <= (CFCE1, CFCE2, CFRNW, NCSX) timings */ ncs_read_setup =1 ; ncs_read_pulse = read_cycle -2 ; +if (ncs_read_pulse >NCS_RD_PULSE_LIMIT ) { + ncs_read_pulse =NCS_RD_PULSE_LIMIT ; + dev_dbg(dev, "ncs_read_pulse limited to maximal
arguably 'dev_warn' would be more useful in this case
Quoted 6 lines
drivers/ata/pata_at91.c +2
-0value %lu\n", + ncs_read_pulse); + }/* Write timings same as read timings */
write_cycle=read_cycle;
Thanks for the fix.
Best regards,
Sergey
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 1292081113.1580.21.camel@homepc
A message that is not in the archive (sent off-list or not yet received): [email protected]
Dear Sergei,
Quoted 4 lines
Quoted 2 lines
I do not test this driver, but I think it have the same problem, because it have the same algorithm for timings calculation.
I quickly looked thru both drivers and the algorithm seemed different. :-)
I don't think so...
Quoted 3 lines
Quoted 1 line
If you will see "cycle" value greater then 63, then problem exists.
I thought the problem was with active pulse width, not total cycle time...
The problem was - the same "cycle" variable used to set up NRD_CYCLE (max value = 127) and NCS_RD_PULSE (max value = 63).
Where NRD_CYCLE, NCS_RD_PULSE names from datasheet for AT91SAM9. If NCS_RD_PULSE > 63, then overflow occur and pulse is much longer then required.
For the 132 MHz, driver use NCS_RD_PULSE = 80 at device detection moment on my board.
Calculated cycle in at91_ide is the same as for pata_at91 driver.
Quoted 8 lines
Quoted 2 lines
Generally, I does not see any reasons to use
at91_ide, because ATA drivers subsystem going to replace IDE drivers.There may be reasons -- like larger thruput in PIO mode (you have to check
this though -- but generally libata seems very slow in PIO). Anyway, it doesn't mean that the bugs in IDE drivers should be ignored, and the replacemtn will not happen anytime soon (not all IDE drivers are ported to libata yet).
I will send next patch where this driver corrected and tested.
Best regards!
--
Igor Plyatov
Hello.
Quoted 6 lines · Igor Plyatov
Quoted 4 lines
Quoted 2 lines
I do not test this driver, but I think it have the same problem, because it have the same algorithm for timings calculation.
I quickly looked thru both drivers and the algorithm seemed different. :-)
I don't think so...
In fact, the algorithm is slightly different.
Quoted 9 lines
Quoted 3 lines
Quoted 1 line
If you will see "cycle" value greater then 63, then problem exists.
I thought the problem was with active pulse width, not total cycle time...
The problem was - the same "cycle" variable used to set up
NRD_CYCLE(max value = 127) andNCS_RD_PULSE(max value = 63).
WhereNRD_CYCLE,NCS_RD_PULSEnames from datasheet for AT91SAM9. IfNCS_RD_PULSE> 63, then overflow occur and pulse is much longer then required.
Ah, NCS_RD_PULSE is different from active pulse time which is in the
variable 'nrd_pulse'.
Quoted 3 lines
For the 132 MHz, driver use
NCS_RD_PULSE= 80 at device detection moment on my board.
Calculated cycle inat91_ideis the same as forpata_at91driver.
Yes, but NCS_RD_PULSE is different in these drivers, it's cycle_time inat91_ide.c and (cycle time - 2) in the pata_at91.c... Then there should indeed be an error in at91_ide.c as well.
Quoted 10 lines
Quoted 8 lines
Quoted 2 lines
Generally, I does not see any reasons to use
at91_ide, because ATA drivers subsystem going to replace IDE drivers.There may be reasons -- like larger thruput in PIO mode (you have to check
this though -- but generally libata seems very slow in PIO). Anyway, it doesn't mean that the bugs in IDE drivers should be ignored, and the replacemtn will not happen anytime soon (not all IDE drivers are ported to libata yet).I will send next patch where this driver corrected and tested.
Thanks. :-)
Quoted 3 lines
Best regards!
--
Igor Plyatov
WBR, Sergei