Skip to contentSkip to conversation

ARM: mmp: added 5V Regulator enable for Brownstone

PATCH New Mark F. Brown 3 participants 3 messages Dec 12, 2010 – Dec 13, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mmp: added 5V Regulator enable for Brownstone

5V supply for USB ports, LCD connector, and HDMI

---
 arch/arm/mach-mmp/brownstone.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
arch/arm/mach-mmp/brownstone.c +20 -0
index 635c400..9d37b35 100644
@@ -97,8 +97,13 @@ static unsigned long brownstone_pin_config[] __initdata = {
 	GPIO111_MMC3_DAT0 | MFP_PULL_HIGH,
 	GPIO112_MMC3_CMD | MFP_PULL_HIGH,
 	GPIO151_MMC3_CLK,
+
+	/* 5V Regulator */
+	GPIO89_GPIO89,
 };
 
+#define GPIO_5V_ENABLE	(89)
+
 static struct regulator_consumer_supply max8649_supply[] = {
 	REGULATOR_SUPPLY("vcc_core", NULL),
 };
@@ -145,10 +150,25 @@ static struct sdhci_pxa_platdata mmp2_sdh_platdata_mmc0 = {
 	.max_speed	= 25000000,
 };
 
+/* enable for MAX8815A regulator (5V_ENABLE) */
+static void brownstone_enable_5v_regulator(void)
+{
+	int ret;
+	ret = gpio_request(GPIO_5V_ENABLE, "5V_ENABLE");
+	if (ret < 0)
+		pr_warning("Unable to request GPIO_5V_ENABLE\n");
+	else
+		gpio_direction_output(GPIO_5V_ENABLE, 1);
+	gpio_free(GPIO_5V_ENABLE);
+}
+
 static void __init brownstone_init(void)
 {
 	mfp_config(ARRAY_AND_SIZE(brownstone_pin_config));
 
+	/* enable 5v regulator */
+	brownstone_enable_5v_regulator();
+
 	/* on-chip devices */
 	mmp2_add_uart(1);
 	mmp2_add_uart(3);
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 ARM: mmp: added 5V Regulator enable for Brownstone

Quoted 3 lines · Mark F. Brown

5V supply for USB ports, LCD connector, and HDMI

Looks good. Applied to 'devel'.

Quoted 52 lines

---
?arch/arm/mach-mmp/brownstone.c | ? 20 ++++++++++++++++++++ ?1 files changed, 20 insertions(+), 0 deletions(-)

arch/arm/mach-mmp/brownstone.c +20 -0
index 635c400..9d37b35 100644
@@ -97,8 +97,13 @@ static unsigned long brownstone_pin_config[] __initdata = {
 ? ? ? ?GPIO111_MMC3_DAT0 | MFP_PULL_HIGH,
 ? ? ? ?GPIO112_MMC3_CMD | MFP_PULL_HIGH,
 ? ? ? ?GPIO151_MMC3_CLK,
+
+ ? ? ? /* 5V Regulator */
+ ? ? ? GPIO89_GPIO89,
 ?};
 
+#define GPIO_5V_ENABLE (89)
+
 ?static struct regulator_consumer_supply max8649_supply[] = {
 ? ? ? ?REGULATOR_SUPPLY("vcc_core", NULL),
 ?};
@@ -145,10 +150,25 @@ static struct sdhci_pxa_platdata mmp2_sdh_platdata_mmc0 = {
 ? ? ? ?.max_speed ? ? ?= 25000000,
 ?};
 
+/* enable for MAX8815A regulator (5V_ENABLE) */
+static void brownstone_enable_5v_regulator(void)
+{
+ ? ? ? int ret;
+ ? ? ? ret = gpio_request(GPIO_5V_ENABLE, "5V_ENABLE");
+ ? ? ? if (ret < 0)
+ ? ? ? ? ? ? ? pr_warning("Unable to request GPIO_5V_ENABLE\n");
+ ? ? ? else
+ ? ? ? ? ? ? ? gpio_direction_output(GPIO_5V_ENABLE, 1);
+ ? ? ? gpio_free(GPIO_5V_ENABLE);
+}
+
 ?static void __init brownstone_init(void)
 ?{
 ? ? ? ?mfp_config(ARRAY_AND_SIZE(brownstone_pin_config));
 
+ ? ? ? /* enable 5v regulator */
+ ? ? ? brownstone_enable_5v_regulator();
+

? ? ? ?/* on-chip devices */
? ? ? ?mmp2_add_uart(1);
? ? ? ?mmp2_add_uart(3);
--
1.7.0.4

#2 lore raw

PATCH 1/1 ARM: mmp: added 5V Regulator enable for Brownstone

In reply to Mark F. Brown
Quoted 3 lines · Mark F. Brown

5V supply for USB ports, LCD connector, and HDMI

Might make sense to represent this as a fixed voltage regulator (they can control a GPIO enable line) if it's possible to usefully power this supply off in low power modes?