Skip to contentSkip to conversation

if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ

RFC PATCH In review Joe Perches 3 participants 6 messages Dec 14, 2010 – Jan 6, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ

LARQ seems to be used by Broadcom's staging driver. Might as well add a #define for it to the normal location.

---
 include/linux/if_ether.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/if_ether.h +2 -0
index f9c3df0..b257e99 100644
@@ -71,6 +71,8 @@
 #define ETH_P_PPP_SES	0x8864		/* PPPoE session messages	*/
 #define ETH_P_MPLS_UC	0x8847		/* MPLS Unicast traffic		*/
 #define ETH_P_MPLS_MC	0x8848		/* MPLS Multicast traffic	*/
+#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
+					 * Limited Automatic Repeat reQuest */
 #define ETH_P_ATMMPOA	0x884c		/* MultiProtocol Over ATM	*/
 #define ETH_P_ATMFATE	0x8884		/* Frame-based ATM Transport
 					 * over Ethernet
#1 lore raw
Quoted 13 lines · Joe Perches

LARQ seems to be used by Broadcom's staging driver. Might as well add a #define for it to the normal location.

---
 include/linux/if_ether.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/if_ether.h +0 -0
index f9c3df0..b257e99 100644

include/linux/if_ether.h line 75

Quoted 5 lines
include/linux/if_ether.h +2 -0
@@ -71,6 +71,8 @@
 #define ETH_P_PPP_SES	0x8864		/* PPPoE session messages	*/
 #define ETH_P_MPLS_UC	0x8847		/* MPLS Unicast traffic		*/
 #define ETH_P_MPLS_MC	0x8848		/* MPLS Multicast traffic	*/
+#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
+					 * Limited Automatic Repeat reQuest */

That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a different subypte for encapsulating some event signals between the device and the host, but doesn't implement any of the HPNA protocols.

- Henry

#2 lore raw
Quoted 4 lines · Henry Ptasinski

include/linux/if_ether.h

Quoted 3 lines · Joe Perches

LARQ seems to be used by Broadcom's staging driver. Might as well add a #define for it to the normal location.

include/linux/if_ether.h +0 -0

[]

Quoted 5 lines
Quoted 1 line

+#define ETH_P_LARQ 0x886c /* HPNA / Broadcom

That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a different subypte for encapsulating some event signals between the device and the host, but doesn't implement any of the HPNA protocols.

Another choice might be ETH_P_LINK_CTL

#3 lore raw
Quoted 6 lines · Joe Perches
Quoted 4 lines · Henry Ptasinski

include/linux/if_ether.h

Quoted 3 lines · Joe Perches

LARQ seems to be used by Broadcom's staging driver. Might as well add a #define for it to the normal location.

include/linux/if_ether.h +0 -0

[]

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

+#define ETH_P_LARQ 0x886c /* HPNA / Broadcom

That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a different subypte for encapsulating some event signals between the device and the host, but doesn't implement any of the HPNA protocols.

Another choice might be ETH_P_LINK_CTL

That would be fine too.

- Henry

#4 lore raw

PATCH 1/1 include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel

In reply to Joe Perches

Ethertype used by HPNA control protocols (LARQ, rate, link, etc) and by Broadcom wlan drivers for local signalling.

---
 include/linux/if_ether.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/if_ether.h +1 -0
index f9c3df0..be69043 100644
@@ -72,6 +72,7 @@
 #define ETH_P_MPLS_UC	0x8847		/* MPLS Unicast traffic		*/
 #define ETH_P_MPLS_MC	0x8848		/* MPLS Multicast traffic	*/
 #define ETH_P_ATMMPOA	0x884c		/* MultiProtocol Over ATM	*/
+#define ETH_P_LINK_CTL	0x886c		/* HPNA, wlan link local tunnel */
 #define ETH_P_ATMFATE	0x8884		/* Frame-based ATM Transport
 					 * over Ethernet
 					 */
Signature · 1 line
1.7.1
maintainer Applied
#5 lore raw

Re: [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel

From: "Henry Ptasinski" <[email protected]>
Date: Tue, 4 Jan 2011 18:07:14 -0800

Quoted 4 lines

Ethertype used by HPNA control protocols (LARQ, rate, link, etc) and by Broadcom wlan drivers for local signalling.

Applied, thanks.