drm/i915: Set the required VFMUNIT clock gating disable on Ironlake.
Subsystems (2)
PATCH 1/1 drm/i915: Set the required VFMUNIT clock gating disable on Ironlake.
It's required by the specs, but we don't know why. Let's not find out why.
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_display.c | 2 ++ 2 files changed, 5 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -2512,6 +2512,9 @@# define MARIUNIT_CLOCK_GATE_DISABLE (1 << 18)# define SVSMUNIT_CLOCK_GATE_DISABLE (1 << 1) +#define PCH_3DCGDIS1 0x46024 +# define VFMUNIT_CLOCK_GATE_DISABLE (1 << 11) +#define FDI_PLL_FREQ_CTL 0x46030#define FDI_PLL_FREQ_CHANGE_REQUEST (1<<24)#define FDI_PLL_FREQ_LOCK_LIMIT_MASK 0xfff00
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -5768,6 +5768,8 @@ void intel_init_clock_gating(struct drm_device *dev)I915_WRITE (PCH_3DCGDIS0 ,MARIUNIT_CLOCK_GATE_DISABLE |SVSMUNIT_CLOCK_GATE_DISABLE ); +I915_WRITE (PCH_3DCGDIS1 , +VFMUNIT_CLOCK_GATE_DISABLE ); }I915_WRITE (PCH_DSPCLK_GATE_D , dspclk_gate);
Signature · 1 line
1.7.2.3
Quoted 2 lines · Eric Anholt
It's required by the specs, but we don't know why. Let's not find out why.
Any feel at all for the level of impact of not disabling power gating of the VFM unit? Random hang? Incorrect output? I'm not even sure what the VFM unit is.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 8 lines · Chris Wilson
Quoted 2 lines · Eric Anholt
It's required by the specs, but we don't know why. Let's not find out why.
Any feel at all for the level of impact of not disabling power gating of the VFM unit? Random hang? Incorrect output? I'm not even sure what the VFM unit is.
-Chris
No clue.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx