Skip to contentSkip to conversation

Add enc_read_blob_req() API to ATT

PATCH In review Brian Gix 2 participants 5 messages Dec 14, 2010 – Dec 16, 2010 Bluetooth drivers

lore
Share & tools
lore

Brian Gix

author
#0 lore raw

cover Add enc_read_blob_req() API to ATT

Atomic change to add ATT_OP_READ_BLOB_REQ encoing to ATT. No dependancies.

Signature · 4 lines
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum 
author
#1 lore raw

PATCH 1/1 Added enc_read_blob_req() API to ATT transport, to enable the reading of attributes that exceed the length of the MTU.

Signature · 9 lines
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum 

---
 attrib/att.c |   19 +++++++++++++++++++
 attrib/att.h |    2 ++
 2 files changed, 21 insertions(+), 0 deletions(-)
attrib/att.c +19 -0
index 445b192..f8dbc02 100644
@@ -542,6 +542,25 @@ uint16_t enc_read_req(uint16_t handle, uint8_t *pdu, int len)
 	return min_len;
 }
 
+uint16_t enc_read_blob_req(uint16_t handle, uint16_t offset, uint8_t *pdu,
+									int len)
+{
+	const uint16_t min_len = sizeof(pdu[0]) + sizeof(handle) +
+							sizeof(offset);
+
+	if (pdu == NULL)
+		return 0;
+
+	if (len < min_len)
+		return 0;
+
+	pdu[0] = ATT_OP_READ_BLOB_REQ;
+	att_put_u16(handle, &pdu[1]);
+	att_put_u16(offset, &pdu[3]);
+
+	return min_len;
+}
+
 uint16_t dec_read_req(const uint8_t *pdu, int len, uint16_t *handle)
 {
 	const uint16_t min_len = sizeof(pdu[0]) + sizeof(*handle);
attrib/att.h +2 -0
index 2c8c724..0b8612e 100644
@@ -202,6 +202,8 @@ uint16_t enc_write_req(uint16_t handle, const uint8_t *value, int vlen,
 uint16_t dec_write_req(const uint8_t *pdu, int len, uint16_t *handle,
 						uint8_t *value, int *vlen);
 uint16_t enc_read_req(uint16_t handle, uint8_t *pdu, int len);
+uint16_t enc_read_blob_req(uint16_t handle, uint16_t offset, uint8_t *pdu,
+									int len);
 uint16_t dec_read_req(const uint8_t *pdu, int len, uint16_t *handle);
 uint16_t enc_read_resp(uint8_t *value, int vlen, uint8_t *pdu, int len);
 uint16_t dec_read_resp(const uint8_t *pdu, int len, uint8_t *value, int *vlen);
Signature · 1 line
1.7.1
#2 lore raw

Re: [PATCH] Added enc_read_blob_req() API to ATT transport, to enable the reading of attributes that exceed the length of the MTU.

Quoted 10 lines · Brian Gix

--
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

---
 attrib/att.c |   19 +++++++++++++++++++
 attrib/att.h |    2 ++

 2 files changed, 21 insertions(+), 0 deletions(-)

Usually, patches sent do Bluez, starte with short commit messages like:

Add ...
Fix ...
Implement ...

Note that we don't use "Added", "Fixed" etc. See the git log for reference. In this case, you should consider at least adding a short summary and your original summary as the "commit description", in the form:

<short summary, e.g. "Implement Read Blob Request"> <empty line>
<long description>

Also as Vinicius mentioned, I think your e-mail signature will show up on the commit description if someone applies it with "git am". I suggest you send your patches with "git send-email".

Another issue: looks your e-mail client replaced tabs with spaces (but it might just be Google messing up on my side).

Regards,

Signature · 3 lines
Anderson Lizardo
OpenBossa Labs - INdT
Manaus - Brazil
#3 lore raw

Re: [PATCH] Added enc_read_blob_req() API to ATT transport, to enable the reading of attributes that exceed the length of the MTU.

Quoted 2 lines · Anderson Lizardo

Another issue: looks your e-mail client replaced tabs with spaces (but it might just be Google messing up on my side).

BTW just checked and indeed it was just bad formatting by gmail webmail (from my side). The tabs on your patch are correct. The other comments I still think are valid.

Regards,

Signature · 3 lines
Anderson Lizardo
OpenBossa Labs - INdT
Manaus - Brazil
author
#4 lore raw
In reply to Brian Gix

Hi Gustavo, Vinicius,

Quoted 3 lines · Brian Gix

Atomic change to add ATT_OP_READ_BLOB_REQ encoing to ATT. No dependancies.

This patch contains only the stand-alone ATT changes, and corrects the ws issue identified by Vinicius.

Signature · 4 lines
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum