Skip to contentSkip to conversation

AutoFS creates unmountable directories when ghosting is enabled

PATCH Leonardo Chiquitto 2 participants 6 messages Dec 10, 2010 – Mar 9, 2011 Kernel automounter

lore
Share & tools
lore
#0 lore raw

Hello Ian and list,

I'd like to forward a bug report we received on openSUSE's Bugzilla [1]. Please consider the following setup to reproduce the problem:

host:~ # grep automount /etc/nsswitch.conf
automount: files

host:~ # cat /etc/auto.master
/vol /etc/auto.vol

host:~ # cat /etc/auto.vol
data1 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data1
data2 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data2
data3 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data3

host:~ # cat /etc/sysconfig/autofs
AUTOFS_OPTIONS=""
LOCAL_OPTIONS=""
APPEND_OPTIONS="yes"
DEFAULT_MASTER_MAP_NAME="auto.master"
DEFAULT_TIMEOUT=600
DEFAULT_BROWSE_MODE="yes"
DEFAULT_LOGGING="debug"
USE_MISC_DEVICE="yes"

host:~ # ls -F /vol
data1/ data2/ data3/

The problem depends on ghosting being enabled (ie, BROWSE_MODE=yes). When we try to access a non-existent key/entry, AutoFS will fail to mount it but will still create the mount point:

host:~ # ls -d /vol/invalid; sleep 10; ls -d /vol/invalid
ls: cannot access /vol/invalid: No such file or directory /vol/invalid

host:~ # ls -F /vol
data1/ data2/ data3/ invalid/

The problem happens because lookup_ghost() iterates over all cached mapents and creates directories for each entry in the cache. Since the cache also stores entries for failed mounts (negative entries), it ends up creating directories for mount points that don't exist in the map.

I tested the patch below and it resolves the problem for me, but I'm not sure if this is the best (or even the correct) way to fix the bug. I'd appreciate if you could review and comment.

Thanks,
Leonardo

[1] https://bugzilla.novell.com/show_bug.cgi?id=658734

When ghosting is enabled, don't create mount points for cached entries that don't have a valid mapent.

daemon/lookup.c +3 -0
Index: autofs-5.0.5/daemon/lookup.c
===================================================================
@@ -604,6 +604,9 @@ int lookup_ghost(struct autofs_point *ap
 			if (!strcmp(me->key, "*"))
 				goto next;
 
+			if (!me->mapent)
+				goto next;
+
 			if (*me->key == '/') {
 				/* It's a busy multi-mount - leave till next time */
 				if (list_empty(&me->multi_list))
maintainer
#1 lore raw
Quoted 37 lines · Leonardo Chiquitto

Hello Ian and list,

I'd like to forward a bug report we received on openSUSE's Bugzilla [1]. Please consider the following setup to reproduce the problem:

host:~ # grep automount /etc/nsswitch.conf
automount: files

host:~ # cat /etc/auto.master
/vol /etc/auto.vol

host:~ # cat /etc/auto.vol
data1 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data1
data2 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data2
data3 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data3

host:~ # cat /etc/sysconfig/autofs
AUTOFS_OPTIONS=""
LOCAL_OPTIONS=""
APPEND_OPTIONS="yes"
DEFAULT_MASTER_MAP_NAME="auto.master"
DEFAULT_TIMEOUT=600
DEFAULT_BROWSE_MODE="yes"
DEFAULT_LOGGING="debug"
USE_MISC_DEVICE="yes"

host:~ # ls -F /vol
data1/ data2/ data3/

The problem depends on ghosting being enabled (ie, BROWSE_MODE=yes). When we try to access a non-existent key/entry, AutoFS will fail to mount it but will still create the mount point:

host:~ # ls -d /vol/invalid; sleep 10; ls -d /vol/invalid
ls: cannot access /vol/invalid: No such file or directory /vol/invalid

Quoted 8 lines

host:~ # ls -F /vol
data1/ data2/ data3/ invalid/

The problem happens because lookup_ghost() iterates over all cached mapents and creates directories for each entry in the cache. Since the cache also stores entries for failed mounts (negative entries), it ends up creating directories for mount points that don't exist in the map.

Yes, an obvious problem.

Quoted 4 lines

I tested the patch below and it resolves the problem for me, but I'm not sure if this is the best (or even the correct) way to fix the bug. I'd appreciate if you could review and comment.

Yeah, at first I thought there were a few other cases. There still might be so let me think about it further.

Quoted 28 lines

Thanks,
Leonardo

[1] https://bugzilla.novell.com/show_bug.cgi?id=658734

When ghosting is enabled, don't create mount points for cached entries that don't have a valid mapent.

Index: autofs-5.0.5/daemon/lookup.c
===================================================================

daemon/lookup.c +3 -0
@@ -604,6 +604,9 @@ int lookup_ghost(struct autofs_point *ap
 			if (!strcmp(me->key, "*"))
 				goto next;
 
+			if (!me->mapent)
+				goto next;
+
 			if (*me->key == '/') {
 				/* It's a busy multi-mount - leave till next time */
 				if (list_empty(&me->multi_list))

_______________________________________________
autofs mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/autofs

#2 lore raw
Quoted 50 lines · Ian Kent
Quoted 37 lines · Leonardo Chiquitto

Hello Ian and list,

I'd like to forward a bug report we received on openSUSE's Bugzilla [1]. Please consider the following setup to reproduce the problem:

host:~ # grep automount /etc/nsswitch.conf
automount:    files

host:~ # cat /etc/auto.master
/vol  /etc/auto.vol

host:~ # cat /etc/auto.vol
data1 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data1 data2 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data2 data3 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data3

host:~ # cat /etc/sysconfig/autofs
AUTOFS_OPTIONS=""
LOCAL_OPTIONS=""
APPEND_OPTIONS="yes"
DEFAULT_MASTER_MAP_NAME="auto.master"
DEFAULT_TIMEOUT=600
DEFAULT_BROWSE_MODE="yes"
DEFAULT_LOGGING="debug"
USE_MISC_DEVICE="yes"

host:~ # ls -F /vol
data1/  data2/  data3/

The problem depends on ghosting being enabled (ie, BROWSE_MODE=yes). When we try to access a non-existent key/entry, AutoFS will fail to mount it but will still create the mount point:

host:~ # ls -d /vol/invalid; sleep 10; ls -d /vol/invalid
ls: cannot access /vol/invalid: No such file or directory /vol/invalid

Quoted 8 lines

host:~ # ls -F /vol
data1/  data2/  data3/  invalid/

The problem happens because lookup_ghost() iterates over all cached mapents and creates directories for each entry in the cache. Since the cache also stores entries for failed mounts (negative entries), it ends up creating directories for mount points that don't exist in the map.

Yes, an obvious problem.

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

I tested the patch below and it resolves the problem for me, but I'm not sure if this is the best (or even the correct) way to fix the bug. I'd appreciate if you could review and comment.

Yeah, at first I thought there were a few other cases. There still might be so let me think about it further.

Hello Ian,

I bisected this problem today and discovered that it appeared after the following commit:

commit 08aafab4c1d0ab6227c80f8cd1086ae78556a370

Author: Ian Kent <[email protected]>
Date:   Thu Sep 9 11:10:47 2010 +0800

autofs-5.0.5 - fix direct map not updating on reread

If the map type is explicitly specified for a map the map isn't properly updated when a re-read is requested. This is because the map stale flag is incorrectly cleared after after the lookup module reads the map instead of at the completion of the update procedure. The map stale flag should only be cleared if the map read fails for some reason, otherwise it is updated when the refresh is completed.

Does this ring a bell? If not, I'll see if I can debug it further tomorrow.

Thanks,
Leonardo

maintainer
#3 lore raw
Quoted 77 lines · Leonardo Chiquitto
Quoted 50 lines · Ian Kent
Quoted 37 lines · Leonardo Chiquitto

Hello Ian and list,

I'd like to forward a bug report we received on openSUSE's Bugzilla [1]. Please consider the following setup to reproduce the problem:

host:~ # grep automount /etc/nsswitch.conf
automount: files

host:~ # cat /etc/auto.master
/vol /etc/auto.vol

host:~ # cat /etc/auto.vol
data1 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data1 data2 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data2 data3 -fstype=nfs,ro,rsize=8192,wsize=8192,intr,nolock,nosuid srv:/data3

host:~ # cat /etc/sysconfig/autofs
AUTOFS_OPTIONS=""
LOCAL_OPTIONS=""
APPEND_OPTIONS="yes"
DEFAULT_MASTER_MAP_NAME="auto.master"
DEFAULT_TIMEOUT=600
DEFAULT_BROWSE_MODE="yes"
DEFAULT_LOGGING="debug"
USE_MISC_DEVICE="yes"

host:~ # ls -F /vol
data1/ data2/ data3/

The problem depends on ghosting being enabled (ie, BROWSE_MODE=yes). When we try to access a non-existent key/entry, AutoFS will fail to mount it but will still create the mount point:

host:~ # ls -d /vol/invalid; sleep 10; ls -d /vol/invalid
ls: cannot access /vol/invalid: No such file or directory /vol/invalid

Quoted 8 lines

host:~ # ls -F /vol
data1/ data2/ data3/ invalid/

The problem happens because lookup_ghost() iterates over all cached mapents and creates directories for each entry in the cache. Since the cache also stores entries for failed mounts (negative entries), it ends up creating directories for mount points that don't exist in the map.

Yes, an obvious problem.

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

I tested the patch below and it resolves the problem for me, but I'm not sure if this is the best (or even the correct) way to fix the bug. I'd appreciate if you could review and comment.

Yeah, at first I thought there were a few other cases. There still might be so let me think about it further.

Hello Ian,

I bisected this problem today and discovered that it appeared after the following commit:

commit 08aafab4c1d0ab6227c80f8cd1086ae78556a370

Author: Ian Kent <[email protected]>
Date:   Thu Sep 9 11:10:47 2010 +0800

autofs-5.0.5 - fix direct map not updating on reread

If the map type is explicitly specified for a map the map isn't properly updated when a re-read is requested. This is because the map stale flag is incorrectly cleared after after the lookup module reads the map instead of at the completion of the update procedure. The map stale flag should only be cleared if the map read fails for some reason, otherwise it is updated when the refresh is completed.

Quoted 1 line

Does this ring a bell? If not, I'll see if I can debug it further tomorrow.

Not really.
I'm still not sure your original patch deals with the problem fully.

Could you also have a look at and try (from kernel.org):
autofs-5.0.5-fix-prune-cache-valid-check.patch

Ian

maintainer
#4 lore raw
Quoted 20 lines · Ian Kent
Quoted 20 lines

Hello Ian,

I bisected this problem today and discovered that it appeared after the following commit:

commit 08aafab4c1d0ab6227c80f8cd1086ae78556a370

Author: Ian Kent <[email protected]>
Date:   Thu Sep 9 11:10:47 2010 +0800

autofs-5.0.5 - fix direct map not updating on reread

If the map type is explicitly specified for a map the map isn't properly updated when a re-read is requested. This is because the map stale flag is incorrectly cleared after after the lookup module reads the map instead of at the completion of the update procedure. The map stale flag should only be cleared if the map read fails for some reason, otherwise it is updated when the refresh is completed.

Quoted 7 lines
Quoted 1 line

Does this ring a bell? If not, I'll see if I can debug it further tomorrow.

Not really.
I'm still not sure your original patch deals with the problem fully.

Could you also have a look at and try (from kernel.org):
autofs-5.0.5-fix-prune-cache-valid-check.patch

Although, looking again, maybe we need both patches.

Quoted 3 lines

Ian

#5 lore raw
Quoted 23 lines · Ian Kent
Quoted 22 lines · Ian Kent
Quoted 21 lines

Hello Ian,

I bisected this problem today and discovered that it appeared after the following commit:

commit 08aafab4c1d0ab6227c80f8cd1086ae78556a370
Author: Ian Kent <[email protected]>
Date:   Thu Sep 9 11:10:47 2010 +0800

    autofs-5.0.5 - fix direct map not updating on reread

    If the map type is explicitly specified for a map the map isn't properly updated when a re-read is requested. This is because the map stale flag is incorrectly cleared after after the lookup module reads the map instead of at the completion of the update procedure. The map stale flag should only be cleared if the map read fails for some reason, otherwise it is updated when the refresh is completed.

Does this ring a bell? If not, I'll see if I can debug it further tomorrow.

Quoted 7 lines
Quoted 5 lines

Not really.
I'm still not sure your original patch deals with the problem fully.

Could you also have a look at and try (from kernel.org):
autofs-5.0.5-fix-prune-cache-valid-check.patch

Although, looking again, maybe we need both patches.

Yes, I tested again with all kernel.org patches and the problem remains.

Leonardo