Skip to contentSkip to conversation

regulator: Staticise non-exported functions in mc13892

PATCH Applied Mark Brown 2 participants 2 messages Dec 16, 2010 – Dec 17, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 regulator: Staticise non-exported functions in mc13892

No point exposing functions that aren't used elsewhere to the global namespace and sparse warns about doing so.

---
 drivers/regulator/mc13892-regulator.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/regulator/mc13892-regulator.c +3 -3
index ca1d30a..16a0532 100644
@@ -295,8 +295,8 @@ static struct mc13xxx_regulator mc13892_regulators[] = {
 	MC13892_GPO_DEFINE(PWGT2SPI, POWERMISC, mc13892_pwgtdrv),
 };
 
-int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
-		u32 val)
+static int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
+				 u32 val)
 {
 	struct mc13xxx *mc13892 = priv->mc13xxx;
 	int ret;
@@ -496,7 +496,7 @@ static int mc13892_vcam_set_mode(struct regulator_dev *rdev, unsigned int mode)
 	return ret;
 }
 
-unsigned int mc13892_vcam_get_mode(struct regulator_dev *rdev)
+static unsigned int mc13892_vcam_get_mode(struct regulator_dev *rdev)
 {
 	struct mc13xxx_regulator_priv *priv = rdev_get_drvdata(rdev);
 	int ret, id = rdev_get_id(rdev);
Signature · 1 line
1.7.1
#1 lore raw
Quoted 7 lines · Mark Brown

No point exposing functions that aren't used elsewhere to the global namespace and sparse warns about doing so.

---
 drivers/regulator/mc13892-regulator.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk