Skip to contentSkip to conversation

drm/radeon/kms: only enable underscan by default if the monitor supports audio

PATCH In review Alex Deucher 2 participants 2 messages Dec 17, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/kms: only enable underscan by default if the monitor supports audio

Users with TVs or monitors that don't overscan by default would prefer to not have underscan enabled, while users with overscanning TVs prefer underscan. This should hopefully make everyone happy as most monitors with audio tend to be TVs which overscan by default and monitors without audio don't overscan. Underscan can still be overriden by changing the connector attribute.

---
 drivers/gpu/drm/radeon/radeon_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +1 -1
index a26c1c3..3bca929 100644
@@ -1307,7 +1307,7 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc,
 			    (!(mode->flags & DRM_MODE_FLAG_INTERLACE)) &&
 			    ((radeon_encoder->underscan_type == UNDERSCAN_ON) ||
 			     ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) &&
-			      drm_detect_hdmi_monitor(radeon_connector->edid) &&
+			      drm_detect_monitor_audio(radeon_connector->edid) &&
 			      is_hdtv_mode(mode)))) {
 				if (radeon_encoder->underscan_hborder != 0)
 					radeon_crtc->h_border = radeon_encoder->underscan_hborder;
Signature · 1 line
1.7.1.1
#1 lore raw

2010/12/17 Alex Deucher <[email protected]>:

Quoted 17 lines

Users with TVs or monitors that don't overscan by default would prefer to not have underscan enabled, while users with overscanning TVs prefer underscan.  This should hopefully make everyone happy as most monitors with audio tend to be TVs which overscan by default and monitors without audio don't overscan.  Underscan can still be overriden by changing the connector attribute.

---
 drivers/gpu/drm/radeon/radeon_display.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +0 -0
index a26c1c3..3bca929 100644
@@ -1307,7 +1307,7 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc,
Quoted 8 lines

                           (!(mode->flags & DRM_MODE_FLAG_INTERLACE)) && ((radeon_encoder->underscan_type == UNDERSCAN_ON) || ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) &&
-                             drm_detect_hdmi_monitor(radeon_connector->edid) &&
+                             drm_detect_monitor_audio(radeon_connector->edid) && is_hdtv_mode(mode)))) {
                               if (radeon_encoder->underscan_hborder != 0) radeon_crtc->h_border = radeon_encoder->underscan_hborder;

I don't like it. My TV supports audio and doesn't perform any stupid overscanning by default. It's SONY Bravia 52''.

Signature · 5 lines
Rafał
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel