Skip to contentSkip to conversation

OMAP3: EVM: Convert omap3_evm_version to u32

PATCH New Dirk Behme 3 participants 3 messages Dec 18, 2010

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 OMAP3: EVM: Convert omap3_evm_version to u32

Convert the variable omap3_evm_version to u32 to work around some broken linkers from older tool chains. E.g. CodeSourcery's 2009q1-203 ld 2.19.51.20090205. Without this, these linkers stop linking 'omap3_evm' or at least issue a warning. Like

arm-none-linux-gnueabi-ld: section .bss [8003f5e0 -> 8007e337] overlaps section .rel.dyn [8003f5e0 -> 80044e57]
arm-none-linux-gnueabi-ld: section .dynsym [80044e58 -> 80044ef7] overlaps section.bss [8003f5e0 -> 8007e337]
arm-none-linux-gnueabi-ld: u-boot: section .bss vma 0x8003f5e0 overlaps previous sections

CC Sanjeev Premi <[email protected]>

---

For a discussion of this see

http://lists.denx.de/pipermail/u-boot/2010-December/083706.html

 board/ti/evm/evm.c |    4 ++--
 board/ti/evm/evm.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
board/ti/evm/evm.c +2 -2
Index: u-boot.git/board/ti/evm/evm.c
===================================================================
@@ -37,9 +37,9 @@
 #include <asm/mach-types.h>
 #include "evm.h"
 
-static u8 omap3_evm_version;
+static u32 omap3_evm_version;
 
-u8 get_omap3_evm_rev(void)
+u32 get_omap3_evm_rev(void)
 {
 	return omap3_evm_version;
 }
board/ti/evm/evm.h +1 -1
Index: u-boot.git/board/ti/evm/evm.h
===================================================================
@@ -45,7 +45,7 @@ enum {
 	OMAP3EVM_BOARD_GEN_2,		/* EVM Rev >= Rev E */
 };
 
-u8 get_omap3_evm_rev(void);
+u32 get_omap3_evm_rev(void);
 
 #if defined(CONFIG_CMD_NET)
 static void setup_net_chip(void);
#1 lore raw

PATCH 1/1 OMAP3: EVM: Convert omap3_evm_version to u32

Dear Dirk Behme,

Quoted 14 lines · In message <[email protected]> you wrote:

Convert the variable omap3_evm_version to u32 to work around some broken linkers from older tool chains. E.g. CodeSourcery's 2009q1-203 ld 2.19.51.20090205. Without this, these linkers stop linking 'omap3_evm' or at least issue a warning. Like

arm-none-linux-gnueabi-ld: section .bss [8003f5e0 -> 8007e337] overlaps section .rel.dyn [8003f5e0 -> 80044e57]
arm-none-linux-gnueabi-ld: section .dynsym [80044e58 -> 80044ef7] overlaps section.bss [8003f5e0 -> 8007e337]
arm-none-linux-gnueabi-ld: u-boot: section .bss vma 0x8003f5e0 overlaps previous sections

CC Sanjeev Premi <[email protected]>

---

Quoted 7 lines

For a discussion of this see

http://lists.denx.de/pipermail/u-boot/2010-December/083706.html

 board/ti/evm/evm.c |    4 ++--
 board/ti/evm/evm.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

I'm still unhappy about this solution, but as it appears to be the only fix we can come up with now I pull this now.

Sandeep, hope this is OK with you.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of  trouble  to  go  to
just sharpen a razor blade.  - Terry Pratchett, _The Light Fantastic_
#2 lore raw

PATCH 1/1 OMAP3: EVM: Convert omap3_evm_version to u32

Quoted 10 lines
Quoted 10 lines

---

For a discussion of this see

http://lists.denx.de/pipermail/u-boot/2010-December/083706.html

Quoted 8 lines
Quoted 3 lines
 board/ti/evm/evm.c |    4 ++--
 board/ti/evm/evm.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

I'm still unhappy about this solution, but as it appears to be the only fix we can come up with now I pull this now.

Sandeep, hope this is OK with you.

For the time being yes

Quoted 5 lines

Best regards,

Wolfgang Denk