Skip to contentSkip to conversation

mtd: cfi_cmdset_0002: add support for Samsung K8D6x16UxM NOR chips

PATCH In review Guillaume LECERF 2 participants 3 messages Dec 17, 2010 – Dec 19, 2010 Memory technology devices (MTD)

lore
Share & tools
lore

Guillaume LECERF

author
#0 lore raw

PATCH v5 1/2 mtd: cfi_cmdset_0002: add support for Samsung K8D6x16UxM NOR chips

These chips report CFI v0.0 [1], so extend cfi_fixup_major_minor() to patch all Samsung chips from 0.0 to 1.0.
Discussed and tested by the OpenWRT people [2].

[1] http://www.samsung.com/global/system/business/semiconductor/product/2007/6/11/NORFlash/64Mbit/K8D6316UTM/ds_K8D6x16UxM_rev16.pdf
[2] https://dev.openwrt.org/ticket/7348

Signed-off-by Guillaume LECERF <[email protected]>
Acked-by Wolfram Sang <[email protected]>
---
 drivers/mtd/chips/cfi_cmdset_0002.c |   16 +++++++++++++---
 1 files changed, 13 insertions(+), 3 deletions(-)
drivers/mtd/chips/cfi_cmdset_0002.c +13 -3
index 9d68ab9..324fee4 100644
@@ -392,9 +392,19 @@ static struct cfi_fixup fixup_table[] = {
 static void cfi_fixup_major_minor(struct cfi_private *cfi,
 				  struct cfi_pri_amdstd *extp)
 {
-	if (cfi->mfr == CFI_MFR_SAMSUNG && cfi->id == 0x257e &&
-	    extp->MajorVersion == '0')
-		extp->MajorVersion = '1';
+	if (cfi->mfr == CFI_MFR_SAMSUNG) {
+		if (extp->MajorVersion == '0' && extp->MinorVersion == '0') {
+			/*
+			 * Samsung K8P2815UQB and K8D6x16UxM chips
+			 * report major=0 / minor=0.
+			 */
+			printk(KERN_NOTICE "  Fixing Samsung's Amd/Fujitsu"
+			       " Extended Query version to 1.%c\n",
+			       extp->MinorVersion);
+			extp->MajorVersion = '1';
+		}
+	}
+
 	/*
 	 * SST 38VF640x chips report major=0xFF / minor=0xFF.
 	 */
author
#1 lore raw

PATCH v5 2/2 mtd: cfi_cmdset_0002: add support for Samsung K8D3x16UxC NOR chips

These chips report CFI v3.3 [1], so patch them on the fly to the more correct v1.3.
Discussed and tested by the OpenWRT people [2].

[1] http://www.samsung.com/global/system/business/semiconductor/product/2007/6/11/NORFlash/32Mbit/K8D3216UBC/ds_K8D3x16UxC_rev17.pdf
[2] https://dev.openwrt.org/ticket/866

Signed-off-by Guillaume LECERF <[email protected]>
---
 drivers/mtd/chips/cfi_cmdset_0002.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/mtd/chips/cfi_cmdset_0002.c +3 -1
index 324fee4..a43ab45 100644
@@ -393,10 +393,12 @@ static void cfi_fixup_major_minor(struct cfi_private *cfi,
 				  struct cfi_pri_amdstd *extp)
 {
 	if (cfi->mfr == CFI_MFR_SAMSUNG) {
-		if (extp->MajorVersion == '0' && extp->MinorVersion == '0') {
+		if ((extp->MajorVersion == '0' && extp->MinorVersion == '0') ||
+		    (extp->MajorVersion == '3' && extp->MinorVersion == '3')) {
 			/*
 			 * Samsung K8P2815UQB and K8D6x16UxM chips
 			 * report major=0 / minor=0.
+			 * K8D3x16UxC chips report major=3 / minor=3.
 			 */
 			printk(KERN_NOTICE "  Fixing Samsung's Amd/Fujitsu"
 			       " Extended Query version to 1.%c\n",
#2 lore raw
In reply to Guillaume LECERF
Quoted 9 lines · Guillaume LECERF

These chips report CFI v0.0 [1], so extend cfi_fixup_major_minor() to patch all Samsung chips from 0.0 to 1.0.
Discussed and tested by the OpenWRT people [2].

[1] http://www.samsung.com/global/system/business/semiconductor/product/2007/6/11/NORFlash/64Mbit/K8D6316UTM/ds_K8D6x16UxM_rev16.pdf
[2] https://dev.openwrt.org/ticket/7348

Signed-off-by Guillaume LECERF <[email protected]>
Acked-by Wolfram Sang <[email protected]>

Pushed both patches to l2-mtd-2.6.git, thank you!

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Битюцкий Артём)