Skip to contentSkip to conversation

linux: support 'make linux26-nconfig'

PATCH New Bjørn Forsman 2 participants 5 messages Dec 19, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 linux: support 'make linux26-nconfig'

---
 linux/linux.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
linux/linux.mk +1 -1
index 23b89cf..6636a35 100644
@@ -159,7 +159,7 @@ $(LINUX26_DIR)/.stamp_installed: $(LINUX26_DIR)/.stamp_compiled
 
 linux26: host-module-init-tools $(LINUX26_DEPENDENCIES) $(LINUX26_DIR)/.stamp_installed
 
-linux26-menuconfig linux26-xconfig linux26-gconfig: dirs $(LINUX26_DIR)/.stamp_configured
+linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: dirs $(LINUX26_DIR)/.stamp_configured
 	$(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) $(subst linux26-,,$@)
 
 # Support for rebuilding the kernel after the initramfs file list has
Signature · 1 line
1.7.1
#1 lore raw

PATCH 2/2 linux: fix linux-% shortcut targets

linux-% shortcut targets (short for linux26-%) ignores the ouput dir $(O) so that 'make O=output.arm linux-menuconfig' is actually run in the default $(O) directory output/ and not in output.arm/. Fix by passing on $(O).

---
 linux/linux.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
linux/linux.mk +1 -1
index 6636a35..68d2d6d 100644
@@ -200,4 +200,4 @@ endif
 endif
 
 linux-%:
-	$(MAKE) $(subst linux-,linux26-,$@)
+	$(MAKE) O=$(O) $(subst linux-,linux26-,$@)
Signature · 1 line
1.7.1
#2 lore raw

PATCH 2/2 linux: fix linux-% shortcut targets

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bj?rn" == Bj?rn Forsman <[email protected]> writes:

Hi,

Bj?rn> linux-% shortcut targets (short for linux26-%) ignores the ouput Bj?rn> dir $(O) so that 'make O=output.arm linux-menuconfig' is Bj?rn> actually run in the default $(O) directory output/ and not in Bj?rn> output.arm/. Fix by passing on $(O).

This is still not correct. You should only pass O= if it was given on the command line, otherwise BR will look in output/.config for the configuration for non-out-of-tree-builds. I've added EXTRAMAKEARGS in the toplevel makefile a while ago to handle it.

Committed with that change.

Bj?rn> Signed-off-by: Bj?rn Forsman <[email protected]> Bj?rn> ---

 Bj?rn>  linux/linux.mk |    2 +-

Bj?rn> 1 files changed, 1 insertions(+), 1 deletions(-)

Bj?rn> diff --git a/linux/linux.mk b/linux/linux.mk Bj?rn> index 6636a35..68d2d6d 100644
Bj?rn> --- a/linux/linux.mk
Bj?rn> +++ b/linux/linux.mk
Bj?rn> @@ -200,4 +200,4 @@ endif
Bj?rn> endif

Bj?rn> linux-%:
Bj?rn> - $(MAKE) $(subst linux-,linux26-,$@)
Bj?rn> + $(MAKE) O=$(O) $(subst linux-,linux26-,$@)
Bj?rn> --
Bj?rn> 1.7.1

Bj?rn> _______________________________________________ Bj?rn> buildroot mailing list
Bj?rn> buildroot at busybox.net
Bj?rn> http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/2 linux: fix linux-% shortcut targets

Hi,

2010/12/19 Peter Korsgaard <[email protected]>:

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bj?rn" == Bj?rn Forsman <[email protected]> writes:

Hi,

?Bj?rn> linux-% shortcut targets (short for linux26-%) ignores the ouput ?Bj?rn> dir $(O) so that 'make O=output.arm linux-menuconfig' is ?Bj?rn> actually run in the default $(O) directory output/ and not in ?Bj?rn> output.arm/. Fix by passing on $(O).

Quoted 6 lines

This is still not correct. You should only pass O= if it was given on the command line, otherwise BR will look in output/.config for the configuration for non-out-of-tree-builds. I've added EXTRAMAKEARGS in the toplevel makefile a while ago to handle it.

Committed with that change.

Thanks for fixing and committing!

Best regards,
Bj?rn Forsman

#4 lore raw

PATCH 1/2 linux: support 'make linux26-nconfig'

In reply to Bjørn Forsman
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bj?rn" == Bj?rn Forsman <[email protected]> writes:

Bj?rn> Signed-off-by: Bj?rn Forsman <[email protected]> Bj?rn> ---

 Bj?rn>  linux/linux.mk |    2 +-

Bj?rn> 1 files changed, 1 insertions(+), 1 deletions(-)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard