Skip to contentSkip to conversation

OMAP4: Pandaboard: Fix MMC card detect gpio line

PATCH New Nishanth Menon 2 participants 2 messages Dec 21, 2010 – Dec 22, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 OMAP4: Pandaboard: Fix MMC card detect gpio line

From: Raghuveer Murthy <[email protected]>

commit bf56f0a6668cd (2.6.37-rc1), from Nishanth Menon attempted to fix card detection for PandaBoard, unfortunately, the fix missed to initialize .gpio_cd member of omap2_hsmmc_info. This results in a default value of '0', which is a valid GPIO line. On PandaBoard, the side effect of this is that GPIO line 0 controls the powering TFP410 DVI chip, and without the fix DVI chip is inadvertently powered.

---
v2: updated comment description to point out the potential regression.
it might be nice to have this in .37 rc cycle as the change was introduced in .37-rc1, however, the DVI functionality(which is impacted as a side effect) is not enabled in .37 rc.

v1: http://marc.info/?t=129172419600002&r=1&w=2

 arch/arm/mach-omap2/board-omap4panda.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap4panda.c +1 -0
index 1ecd0a6..da24745 100644
@@ -142,6 +142,7 @@ static struct omap2_hsmmc_info mmc[] = {
 		.mmc		= 1,
 		.caps		= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
 		.gpio_wp	= -EINVAL,
+		.gpio_cd	= -EINVAL,
 	},
 	{}	/* Terminator */
 };
Signature · 1 line
1.6.3.3
maintainer
#1 lore raw

PATCH v2 1/1 OMAP4: Pandaboard: Fix MMC card detect gpio line

Quoted 14 lines · Nishanth Menon

From: Raghuveer Murthy <[email protected]>

commit bf56f0a6668cd (2.6.37-rc1), from Nishanth Menon attempted to fix card detection for PandaBoard, unfortunately, the fix missed to initialize .gpio_cd member of omap2_hsmmc_info. This results in a default value of '0', which is a valid GPIO line. On PandaBoard, the side effect of this is that GPIO line 0 controls the powering TFP410 DVI chip, and without the fix DVI chip is inadvertently powered.

Quoted 7 lines

---
v2: updated comment description to point out the potential regression.
it might be nice to have this in .37 rc cycle as the change was introduced in .37-rc1, however, the DVI functionality(which is impacted as a side effect) is not enabled in .37 rc.

I'll queue this for .38 because of "it never worked earlier either" logic.

Thanks,

Tony