Skip to contentSkip to conversation

mv_xor: fix race in tasklet function

PATCH In review Saeed Bishara 2 participants 2 messages Dec 21, 2010 – Dec 22, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mv_xor: fix race in tasklet function

use mv_xor_slot_cleanup() instead of __mv_xor_slot_cleanup() as the former function aquires the spin lock that needed to protect the drivers data.

---
 drivers/dma/mv_xor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/mv_xor.c +1 -1
index 411d5bf..a25f5f6 100644
@@ -449,7 +449,7 @@ mv_xor_slot_cleanup(struct mv_xor_chan *mv_chan)
 static void mv_xor_tasklet(unsigned long data)
 {
 	struct mv_xor_chan *chan = (struct mv_xor_chan *) data;
-	__mv_xor_slot_cleanup(chan);
+	mv_xor_slot_cleanup(chan);
 }
 
 static struct mv_xor_desc_slot *
Signature · 1 line
1.6.0.4
#1 lore raw

Dan, can you please merge this patch?

Quoted 20 lines · Saeed Bishara

use mv_xor_slot_cleanup() instead of __mv_xor_slot_cleanup() as the former function aquires the spin lock that needed to protect the drivers data.

---
 drivers/dma/mv_xor.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/mv_xor.c +1 -1
index 411d5bf..a25f5f6 100644
@@ -449,7 +449,7 @@ mv_xor_slot_cleanup(struct mv_xor_chan *mv_chan)
  static void mv_xor_tasklet(unsigned long data)
  {
        struct mv_xor_chan *chan = (struct mv_xor_chan *) data;
-       __mv_xor_slot_cleanup(chan);
+       mv_xor_slot_cleanup(chan);
  }
 
Quoted 5 lines

 static struct mv_xor_desc_slot *
--
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html