Skip to contentSkip to conversation

ACPI: Fixed some coding style issues in fan.c and battery.c

PATCH In review Jan Füsting 2 participants 2 messages Dec 21, 2010 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 ACPI: Fixed some coding style issues in fan.c and battery.c

Fixed some coding style issues in fan.c and battery.c

---
 drivers/acpi/battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +1 -1
index 16fc4df..35d0c6f 100644
@@ -580,7 +580,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
 {
 	if (dmi_name_in_vendors("Acer") && battery->power_unit)
 		set_bit(ACPI_BATTERY_QUIRK_SIGNED16_CURRENT, &battery->flags);
-}	
+}
 
 /*
  * According to the ACPI spec, some kinds of primary batteries can
Signature · 6 lines
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 2 lines · Jan Füsting

Fixed some coding style issues in fan.c and battery.c

Which kind of coding style issues you have fixed? Looking at the diff I couldn't figure out the *issues* as described in the commit message. Care to resend describing which coding style issues you are fixing?

Also the diff shows a change only in batter.c. Did you forget something (fan.c) ?

Thanks.

Ah, another thing, you have repeated the subject in the commit message, if they almost the same except the ACPI, then no need to repeat it in the commit message.

Quoted 21 lines

---
 drivers/acpi/battery.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +1 -2
index 16fc4df..35d0c6f 100644
@@ -580,7 +580,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
  {
        if (dmi_name_in_vendors("Acer") && battery->power_unit)
                set_bit(ACPI_BATTERY_QUIRK_SIGNED16_CURRENT, &battery->flags);
-}
+}
 
  /*
  * According to the ACPI spec, some kinds of primary batteries can
--

1.7.2.3

Quoted 6 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html