tracing: Only trace sched_wakeup if it actually work something up
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 16 lines · tip-bot for Steven Rostedt
Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Author: Steven Rostedt <[email protected]> AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500 Committer: Steven Rostedt <[email protected]> CommitDate: Fri, 3 Dec 2010 10:46:59 -0500tracing: Only trace
sched_wakeupif it actually work something upCurrently the tracepoint
sched_wakeuptraces the wakeup event even if the wakeup failed to wake anything up. This is quite stupid but it happens because we did not want to add a conditional to the core kernel code that would just slow down the wakeup events.This patch changes the wakeup tracepoints to use the
Quoted 7 lines
DEFINE_EVENT_CONDITIONAL()to test the "success" parameter and will only trace the event if the wakeup was successfull.
The success field in the tracepoint is removed since it is no longer needed.
I NAKed this, its stupid.
Quoted 19 lines · Peter Zijlstra
Quoted 18 lines · tip-bot for Steven Rostedt
Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Author: Steven Rostedt <[email protected]> AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500 Committer: Steven Rostedt <[email protected]> CommitDate: Fri, 3 Dec 2010 10:46:59 -0500tracing: Only trace
sched_wakeupif it actually work something upCurrently the tracepoint
sched_wakeuptraces the wakeup event even if the wakeup failed to wake anything up. This is quite stupid but it happens because we did not want to add a conditional to the core kernel code that would just slow down the wakeup events.This patch changes the wakeup tracepoints to use the
DEFINE_EVENT_CONDITIONAL()
Quoted 7 lines
Quoted 5 lines
to test the "success" parameter and will only trace the event if the wakeup was successfull.
The success field in the tracepoint is removed since it is no longer needed.
I NAKed this, its stupid.
And wrong too, I got a patch that makes success:=true, I also got a patch removing success entirely but people started wanking that their proglets rely on having it :/
Ideally I'd commit the removal and let whatever breaks break.
Quoted 19 lines · Peter Zijlstra
Quoted 18 lines · tip-bot for Steven Rostedt
Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Author: Steven Rostedt <[email protected]> AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500 Committer: Steven Rostedt <[email protected]> CommitDate: Fri, 3 Dec 2010 10:46:59 -0500tracing: Only trace
sched_wakeupif it actually work something upCurrently the tracepoint
sched_wakeuptraces the wakeup event even if the wakeup failed to wake anything up. This is quite stupid but it happens because we did not want to add a conditional to the core kernel code that would just slow down the wakeup events.This patch changes the wakeup tracepoints to use the
DEFINE_EVENT_CONDITIONAL()
Quoted 7 lines
Quoted 5 lines
to test the "success" parameter and will only trace the event if the wakeup was successfull.
The success field in the tracepoint is removed since it is no longer needed.
I NAKed this, its stupid.
I wouldn't call it stupid, but unnecessary, yes.
Anyway, it was the last patch of the series.
Ingo, can you revert this last patch?
Thanks,
-- Steve
Quoted 26 lines · Steven Rostedt
Quoted 25 lines · Peter Zijlstra
Quoted 23 lines · tip-bot for Steven Rostedt
Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7 Author: Steven Rostedt <[email protected]> AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500 Committer: Steven Rostedt <[email protected]> CommitDate: Fri, 3 Dec 2010 10:46:59 -0500tracing: Only trace
sched_wakeupif it actually work something upCurrently the tracepoint
sched_wakeuptraces the wakeup event even if the wakeup failed to wake anything up. This is quite stupid but it happens because we did not want to add a conditional to the core kernel code that would just slow down the wakeup events.This patch changes the wakeup tracepoints to use the
DEFINE_EVENT_CONDITIONAL()to test the "success" parameter and will only trace the event if the wakeup was successfull.
The success field in the tracepoint is removed since it is no longer needed.
Quoted 7 lines
Quoted 1 line
I NAKed this, its stupid.
I wouldn't call it stupid, but unnecessary, yes.
Anyway, it was the last patch of the series.
Ingo, can you revert this last patch?
Yeah, done.
Thanks guys,
Ingo