Skip to contentSkip to conversation

ath9k_hw: Fix incorrect macversion and macrev checks

PATCH In review Senthil Balasubramanian 2 participants 5 messages Dec 22, 2010 – Dec 23, 2010 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 ath9k_hw: Fix incorrect macversion and macrev checks

There are few places where we are checking for macversion and revsions before RTC is powered ON. However we are reading the macversion and revisions only after RTC is powered ON and so both macversion and revisions are actully zero and this leads to incorrect srev checks

Incorrect srev checks can cause registers to be configured wrongly and can cause unexpected behavior. Fixing this seems to address the ASPM issue that we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 enabled without this fix.

fix this by reading the macversion and revisisons even before we start using them. There is no reason why should we delay reading this info until RTC is powered on as this is just a register information.

---
v2 -- fixed reading revisions unnecessarily during every reset. v3 -- added more information to the commit log.

 drivers/net/wireless/ath/ath9k/hw.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath9k/hw.c +2 -2
index 4b51ed4..0a0ba80 100644
@@ -491,6 +491,8 @@ static int __ath9k_hw_init(struct ath_hw *ah)
 	if (ah->hw_version.devid == AR5416_AR9100_DEVID)
 		ah->hw_version.macVersion = AR_SREV_VERSION_9100;
 
+	ath9k_hw_read_revisions(ah);
+
 	if (!ath9k_hw_set_reset_reg(ah, ATH9K_RESET_POWER_ON)) {
 		ath_err(common, "Couldn't reset chip\n");
 		return -EIO;
@@ -1078,8 +1080,6 @@ static bool ath9k_hw_set_reset_power_on(struct ath_hw *ah)
 		return false;
 	}
 
-	ath9k_hw_read_revisions(ah);
-
 	return ath9k_hw_set_reset(ah, ATH9K_RESET_WARM);
 }
 
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 9 lines · Senthil Balasubramanian

There are few places where we are checking for macversion and revsions before RTC is powered ON. However we are reading the macversion and revisions only after RTC is powered ON and so both macversion and revisions are actully zero and this leads to incorrect srev checks

Incorrect srev checks can cause registers to be configured wrongly and can cause unexpected behavior. Fixing this seems to address the ASPM issue that we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 enabled without this fix.

On what chipset? Or did we see this on one chipset and suspect it can affect others?

Luis

#2 lore raw
Quoted 7 lines · Luis R. Rodriguez
Quoted 5 lines · Senthil Balasubramanian

There are few places where we are checking for macversion and revsions before RTC is powered ON. However we are reading the macversion and revisions only after RTC is powered ON and so both macversion and revisions are actully zero and this leads to incorrect srev checks

Quoted 7 lines
Quoted 4 lines

Incorrect srev checks can cause registers to be configured wrongly and can cause unexpected behavior. Fixing this seems to address the ASPM issue that we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 enabled without this fix.

On what chipset? Or did we see this on one chipset and suspect it can affect others?

We have noticed on Merlin and it is obviously incorrect for other chipsets also :-(. Please feel free to rephrase/rework on this patch if you think something is still lacking/missing...

Quoted 2 lines

Luis

#3 lore raw
Quoted 8 lines · Senthilkumar Balasubramanian
Quoted 7 lines · Luis R. Rodriguez
Quoted 5 lines · Senthil Balasubramanian

There are few places where we are checking for macversion and revsions before RTC is powered ON. However we are reading the macversion and revisions only after RTC is powered ON and so both macversion and revisions are actully zero and this leads to incorrect srev checks

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

Incorrect srev checks can cause registers to be configured wrongly and can cause unexpected behavior. Fixing this seems to address the ASPM issue that we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 enabled without this fix.

On what chipset? Or did we see this on one chipset and suspect it can affect others?

We have noticed on Merlin and it is obviously incorrect for other chipsets

This should be read as "we have noticed this issue with ar9380/ar9382"

Quoted 4 lines

also :-(. Please feel free to rephrase/rework on this patch if you think something is still lacking/missing...

Quoted 2 lines

Luis

#4 lore raw
Quoted 14 lines · Senthil Balasubramanian
Quoted 13 lines · Senthilkumar Balasubramanian
Quoted 12 lines · Luis R. Rodriguez
Quoted 9 lines · Senthil Balasubramanian

There are few places where we are checking for macversion and revsions before RTC is powered ON. However we are reading the macversion and revisions only after RTC is powered ON and so both macversion and revisions are actully zero and this leads to incorrect srev checks

Incorrect srev checks can cause registers to be configured wrongly and can cause unexpected behavior. Fixing this seems to address the ASPM issue that we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 enabled without this fix.

Quoted 4 lines
Quoted 3 lines
Quoted 2 lines

On what chipset? Or did we see this on one chipset and suspect it can affect others?

We have noticed on Merlin and it is obviously incorrect for other chipsets

This should be read as "we have noticed this issue with ar9380/ar9382"

The reason I asked about the chipset is ar9380 stuff won't be relevant for longterm 2.6.35.

Luis