Skip to contentSkip to conversation

omap2: Make OMAP2PLUS select OMAP_DM_TIMER

PATCH New Ben Gamari 2 participants 3 messages Dec 24, 2010

Subsystems (2)
lore
Share & tools
lore

Ben Gamari

author
#0 lore raw

PATCH 1/1 omap2: Make OMAP2PLUS select OMAP_DM_TIMER

It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS. Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems correct for the architecture to depend upon OMAP_DM_TIMER, otherwise unsuspecting integrators will be faced with a whole bunch of linker errors at the end of their kernel build:

arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to omap_dm_timer_stop' /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to omap_dm_timer_get_fclk' /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
...

---
 arch/arm/plat-omap/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-omap/Kconfig +1 -0
index 92c5bb7..784c06c 100644
@@ -18,6 +18,7 @@ config ARCH_OMAP1
 config ARCH_OMAP2PLUS
 	bool "TI OMAP2/3/4"
 	select COMMON_CLKDEV
+	select OMAP_DM_TIMER
 	help
 	  "Systems based on OMAP2, OMAP3 or OMAP4"
 
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 omap2: Make OMAP2PLUS select OMAP_DM_TIMER

Quoted 11 lines · Ben Gamari

It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS. Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems correct for the architecture to depend upon OMAP_DM_TIMER, otherwise unsuspecting integrators will be faced with a whole bunch of linker errors at the end of their kernel build:

arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to omap_dm_timer_stop' /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to omap_dm_timer_get_fclk' /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
...

One more thing.. Can you please reply with your
Signed-off-by: line so this can be applied?

Thanks

Tony

author
#2 lore raw

PATCH 1/1 omap2: Make OMAP2PLUS select OMAP_DM_TIMER

Quoted 3 lines · Tony Lindgren

One more thing.. Can you please reply with your
Signed-off-by: line so this can be applied?