KVM: MMU: Fix incorrect direct gfn for unpaged mode shadow
PATCH 1/1 KVM: MMU: Fix incorrect direct gfn for unpaged mode shadow
We use the physical address instead of the base gfn for the four PAE page directories we use in unpaged mode. When the guest accesses an address above 1GB that is backed by a large host page, a BUG_ON() in kvm_mmu_set_gfn() triggers.
Resolves: https://bugzilla.kernel.org/show_bug.cgi?id=21962
Reported-and-tested-by Nicolas Prochazka <[email protected]>
KVM-Stable-Tag.
Signed-off-by Avi Kivity <[email protected]>
--- arch/x86/kvm/mmu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/x86/kvm/mmu.c +2 -1
@@ -2406,7 +2406,8 @@ static int mmu_alloc_direct_roots(struct kvm_vcpu *vcpu)ASSERT (!VALID_PAGE (root));spin_lock (&vcpu->kvm->mmu_lock);kvm_mmu_free_some_pages (vcpu); - sp =kvm_mmu_get_page (vcpu, i <<30 , i <<30 , + sp =kvm_mmu_get_page (vcpu, i << (30 -PAGE_SHIFT ), + i <<30 ,PT32_ROOT_LEVEL ,1 ,ACC_ALL ,NULL ); root =__pa (sp->spt);
Signature · 1 line
1.7.1