Patch Description
cover Patch Description
This patch is to cancel the pending sms via D-Bus. Till now, I'm still not sure what kind of sms should be cancelled. In theory, one message, or part of it, would be sent by oFono can be cancelled. For some examples: Any part of a message that has never been sent can be cancelled; one message was sent but failed, we can cancel before retry; One message is split into several pieces, we can cancel before all of them are sent. In current patch, I only cancel the sms that has never been sent. I wonder if it's enough or I should handle all the situations above.
Another question here is about the existed code. There is a hashtable "messages" in struct ofono_sms. Can we store the state in the tx_queue_entry, and remove the hashtable thoroughly to make the code more simple?
Yang Gu (1):
sms: Cancel pending message
include/history.h | 1 + src/sms.c | 132 ++++++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 106 insertions(+), 27 deletions(-)
PATCH 1/1 sms: Cancel pending message
--- include/history.h | 1 + src/sms.c | 132 ++++++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 106 insertions(+), 27 deletions(-)
include/history.h +1 -0
@@ -35,6 +35,7 @@ enum ofono_history_sms_status {OFONO_HISTORY_SMS_STATUS_PENDING ,OFONO_HISTORY_SMS_STATUS_SUBMITTED ,OFONO_HISTORY_SMS_STATUS_SUBMIT_FAILED , +OFONO_HISTORY_SMS_STATUS_SUBMIT_CANCELLED ,OFONO_HISTORY_SMS_STATUS_DELIVERED , OFONO_HISTORY_SMS_STATUS_DELIVER_FAILED, };
src/sms.c +105 -27
215 lines not on this page · raw message
Signature · 1 line
1.7.1
Re: [PATCH 1/1] sms: Cancel pending message
Hi Yang
Quoted 4 lines · Yang Gu
---
include/history.h | 1 +
src/sms.c | 132 ++++++++++++++++++++++++++++++++++++++++++-----------2 files changed, 106 insertions(+), 27 deletions(-)
This patch does not apply anymore and some changes look a bit weird to me. Are you willing to rebase, re-work and re-submit this patch?
Otherwise I'd like to implement this functionality myself.
best regards,
Lucas De Marchi
Re: [PATCH 1/1] sms: Cancel pending message
Hi,
Quoted 7 lines · Lucas De Marchi
Hi Yang
Quoted 3 lines · Yang Gu
--- include/history.h | 1 + src/sms.c | 132++++++++++++++++++++++++++++++++++++++++++-----------
Quoted 8 lines
Quoted 1 line
2 files changed, 106 insertions(+), 27 deletions(-)This patch does not apply anymore and some changes look a bit weird to me. Are you willing to rebase, re-work and re-submit this patch?
Otherwise I'd like to implement this functionality myself.
Now I'm in the holidays for Chinese New Year, and may not rebase the patch
within 10 days (Don't have development machine at hand). So if you're willing to work on this these days, I'm surely OK that you have your own version.
Quoted 5 lines
best regards,
Lucas De Marchi
Signature · 2 lines
-Regards -Yang